From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95ED9A0A0C; Thu, 29 Jul 2021 00:06:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2616040040; Thu, 29 Jul 2021 00:06:53 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) by mails.dpdk.org (Postfix) with ESMTP id 4879B4003C; Thu, 29 Jul 2021 00:06:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hE8ntfQ2LBW5uWSM+p27/t16b+UyskQ5lforSka9+yF2iVLIQ679Daz74ugLjVa/Ehf4hkt6T7CkKHiwsw/Z6ngDlZa52QbZjtJUvh+jUrQ7ddE/Wt6oncKtbh/CQapYlB7MIz2hAppaTTx172vXS1MRXqP4wTOfo/6ws7eTVl78rbmm2Qe/Z5FGwuxh6TY8sI9WCG27AYtVQhSUD3N+vxyjJ1//nuC/0MtKwP4PKQH5d8S0P5bYJaYxUq0WmAp19YpNvtHqbkX4kcKh1oleqc/OPweRAFTGGZyIu5S6tl5KegGJyeNi/abmRknrdOQi4gVwpk6cNdp/hi3ak+g8vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0tcJWDXa1h9yb2+lb/WzJjR9RpLOoEyHW4YQmlAXt0=; b=YkaV13qnRRKy9w4e50/H8RTh0ApsV2Nxwb4ddOdpOdUr8JWyuQbuopjoKKHiOggBLJsgXC/Wv0pCHbT6VpfAQs8TjQ8u6K/dJ6jCb1K3NYTUM/ffmrF27iqfox2R6uiUR+SdoxyP71YyuVo/ZnZGoEbjPP6/zo58HkRkrEhfJef+A9ApRFR8AdvOIyvJ4+dPuedPJ6JSRiDTNhkRwgoIVrvDY1F0N478MPXVMHlIX4bliBH1pbnIAR90u0EXAPp+6zb4vALPVd1Jq8Pn1SMjIL3SKV9rZwJcE8Uq8y1QGBYGbyC5NjfnElrT8nZ5nv/Scad5hHYz11y7QlLODKTNow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0tcJWDXa1h9yb2+lb/WzJjR9RpLOoEyHW4YQmlAXt0=; b=iPBDgzs81Mr6AQfNjlaMaXBmECwquAfWadEiq8JrhX9kz6hpoE5y7Ze9tHjp8kvmSErafpgS2ZtZd3P6EGFxatiAL+qqZ0jOnvGbj+ZNmYAMxGff9VrJD1luiDJQ+zyeTcVhxKbhRM2aAuHK41y006aWKyVMDS64BPQ42lLsaC9FJ6ZsiaB/byJy/JlafJDtrGV3r24/5TnRlFCCRLHW5hpXgCPCwPVvleJHZ6iWOwqh8f6e7pRVGy2j6xn6P2okeGA3sMOcF0uASqVauvCoAX8uH/X/EcS1HnMxDQO8aW11erSfXSvdZ01+hbzJC4KwPezBAz2fqitQCUydPISyPA== Received: from BN6PR22CA0042.namprd22.prod.outlook.com (2603:10b6:404:37::28) by CY4PR12MB1589.namprd12.prod.outlook.com (2603:10b6:910:e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Wed, 28 Jul 2021 22:06:47 +0000 Received: from BN8NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:404:37:cafe::53) by BN6PR22CA0042.outlook.office365.com (2603:10b6:404:37::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Wed, 28 Jul 2021 22:06:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT039.mail.protection.outlook.com (10.13.177.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4373.18 via Frontend Transport; Wed, 28 Jul 2021 22:06:47 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 22:06:44 +0000 From: Dmitry Kozlyuk To: CC: Andrew Rybchenko , , Viacheslav Ovsiienko , Xueming Li , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Parav Pandit , Stephen Hemminger , Long Li Date: Thu, 29 Jul 2021 01:06:18 +0300 Message-ID: <20210728220618.1048721-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210727102720.902969-1-dkozlyuk@nvidia.com> References: <20210727102720.902969-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8295253e-39f9-4998-3b17-08d95213fe84 X-MS-TrafficTypeDiagnostic: CY4PR12MB1589: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3j5sNofgHW9m8bBbA8EHVILkg6K4ABltK2jHf0ppYBOIDRYol/3HEHUyfJ92Ge7MXyNpi2LtBnmbNXcAwID1FeQoHRyysPyVkAs5YgqLSM0T9Y9k+NtKO5NAYUTYoM/vdseI6LhutOzsfYkFanES5oxSjEWfIwuY77AvtRJ8fUyEHtrJN2jjhq5Wq6mRXFmbLMfJPN5GrIALp1tFn6esQma2ozIgaW1RASN6GCwiJR1hRKhDOK0jiaruuMX+zb1R6Nht0r1WeDD3b/EPdXfpOfNt7dI+YuG99g4f4QVl0b2VFbt6scnPpiqh1UEDnGQ450M/C+Bldy1MSg6iC31fHS9KVJlMhQ2foyls2mzUHGTtWLSFtTHIIB6ShsgkOj3wYTz6uw9xIRugJWbxnoqxROWjYNCMoiegnHrPEPXBL4TnNsTzxVGlzxmtkwTCmLvFBSg6s/PfLSFVhjFXdGtHggTM/TAG2GKp1WBQiBUbXZ4+pQRKzi+xSkg+W9e3ot7GJ5+INopYGAnvq/nuC+f8vlOWDx/6wuJywFgsO/2A5+LiWGkGs3gIfNUrO5gAhrRZfuS99qvkZK9iKvzceCkPPMPXUIkz+klTx1cgg8fktvqJ9GPRexoJf+/7lY4HlQQjEsDZXtynSuxs75s9+vRWJfBcmkoug37RmrJRiZvtSLEyetN5GlpTbG1irb09R7B8yT8HjFvyAkFWhMJMofvxfw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(36840700001)(46966006)(336012)(186003)(70586007)(83380400001)(2616005)(426003)(82310400003)(6916009)(4326008)(54906003)(7696005)(6286002)(478600001)(55016002)(5660300002)(82740400003)(7416002)(8676002)(26005)(70206006)(16526019)(86362001)(7636003)(8936002)(6666004)(36860700001)(316002)(2906002)(1076003)(356005)(47076005)(36756003)(36906005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2021 22:06:47.6051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8295253e-39f9-4998-3b17-08d95213fe84 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1589 Subject: [dpdk-dev] [PATCH v4] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI, vmbus, and auxiliary drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or intervention. Reduce level to INFO, reword the message, and suppress it when there is only one NUMA node, because NUMA-awareness does not matter in this case. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko Reviewed-by: Xueming Li --- v4: Fix build errors and a typo (CI). v3: Keep resetting device NUMA node to 0 (Andrew Rybchenko). v2: Add NUMA node count check (Stephen Hemminger). doc/guides/nics/ena.rst | 2 +- drivers/bus/auxiliary/auxiliary_common.c | 4 +++- drivers/bus/pci/pci_common.c | 4 +++- drivers/bus/vmbus/vmbus_common.c | 4 +++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 63951098ea..c506fd5bd4 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -246,7 +246,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index 89e653c54e..1d5af8e126 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -106,7 +107,8 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv, } if (dev->device.numa_node < 0) { - AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0"); + if (rte_socket_count() > 1) + AUXILIARY_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0"); dev->device.numa_node = 0; } diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..bafcddf96e 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -190,7 +191,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + if (rte_socket_count() > 1) + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..2ec4d77398 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -112,7 +113,8 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + if (rte_socket_count() > 1) + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0"); dev->device.numa_node = 0; } -- 2.25.1