From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2AF70A0C47;
	Fri, 30 Jul 2021 10:35:14 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6AE404068B;
	Fri, 30 Jul 2021 10:35:13 +0200 (CEST)
Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com
 [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id AADAA4003E
 for <dev@dpdk.org>; Fri, 30 Jul 2021 10:35:11 +0200 (CEST)
Received: by mail-wr1-f52.google.com with SMTP id b7so10255724wri.8
 for <dev@dpdk.org>; Fri, 30 Jul 2021 01:35:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=E8byA3eKd9FXV/p6VN+V1kWltYC9IjidQGYfroSmAp0=;
 b=W+Rfk5RU/GydDYsoGoomwuv5Slb7t6N3A01fqJXxFBhLr36hgQPVkcDTw257pAxgH2
 nRH0UoziaCuHeJln+eAa3yeHoaICwEK8FOqixjqqnXlVRmg8MHHWFJqLusqtmpOagJZQ
 Rf6uRM4J8AhhMWyvJPfJdA9J46qjRbkOsUn0UkCEImuOgiyM/xwzJXterpuJSzQOs0UK
 NhwxNdyDASPdvePoDY+0QP8pjSzWSkjp1mifLwo6j3nUz/CiKBjTPtqkS8f9TiQx0SsL
 8uyfN5hmAk1YffZSfPmFBwf3/B3aveLdEzoppVUuNJ/GoSysZmKcd2nBv1LMN33vfcDZ
 psUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=E8byA3eKd9FXV/p6VN+V1kWltYC9IjidQGYfroSmAp0=;
 b=qkc2VjOnoLGKB3JA22O1i/unQFX/ls410Z5sLfbUA5jJqh7kx1dwMHXygZvwi5ATOn
 yDQ4akFVvb6uOLF5n3ycqNtMA73kAJgXEP15TZrCZQJWWKlrRFS6cmNMiZLdFozF5kfv
 EDzS6KbLdDD4Q625rM9tgg2pmLyP1x1thfDqcLzOBfQ2e11Q739uMSpt11GneM6adx6C
 b842+R7QgRzah7dbm4oBT+QeZoUBHq8fw4TxsxCSY3f3HX/mis3pUNYmqx3TolRiqeTW
 LWC4cvyDCwYFJxji/50oeHdtzDFlFynS9M0MLYAVAA3KnVfw4g9F2DRAKIm0/XW6Rjos
 LyXQ==
X-Gm-Message-State: AOAM531ewwyme2Em6uArThUPB4+bwB304rBNEjZasH2Aq3QIh9RU3Y59
 aDa58xk4wMPkxkJ7Zy0bExeDJ+9tcA/K+A==
X-Google-Smtp-Source: ABdhPJwJe7mrATcD26sr9WACzz06AryJb/82lEquRbWvjHtuk/7Ukg0OdwPt1FCEUykWeah/V878Xg==
X-Received: by 2002:a05:6000:18cc:: with SMTP id
 w12mr1698447wrq.96.1627634111366; 
 Fri, 30 Jul 2021 01:35:11 -0700 (PDT)
Received: from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id o14sm1063455wmq.31.2021.07.30.01.35.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 30 Jul 2021 01:35:10 -0700 (PDT)
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: ghalem.boudour@6wind.com, evgenys@amazon.com, gtzalik@amazon.com,
 igorch@amazon.com, mk@semihalf.com, mw@semihalf.com, stable@dpdk.org
Date: Fri, 30 Jul 2021 10:34:41 +0200
Message-Id: <20210730083441.7465-1-olivier.matz@6wind.com>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20210712170153.11508-1-ghalem.boudour@6wind.com>
References: <20210712170153.11508-1-ghalem.boudour@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload
 flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

From: Ghalem Boudour <ghalem.boudour@6wind.com>

The DPDK ENA driver does not provide multi-segment tx offload capability.
Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by
default, and always set it in dev->data->dev_conf.txmode.offload.

This flag in not listed in doc/guides/nics/features/default.ini, so
ena.ini does not need to be updated.

Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: stable@dpdk.org

Signed-off-by: Ghalem Boudour <ghalem.boudour@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---

v2
* set DEV_TX_OFFLOAD_MULTI_SEGS in dev->data->dev_conf.txmode.offload
* add Fixes and Cc stable

 drivers/net/ena/ena_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index dfe68279fa..b59451034c 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1981,6 +1981,7 @@ static int ena_dev_configure(struct rte_eth_dev *dev)
 
 	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
 		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
+	dev->data->dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;
 	adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;
@@ -2055,6 +2056,7 @@ static int ena_infos_get(struct rte_eth_dev *dev,
 			DEV_RX_OFFLOAD_TCP_CKSUM;
 
 	rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
+	tx_feat |= DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	/* Inform framework about available features */
 	dev_info->rx_offload_capa = rx_feat;
-- 
2.29.2