From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A85EEA0A0C; Tue, 3 Aug 2021 00:45:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 309FA40E32; Tue, 3 Aug 2021 00:45:27 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 8FFD74069C for ; Tue, 3 Aug 2021 00:45:25 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 168163200684; Mon, 2 Aug 2021 18:45:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 02 Aug 2021 18:45:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=mlp7fws3wxfjB cJ/WNdq3FMsnyEdHANgjHsJBPZVA3A=; b=1y6f2jObaWgp6UC9q8asC1Ry32bdf nvhvCfYdN2oxZbtehx+Dyw8t1NYs+9ujnzpzimYxOJXdUEy3NN75XlXtXvBf5xlr 6MzkfGSBtUf2imnpXj2IVetEcdUji8eVStnfwvBIN2g4tAvPX0pHV/mIbsTUsdFA N1KJOvPzmBvp8mc2+vpPZtg7HmxsInpAxf2m+R6HnNU7Wz1zuJ9sM5E2QmpmiQvd 50ijhUy7xktbNuzCyki7q0GM0XWIzXbIR7M4oj4CuN+2O/zLWarJUPXXg7rp/ybX Lca6s0Xe8ZZGWoxCGWcjBdEqE930bxEZjq4rjcs3m4rE5ffqwT+ZYvPsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=mlp7fws3wxfjBcJ/WNdq3FMsnyEdHANgjHsJBPZVA3A=; b=JIwfnUfY xjya/YM8Dcb2WPzDzwZA0iqX7+QOq3HhZMa3dGZ/ChWqs7GSZdQtlZ0EM/9UfLgb JGir4QUtoY6q371FcPmvB53EzbNdxfpBPDvx7vUQwjJXqQtGngHdZfWI7uY4zkMc LKxt6/MdFkMuNUV14Wz0wPO8fuZLKRUK1tecWUkyPZPlYS5P/S07PJ1fylKPPZ6e lABA98LCwhqYdDoZn3asIlxG/vWvrhmv3a3fF8Ex1GGAejwsZRgWZHGC2+dojZq+ zixfng4QJmczHv08l36T4lA3Wig09uz20AQaERQYzHCOucq/HQwlQr3NBtsICTUm EsBbHVaa54z5OQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieefgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu tdehtdegveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Aug 2021 18:45:22 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Andrew Rybchenko , Bruce Richardson Date: Tue, 3 Aug 2021 00:45:17 +0200 Message-Id: <20210802224518.1179190-1-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412215339.2439530-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] devtools: test different build types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize build type. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- v2: fix init of var buildtype --- devtools/test-meson-builds.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9ec8e2bc7e..7bd305a669 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -92,13 +92,16 @@ load_env () # command -v $targetcc >/dev/null 2>&1 || return 1 } -config () # +config () # { dir=$1 shift builddir=$1 shift + abicheck=$1 + shift if [ -f "$builddir/build.ninja" ] ; then + [ $abicheck = ABI ] || return 0 # for existing environments, switch to debugoptimized if unset # so that ABI checks can run if ! $MESON configure $builddir | @@ -114,7 +117,9 @@ config () # else options="$options -Dexamples=l3fwd" # save disk space fi - options="$options --buildtype=debugoptimized" + if [ $abicheck = ABI ] ; then + options="$options --buildtype=debugoptimized" + fi for option in $DPDK_MESON_OPTIONS ; do options="$options -D$option" done @@ -165,7 +170,7 @@ build () # [meson options] cross= fi load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $cross --werror $* + config $srcdir $builds_dir/$targetdir $abicheck $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION @@ -179,7 +184,7 @@ build () # [meson options] fi rm -rf $abirefdir/build - config $abirefdir/src $abirefdir/build $cross \ + config $abirefdir/src $abirefdir/build $abicheck $cross \ -Dexamples= $* compile $abirefdir/build install_target $abirefdir/build $abirefdir/$targetdir @@ -211,11 +216,13 @@ for c in gcc clang ; do for s in static shared ; do if [ $s = shared ] ; then abicheck=ABI + buildtype= else abicheck=skipABI # save time and disk space + buildtype='--buildtype=minsize' fi export CC="$CCACHE $c" - build build-$c-$s $c $abicheck --default-library=$s + build build-$c-$s $c $abicheck $buildtype --default-library=$s unset CC done done @@ -227,7 +234,7 @@ generic_isa='nehalem' if ! check_cc_flags "-march=$generic_isa" ; then generic_isa='corei7' fi -build build-x86-generic cc skipABI -Dcheck_includes=true \ +build build-x86-generic cc skipABI --buildtype=debug -Dcheck_includes=true \ -Dlibdir=lib -Dcpu_instruction_set=$generic_isa $use_shared # 32-bit with default compiler -- 2.31.1