From: Gaoxiang Liu <gaoxiangliu0@163.com>
To: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Cc: liugaoxiang@huawei.com, Gaoxiang Liu <gaoxiangliu0@163.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/virtio: fix repeated memory free of vq
Date: Wed, 4 Aug 2021 07:45:15 +0800 [thread overview]
Message-ID: <20210803234516.859-1-gaoxiangliu0@163.com> (raw)
In-Reply-To: <20210803233040.492-1-gaoxiangliu0@163.com>
When virtio_init_queue returns error, the memory of vq is freed.
But the value of hw->vqs[queue_idx] does not restore.
If hw->vqs[queue_idx] != NULL, the memory of vq is freed again
in virtio_free_queues.
Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage")
Cc: stable@dpdk.org
Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
v2:
fix spelling warning
---
drivers/net/virtio/virtio_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 056830566..fc72d71cb 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -631,6 +631,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t queue_idx)
rte_memzone_free(mz);
free_vq:
rte_free(vq);
+ hw->vqs[queue_idx] = NULL;
return ret;
}
--
2.32.0
next prev parent reply other threads:[~2021-08-03 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 23:30 Gaoxiang Liu
2021-08-03 23:45 ` Gaoxiang Liu [this message]
2021-08-05 8:08 ` Gaoxiang Liu
2021-08-29 8:50 ` [dpdk-dev] [PATCH v3] " Gaoxiang Liu
2021-08-31 14:39 ` [dpdk-dev] [PATCH v4] " Gaoxiang Liu
2021-09-07 3:41 ` Gaoxiang Liu
2021-09-07 5:08 ` Xia, Chenbo
2021-09-14 11:27 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803234516.859-1-gaoxiangliu0@163.com \
--to=gaoxiangliu0@163.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=liugaoxiang@huawei.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).