From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CACB1A0C45; Wed, 4 Aug 2021 10:03:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AE3F41210; Wed, 4 Aug 2021 10:03:26 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2089.outbound.protection.outlook.com [40.107.236.89]) by mails.dpdk.org (Postfix) with ESMTP id 6CA4640696; Wed, 4 Aug 2021 10:03:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oIX0NtoNJwSo/Aq45psshmxYfIJoxWNxOcuEyBmMmCzwi79tH6JfxMX/oqONU5TY09hLBWkMVabrRv7UYltdZp/r3HEBNAtQOo9EXp0hTJ9mr66VG7nj6fdfxlc04TLv+EJizanpfkYcxUifwzRFRwJwZOaFpyCDyU2FB6Q+awSI/OInFLqWxZMcFOL0upUaJ4OBxdqOG+ZFxL4RCTCTTF/mmLovkCM13lr26Fh+6BmYiSijI6lyBUevDNh2wnJuJ/bAIqHO79LR6iO7zLbnaAp52t93fvaPg6/jE3QTY+x809iuRD6KaPp5djEDND5aFeVfUGHDSXTkaKlmrM85Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5g4R9lD7LysSTPyZg0d+YORGg1syxOpwdK0XOIAqtbY=; b=JS2fQWvjI6D3TNHqjBGVX3h8RFlmDaOu4T/GvTXCHnE5gkRZZpHV6e2Jfwchny3Q4nEkVXN+I3hpNkSRF8G74Se1SJrpfvA2lHn8mFYzUk9QC5ubmKOVX0LYHZpWzqgU7sKTnJAGOMjKC72Q0q0j7H77NbvjNztFX8wnAUoOvYogNPHugfuBlztfn0DTwjEeBUOIWpYbEicYXTsaj/Pa0edVJTChuNzs/B9NDCnAhLJ785NoFMiI6xOJqpvxGAsxvd0LwwQ/3NoZ8vkLQMXZ5i9/etqyRpljjYCCTnqMyG+/Z/SSNrTUNKhx7JJ7eO9Gxw9R0WdHYSDdjydWN1dNcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5g4R9lD7LysSTPyZg0d+YORGg1syxOpwdK0XOIAqtbY=; b=I/+oueVMrkWWGK8dvyCTCVhE9TXGBowp8qFyI039UalDTmK0TiSMBoeQso8JNTZ2PxvJmozyka5Wbzrfr1VJuNPTXU/HqwPR/l3sEAZx2/WkaTGPfOgvwNsy09Yi+MdCZL2DBBZqItGNrDJp+GtMsW6Yx4pFkf+8ueLlQfejjdwZ5CsxaFGr63R3VVDBK3UkqtibslVVrl4VaCVVqUpDeUOSAXJZkXKMo5N+84jJ93qErycp/g2w9tdUDKQveEHP1BCvogX0KK5NkK3+ZSoTJrcHG/KsiJALKtYVTWbYt2O2nMPkeQN8Dsfx+O+jOlIxb2NuJldYgAc2j5rl2X5JbQ== Received: from MWHPR18CA0050.namprd18.prod.outlook.com (2603:10b6:300:39::12) by DM6PR12MB4172.namprd12.prod.outlook.com (2603:10b6:5:212::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Wed, 4 Aug 2021 08:03:21 +0000 Received: from CO1NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:300:39:cafe::c0) by MWHPR18CA0050.outlook.office365.com (2603:10b6:300:39::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Wed, 4 Aug 2021 08:03:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by CO1NAM11FT027.mail.protection.outlook.com (10.13.174.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4373.18 via Frontend Transport; Wed, 4 Aug 2021 08:03:21 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug 2021 08:03:20 +0000 Received: from nvidia.com (172.20.187.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug 2021 08:03:17 +0000 From: Dmitry Kozlyuk To: CC: , Viacheslav Ovsiienko , "Xueming Li" , Andrew Rybchenko , Marcin Wojtas , Michal Krawczyk , "Shai Brandes" , Evgeny Schemeilin , "Igor Chauskin" , Parav Pandit , "Stephen Hemminger" , Long Li Date: Wed, 4 Aug 2021 11:03:01 +0300 Message-ID: <20210804080301.1440491-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210728220618.1048721-1-dkozlyuk@nvidia.com> References: <20210728220618.1048721-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee2b8cc7-05e5-45b4-ec4c-08d9571e5389 X-MS-TrafficTypeDiagnostic: DM6PR12MB4172: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vu5ho5CoYKVMQ76GJ6zeaZuqL5GIIsY+GSEqwWqCIcy4BYlVlrA8APk1qgZchjwjhIPxSqMkxNPdNRhWPgF/5rGrwnCL4JBrLBHh8F6m3AOx3k69yaNsX3qHKlKdCRaXVv0nOET7bNQnsrwHHznKJ6O/YmcHKODlC93ZeDQw7+RKjytJxZ7HqFluSbaKilXbvUQArHZ+hpdlvj1jVo0oL2RVWJ4zEOcWIOBRT1gHh0wxZULh93/9agZcXemXFccjaLwmruIR04M8H3Y+SUsgcUm1h3ohpNhIZ4S9rRNWUKRavg1TZjcH4OhQzh5M8sXGQxoCG+/5wLOkJtKzFiE0w/V/b0p/W4UQz9nXWFKEK8tU4J2u9M4XUOOzD/WXk4FgDDzM6ih1/h6p3brIS2hWaC/g2xAfvBHPud6IJdhg9zkZn7XmVNdmNpcR3wBrnvc68Hib0NZSza2jFrk5CvA1RmxQw4rKiVm31TVOQOSf3VVrZJe43usl5HMWIZYkt7yuwM1+7LBgqUeGh/UeqakEd0x+7q2dNAt814LP0bih2smBDxdAnWSTSMcyL5DyZlP+AREnDAG0xUZq5rCrQSXrLobFQF7cIQQOYLY+IECLRZU7SkyAO7Be4ZIgXlLOSUjHeN88GeAWrglHQqXPViv7TZZbve+CGfIN1TbmVP3Ph8EV+Y0K9PBKQoQ3wSiy1UUp22qpHxhpgPlQ8zNNN1S1Dw== X-Forefront-Antispam-Report: CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(39860400002)(346002)(46966006)(36840700001)(86362001)(356005)(7636003)(82740400003)(82310400003)(336012)(16526019)(7416002)(83380400001)(70586007)(1076003)(70206006)(426003)(5660300002)(36756003)(186003)(4326008)(8676002)(2616005)(478600001)(316002)(55016002)(2906002)(6286002)(36906005)(8936002)(6666004)(7696005)(6916009)(54906003)(26005)(47076005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 08:03:21.0739 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee2b8cc7-05e5-45b4-ec4c-08d9571e5389 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4172 Subject: [dpdk-dev] [PATCH v5] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI, vmbus, and auxiliary drivers printed a warning when NUMA node had been reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users because the configuration is valid and nothing happens that requires attention or intervention. It was also printed without the device identification and with an indent (PCI only), which is confusing unless DEBUG logging is on to print the header message with the device name. Reduce level to INFO, reword the message, and suppress it when there is only one NUMA node because NUMA awareness does not matter in this case. Also, remove the indent for PCI. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko Reviewed-by: Xueming Li Acked-by: Andrew Rybchenko --- The messages say "socket" and not "node", because this is current terminology in DPDK. v5: Add device name, remove indent, fix typos (Thomas Monjalon) v4: Fix build errors and a typo (CI). v3: Keep resetting device NUMA node to 0 (Andrew Rybchenko). v2: Add NUMA node count check (Stephen Hemminger). doc/guides/nics/ena.rst | 2 +- drivers/bus/auxiliary/auxiliary_common.c | 5 ++++- drivers/bus/pci/pci_common.c | 5 ++++- drivers/bus/vmbus/vmbus_common.c | 5 ++++- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 63951098ea..92b1858e7a 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -246,7 +246,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device 0000:00:06.0 is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index 89e653c54e..603b6fdc02 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -106,7 +107,9 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv, } if (dev->device.numa_node < 0) { - AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0"); + if (rte_socket_count() > 1) + AUXILIARY_LOG(INFO, "Device %s is not NUMA-aware, defaulting socket to 0", + dev->name); dev->device.numa_node = 0; } diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..79a6fcffbd 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -190,7 +191,9 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + if (rte_socket_count() > 1) + RTE_LOG(INFO, EAL, "Device %s is not NUMA-aware, defaulting socket to 0\n", + dev->name); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..519ca9c6fe 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -112,7 +113,9 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + if (rte_socket_count() > 1) + VMBUS_LOG(INFO, "Device %s is not NUMA-aware, defaulting socket to 0", + guid); dev->device.numa_node = 0; } -- 2.25.1