* [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version
@ 2021-08-05 17:48 William Tu
2021-08-11 21:55 ` Dmitry Kozlyuk
0 siblings, 1 reply; 3+ messages in thread
From: William Tu @ 2021-08-05 17:48 UTC (permalink / raw)
To: dev; +Cc: dmitry.kozliuk, sergey.madaminov
When OVS inits, it calls rte_version to get the DPDK's version.
The patch fixes the error below by exposing rte_version symbol.
libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
rte_version referenced in function dpdk_init
Signed-off-by: William Tu <u9012063@gmail.com>
---
lib/eal/version.map | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 887012d02a..3de59910cd 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -198,7 +198,7 @@ DPDK_21 {
rte_uuid_is_null; # WINDOWS_NO_EXPORT
rte_uuid_parse; # WINDOWS_NO_EXPORT
rte_uuid_unparse; # WINDOWS_NO_EXPORT
- rte_version; # WINDOWS_NO_EXPORT
+ rte_version;
rte_vfio_clear_group; # WINDOWS_NO_EXPORT
rte_vfio_container_create; # WINDOWS_NO_EXPORT
rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
--
2.32.0.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version
2021-08-05 17:48 [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version William Tu
@ 2021-08-11 21:55 ` Dmitry Kozlyuk
2021-09-30 20:26 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Kozlyuk @ 2021-08-11 21:55 UTC (permalink / raw)
To: William Tu; +Cc: dev, sergey.madaminov, bruce.richardson
2021-08-05 17:48 (UTC+0000), William Tu:
> When OVS inits, it calls rte_version to get the DPDK's version.
> The patch fixes the error below by exposing rte_version symbol.
> libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
> rte_version referenced in function dpdk_init
Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
> Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> lib/eal/version.map | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index 887012d02a..3de59910cd 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -198,7 +198,7 @@ DPDK_21 {
> rte_uuid_is_null; # WINDOWS_NO_EXPORT
> rte_uuid_parse; # WINDOWS_NO_EXPORT
> rte_uuid_unparse; # WINDOWS_NO_EXPORT
> - rte_version; # WINDOWS_NO_EXPORT
> + rte_version;
> rte_vfio_clear_group; # WINDOWS_NO_EXPORT
> rte_vfio_container_create; # WINDOWS_NO_EXPORT
> rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
I can see many functions not exported on Windows for no reason.
This includes the rest of the version API, but it's experimental,
so it's better to have this standalone patch for backporting
(since the patch it fixes is backported).
I'm going to restore other exports in a bulk patchset.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version
2021-08-11 21:55 ` Dmitry Kozlyuk
@ 2021-09-30 20:26 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-09-30 20:26 UTC (permalink / raw)
To: William Tu; +Cc: dev, sergey.madaminov, bruce.richardson, Dmitry Kozlyuk
11/08/2021 23:55, Dmitry Kozlyuk:
> 2021-08-05 17:48 (UTC+0000), William Tu:
> > When OVS inits, it calls rte_version to get the DPDK's version.
> > The patch fixes the error below by exposing rte_version symbol.
> > libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
> > rte_version referenced in function dpdk_init
>
> Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> > Signed-off-by: William Tu <u9012063@gmail.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks.
Note: do not hesitate to ping when a patch is forgotten so long.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-30 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 17:48 [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version William Tu
2021-08-11 21:55 ` Dmitry Kozlyuk
2021-09-30 20:26 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).