From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: William Tu <u9012063@gmail.com>
Cc: dev@dpdk.org, sergey.madaminov@gmail.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version
Date: Thu, 12 Aug 2021 00:55:17 +0300 [thread overview]
Message-ID: <20210812005517.627cf966@sovereign> (raw)
In-Reply-To: <20210805174819.1147-1-u9012063@gmail.com>
2021-08-05 17:48 (UTC+0000), William Tu:
> When OVS inits, it calls rte_version to get the DPDK's version.
> The patch fixes the error below by exposing rte_version symbol.
> libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
> rte_version referenced in function dpdk_init
Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
> Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> lib/eal/version.map | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index 887012d02a..3de59910cd 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -198,7 +198,7 @@ DPDK_21 {
> rte_uuid_is_null; # WINDOWS_NO_EXPORT
> rte_uuid_parse; # WINDOWS_NO_EXPORT
> rte_uuid_unparse; # WINDOWS_NO_EXPORT
> - rte_version; # WINDOWS_NO_EXPORT
> + rte_version;
> rte_vfio_clear_group; # WINDOWS_NO_EXPORT
> rte_vfio_container_create; # WINDOWS_NO_EXPORT
> rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
I can see many functions not exported on Windows for no reason.
This includes the rest of the version API, but it's experimental,
so it's better to have this standalone patch for backporting
(since the patch it fixes is backported).
I'm going to restore other exports in a bulk patchset.
next prev parent reply other threads:[~2021-08-11 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 17:48 William Tu
2021-08-11 21:55 ` Dmitry Kozlyuk [this message]
2021-09-30 20:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812005517.627cf966@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sergey.madaminov@gmail.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).