From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24DDAA0C43; Wed, 11 Aug 2021 23:55:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94A594014D; Wed, 11 Aug 2021 23:55:21 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 1CEE140042 for ; Wed, 11 Aug 2021 23:55:20 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id x27so8958407lfu.5 for ; Wed, 11 Aug 2021 14:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wUGYCjG1wOVJFzMjEiA07w4uaukD9JOTFL/+H3jobns=; b=jDqju38Nl4Yc8HH6w72stWH7ciP9G5djoKvcnYiSPHjPxy96zQxznDDy1AFp0xvHnm Yxdqsvkt+T9kGi3NHEtYQspva8bn/Yk94VNUO2EplWNR+9Ip51RjJBfB6q88P+wfsJ1r xdrqyx/kPhODKBpav/vZFli60zlAVkg5vvSorihutUPx5RNd6r59+VfDlXCI3PtAcTOw fs9sa+nIgyNYo8MYA4HolQvA9lBZyBVQRDd1CjpmAXFOek2995h1vjTqmndCWf83itWQ PWjXewBh6U0w9I5+v8AHbbmxxBJ1zjJYTLqeIy03qBvDT1JrGWjUqJXEN0kqsmmKVKWV B2rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wUGYCjG1wOVJFzMjEiA07w4uaukD9JOTFL/+H3jobns=; b=iVaXIQlufA74uJVDU7TewWj83scOWKGgtucsQQu2E0tTxyj3jqaMl6UOSzVPf5wBc2 33qcfJ0Te2ywBPWd03YN9J5NzVc4BB6gU3cSW935LdQXuBXBpOP5UdzijD4iArtjooNX 76UKevaTwU1gE4gZeD74/eLTrmDKmV0CeCrDBDu4xSWlLjKTBkOA05iu3AeJVdotqvCS LEjk0z+8KQ4syUqlChj3EzR8tzmdTKgsSks3PwYppB58k2c1SCkdFT1YHaECCuSMFU5d FE5k6Yovbdg4IA7HBA+ODO13iP0NuYXws3B6krXlJzTDDSkxpGqoSCftfGGRAIpb3OPm pIHg== X-Gm-Message-State: AOAM530mvcLqjcLs7P3SJPUpoXPJpo6KnuRUFVlyyLkqdVIlvqKlFAvD /nwhehdxwYbEmtSrkeASjvk= X-Google-Smtp-Source: ABdhPJx1YYJ+zSt6/WJgRmrQ0qJFhy38kYQPdthTEb+0KGvE1xbDQVFeD2l2gWTTvke/iuskdD+u/Q== X-Received: by 2002:ac2:430d:: with SMTP id l13mr178468lfh.303.1628718919584; Wed, 11 Aug 2021 14:55:19 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id u15sm58086lfk.12.2021.08.11.14.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 14:55:18 -0700 (PDT) Date: Thu, 12 Aug 2021 00:55:17 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dev@dpdk.org, sergey.madaminov@gmail.com, bruce.richardson@intel.com Message-ID: <20210812005517.627cf966@sovereign> In-Reply-To: <20210805174819.1147-1-u9012063@gmail.com> References: <20210805174819.1147-1-u9012063@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-08-05 17:48 (UTC+0000), William Tu: > When OVS inits, it calls rte_version to get the DPDK's version. > The patch fixes the error below by exposing rte_version symbol. > libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol > rte_version referenced in function dpdk_init Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") Cc: bruce.richardson@intel.com Cc: stable@dpdk.org > Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk > --- > lib/eal/version.map | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eal/version.map b/lib/eal/version.map > index 887012d02a..3de59910cd 100644 > --- a/lib/eal/version.map > +++ b/lib/eal/version.map > @@ -198,7 +198,7 @@ DPDK_21 { > rte_uuid_is_null; # WINDOWS_NO_EXPORT > rte_uuid_parse; # WINDOWS_NO_EXPORT > rte_uuid_unparse; # WINDOWS_NO_EXPORT > - rte_version; # WINDOWS_NO_EXPORT > + rte_version; > rte_vfio_clear_group; # WINDOWS_NO_EXPORT > rte_vfio_container_create; # WINDOWS_NO_EXPORT > rte_vfio_container_destroy; # WINDOWS_NO_EXPORT I can see many functions not exported on Windows for no reason. This includes the rest of the version API, but it's experimental, so it's better to have this standalone patch for backporting (since the patch it fixes is backported). I'm going to restore other exports in a bulk patchset.