DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: <jerinj@marvell.com>, <dev@dpdk.org>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>, <jia.guo@intel.com>,
	<stable@dpdk.org>
Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum
Date: Mon, 16 Aug 2021 12:39:41 +0530	[thread overview]
Message-ID: <20210816070943.26807-1-ndabilpuram@marvell.com> (raw)

Donot use outer metadata when neither outer ip checksum nor
outer udp checksum is enabled. PMD's will ignore the
outer_l2_len and outer_l3_len in cases where none of
the outer checksum is enabled and hence only l2_len and
l3_len will be used to calculate the offsets for L2 or L3
header.

Fixes: 3c32113a1aac ("app/testpmd: fix IPv6 tunnel checksum")
Cc: jia.guo@intel.com
Cc: stable@dpdk.org

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
 app/test-pmd/csumonly.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 607c889..38cc256 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -961,8 +961,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
 			    (tx_offloads &
 			     DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) ||
 			    (tx_offloads &
-			     DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) ||
-			    (tx_ol_flags & PKT_TX_OUTER_IPV6)) {
+			     DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) {
 				m->outer_l2_len = info.outer_l2_len;
 				m->outer_l3_len = info.outer_l3_len;
 				m->l2_len = info.l2_len;
-- 
2.8.4


             reply	other threads:[~2021-08-16  7:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  7:09 Nithin Dabilpuram [this message]
2021-08-16  7:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx Nithin Dabilpuram
2021-08-17  1:54   ` Li, Xiaoyun
2021-08-17  7:54     ` Raslan Darawsheh
2021-08-16  8:48 ` [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum Li, Xiaoyun
2021-08-16 10:55   ` Nithin Dabilpuram
2021-08-17  1:43     ` Li, Xiaoyun
2021-08-17 10:58       ` Nithin Dabilpuram
2021-08-17  1:44 ` Li, Xiaoyun
2021-08-25 12:57   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816070943.26807-1-ndabilpuram@marvell.com \
    --to=ndabilpuram@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=jia.guo@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).