From: <jerinj@marvell.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>,
<bruce.richardson@intel.com>, <dmitry.kozliuk@gmail.com>,
<navasile@linux.microsoft.com>, <dmitrym@microsoft.com>,
<pallavi.kadam@intel.com>, <konstantin.ananyev@intel.com>,
<ruifeng.wang@arm.com>, <viktorin@rehivetech.com>,
<drc@linux.vnet.ibm.com>, Jerin Jacob <jerinj@marvell.com>
Subject: [dpdk-dev] [PATCH v2 2/6] eal: oops handling API implementation
Date: Tue, 17 Aug 2021 08:57:19 +0530 [thread overview]
Message-ID: <20210817032723.3997054-3-jerinj@marvell.com> (raw)
In-Reply-To: <20210817032723.3997054-1-jerinj@marvell.com>
From: Jerin Jacob <jerinj@marvell.com>
Implement the base oops handling APIs.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
lib/eal/unix/eal_oops.c | 176 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 169 insertions(+), 7 deletions(-)
diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c
index 53b580f733..7b12cfd5f5 100644
--- a/lib/eal/unix/eal_oops.c
+++ b/lib/eal/unix/eal_oops.c
@@ -2,35 +2,197 @@
* Copyright(C) 2021 Marvell.
*/
+#include <inttypes.h>
+#include <signal.h>
+#include <ucontext.h>
+#include <unistd.h>
+#include <rte_byteorder.h>
+#include <rte_debug.h>
+#include <rte_log.h>
#include <rte_oops.h>
#include "eal_private.h"
-void
-rte_oops_decode(int sig, siginfo_t *info, ucontext_t *uc)
+#define oops_print(...) rte_log(RTE_LOG_ERR, RTE_LOGTYPE_EAL, __VA_ARGS__)
+
+static int oops_signals[] = {SIGSEGV, SIGBUS, SIGILL, SIGABRT, SIGFPE, SIGSYS};
+
+struct oops_signal {
+ int sig;
+ bool enabled;
+ struct sigaction sa;
+};
+
+static struct oops_signal signals_db[RTE_DIM(oops_signals)];
+
+static void
+back_trace_dump(ucontext_t *context)
+{
+ RTE_SET_USED(context);
+
+ rte_dump_stack();
+}
+static void
+siginfo_dump(int sig, siginfo_t *info)
+{
+ oops_print("PID: %" PRIdMAX "\n", (intmax_t)getpid());
+
+ if (info == NULL)
+ return;
+ if (sig != info->si_signo)
+ oops_print("Invalid signal info\n");
+
+ oops_print("Signal number: %d\n", info->si_signo);
+ oops_print("Fault address: %p\n", info->si_addr);
+}
+
+static void
+mem32_dump(void *ptr)
+{
+ uint32_t *p = ptr;
+ int i;
+
+ for (i = 0; i < 16; i++)
+ oops_print("%p: 0x%x\n", p + i, rte_be_to_cpu_32(p[i]));
+}
+
+static void
+stack_dump_header(void)
+{
+ oops_print("Stack dump:\n");
+ oops_print("----------\n");
+}
+
+static void
+code_dump_header(void)
+{
+ oops_print("Code dump:\n");
+ oops_print("----------\n");
+}
+
+static void
+stack_code_dump(void *stack, void *code)
+{
+ if (stack == NULL || code == NULL)
+ return;
+
+ oops_print("\n");
+ stack_dump_header();
+ mem32_dump(stack);
+ oops_print("\n");
+
+ code_dump_header();
+ mem32_dump(code);
+ oops_print("\n");
+}
+static void
+archinfo_dump(ucontext_t *uc)
{
- RTE_SET_USED(sig);
- RTE_SET_USED(info);
RTE_SET_USED(uc);
+ stack_code_dump(NULL, NULL);
+}
+
+static void
+default_signal_handler_invoke(int sig)
+{
+ unsigned int idx;
+
+ for (idx = 0; idx < RTE_DIM(oops_signals); idx++) {
+ /* Skip disabled signals */
+ if (signals_db[idx].sig != sig)
+ continue;
+ if (!signals_db[idx].enabled)
+ continue;
+ /* Replace with stored handler */
+ sigaction(sig, &signals_db[idx].sa, NULL);
+ kill(getpid(), sig);
+ }
+}
+
+void
+rte_oops_decode(int sig, siginfo_t *info, ucontext_t *uc)
+{
+ oops_print("Signal info:\n");
+ oops_print("------------\n");
+ siginfo_dump(sig, info);
+ oops_print("\n");
+
+ oops_print("Backtrace:\n");
+ oops_print("----------\n");
+ back_trace_dump(uc);
+ oops_print("\n");
+
+ oops_print("Arch info:\n");
+ oops_print("----------\n");
+ if (uc)
+ archinfo_dump(uc);
+}
+
+static void
+eal_oops_handler(int sig, siginfo_t *info, void *ctx)
+{
+ ucontext_t *uc = ctx;
+
+ rte_oops_decode(sig, info, uc);
+ default_signal_handler_invoke(sig);
}
int
rte_oops_signals_enabled(int *signals)
{
- RTE_SET_USED(signals);
+ int count = 0, sig[RTE_OOPS_SIGNALS_MAX];
+ unsigned int idx = 0;
- return 0;
+ for (idx = 0; idx < RTE_DIM(oops_signals); idx++) {
+ if (signals_db[idx].enabled) {
+ sig[count] = signals_db[idx].sig;
+ count++;
+ }
+ }
+ if (signals)
+ memcpy(signals, sig, sizeof(*signals) * count);
+
+ return count;
}
int
eal_oops_init(void)
{
- return 0;
+ unsigned int idx, rc = 0;
+ struct sigaction sa;
+
+ RTE_BUILD_BUG_ON(RTE_DIM(oops_signals) > RTE_OOPS_SIGNALS_MAX);
+
+ sigemptyset(&sa.sa_mask);
+ sa.sa_sigaction = &eal_oops_handler;
+ sa.sa_flags = SA_RESTART | SA_SIGINFO | SA_ONSTACK;
+
+ for (idx = 0; idx < RTE_DIM(oops_signals); idx++) {
+ signals_db[idx].sig = oops_signals[idx];
+ /* Get exiting sigaction */
+ rc = sigaction(signals_db[idx].sig, NULL, &signals_db[idx].sa);
+ if (rc)
+ continue;
+ /* Replace with oops handler */
+ rc = sigaction(signals_db[idx].sig, &sa, NULL);
+ if (rc)
+ continue;
+ signals_db[idx].enabled = true;
+ }
+ return rc;
}
void
eal_oops_fini(void)
{
+ unsigned int idx;
+
+ for (idx = 0; idx < RTE_DIM(oops_signals); idx++) {
+ if (!signals_db[idx].enabled)
+ continue;
+ /* Replace with stored handler */
+ sigaction(signals_db[idx].sig, &signals_db[idx].sa, NULL);
+ }
}
--
2.32.0
next prev parent reply other threads:[~2021-08-17 3:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 8:49 [dpdk-dev] 0/6] support oops handling jerinj
2021-07-30 8:49 ` [dpdk-dev] 1/6] eal: introduce oops handling API jerinj
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 0/6] support oops handling jerinj
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API jerinj
2021-08-17 3:53 ` Stephen Hemminger
2021-08-17 7:38 ` Jerin Jacob
2021-08-17 15:09 ` Stephen Hemminger
2021-08-17 15:27 ` Jerin Jacob
2021-08-17 15:52 ` Stephen Hemminger
2021-08-18 9:37 ` Jerin Jacob
2021-08-18 16:46 ` Stephen Hemminger
2021-08-18 18:04 ` Jerin Jacob
2021-08-17 3:27 ` jerinj [this message]
2021-08-17 3:52 ` [dpdk-dev] [PATCH v2 2/6] eal: oops handling API implementation Stephen Hemminger
2021-08-17 10:24 ` Jerin Jacob
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 3/6] eal: support libunwind based backtrace jerinj
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 4/6] eal/x86: support register dump for oops jerinj
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 5/6] eal/arm64: " jerinj
2021-08-17 3:27 ` [dpdk-dev] [PATCH v2 6/6] test/oops: support unit test case for oops handling APIs jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 0/6] support oops handling jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 1/6] eal: introduce oops handling API jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 2/6] eal: oops handling API implementation jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace jerinj
2022-01-27 20:47 ` Stephen Hemminger
2022-01-28 4:33 ` Jerin Jacob
2022-01-28 8:41 ` Thomas Monjalon
2022-01-28 14:27 ` Jerin Jacob
2022-01-28 17:05 ` Stephen Hemminger
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 4/6] eal/x86: support register dump for oops jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 5/6] eal/arm64: " jerinj
2021-09-06 4:17 ` [dpdk-dev] [PATCH v3 6/6] test/oops: support unit test case for oops handling APIs jerinj
2021-09-21 17:30 ` [dpdk-dev] [PATCH v3 0/6] support oops handling Thomas Monjalon
2021-09-21 17:54 ` Jerin Jacob
2021-09-22 7:34 ` Thomas Monjalon
2021-09-22 8:03 ` Jerin Jacob
2021-09-22 8:33 ` Thomas Monjalon
2021-09-22 8:49 ` Jerin Jacob
2021-07-30 8:49 ` [dpdk-dev] 2/6] eal: oops handling API implementation jerinj
2021-08-02 22:46 ` David Christensen
2021-07-30 8:49 ` [dpdk-dev] 3/6] eal: support libunwind based backtrace jerinj
2021-07-30 8:49 ` [dpdk-dev] 4/6] eal/x86: support register dump for oops jerinj
2021-07-30 8:49 ` [dpdk-dev] 5/6] eal/arm64: " jerinj
2021-08-02 22:49 ` David Christensen
2021-08-16 16:24 ` Jerin Jacob
2021-07-30 8:49 ` [dpdk-dev] 6/6] test/oops: support unit test case for oops handling APIs jerinj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817032723.3997054-3-jerinj@marvell.com \
--to=jerinj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=drc@linux.vnet.ibm.com \
--cc=konstantin.ananyev@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).