From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95F64A0548; Tue, 17 Aug 2021 15:47:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD0A641278; Tue, 17 Aug 2021 15:45:46 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2078.outbound.protection.outlook.com [40.107.100.78]) by mails.dpdk.org (Postfix) with ESMTP id B0C674126B for ; Tue, 17 Aug 2021 15:45:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGxlvERB/kWdJq+YuuE2/HPX1lT2FUndsGr7AJFfoeZKjF1IcBHy5eMsU5OnGNJNQC/yVFNR0KbC3CcQ2jRhiKLlOlPZfg8Jfq7exwgOqnYBv4zrRt5X/oD7UHQz+YtBbDqO7ItrRfCJnpRcBrY8YByC4AZE9uBmjsgKVoFSUzXweonFgMKJ5RFbe6HopPKT95Xh/bH3wXnzDIJLP/PinzbDN+sjpII0XZKEPK0tgNIQMVWNXRqJbrUjKzeGjVt6phUUjoknyI5CLj3nwTGpnHS9FngIMiGqVh9nLHbhL/p1qYbSVcrWzy2w9yqxCcihssNrW2ZSu58BMb71UdfhmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2oH15DylRNXwsEYZaWcDHwPiHA39924brnOzY0e5SuA=; b=lltj3EJFk+4txwxyLmMNtfZkYizt8P6+IR0S1xE9tysdyzTt7sogynFyix2ehxHsFq4v4+2p59v2ioFkp47EdxEeRbdgYDOiNhmDx/uZ2T59bVR1a/1s9MerNANBudEs5Fk1lQ5Zf/RniwULh75VT0CQ+S9HaxEnMXf5R68QZ1t1L5DgIc2D6SETYw0cTF70fQyK5iegO5e3b79hzUwWQlN1XB7c8Id9aV0aNimU1PMjZs81ubZNpRzAA40Cd1QwvlYOR4X2nQOG9hYimKbWuvOs6UglCC6ElHOgrkKhG0jOCZt510eRIr0oyY1gT99/GqevWJ1dyzzqDwvEi15EaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2oH15DylRNXwsEYZaWcDHwPiHA39924brnOzY0e5SuA=; b=lucSasbWuSv376rDNZijB274adOHjzZTuuFGyvFa/hIDK1jHoCdBCHy0xNIjor3+6NJR7q8ooHNVfk8FgC9S/juiJH6DW4Rj9EEWY2Oqtt2ObJkEGLYhIrxQKVdgdvggubOeExZXXO9+tt9n0C9bVUxd+i+oV4m0ceY1MPYlIu4OExul+QxM+zm6nRdzlC7i8BR6uTFoR2R4KRU1HX5X38asNEMEoy3tjFGPGsSK89VO059slpnCZ6qBOjDBSoyv438/DLIdvUV9N3Re/WoPFAEzpNgfSiZRmRt6MgpwhzUKDeHmUHw0SR0CNSrl86yga8BR0UPqMpD1PQ58ObLOyA== Received: from CO2PR04CA0096.namprd04.prod.outlook.com (2603:10b6:104:6::22) by DM6PR12MB3626.namprd12.prod.outlook.com (2603:10b6:5:11f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Tue, 17 Aug 2021 13:45:41 +0000 Received: from CO1NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:104:6:cafe::1c) by CO2PR04CA0096.outlook.office365.com (2603:10b6:104:6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 13:45:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by CO1NAM11FT010.mail.protection.outlook.com (10.13.175.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:41 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 06:45:40 -0700 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:39 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Tue, 17 Aug 2021 16:44:36 +0300 Message-ID: <20210817134441.1966618-17-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817134441.1966618-1-michaelba@nvidia.com> References: <20210817134441.1966618-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80f3235c-80e6-44d7-fb04-08d961854dbe X-MS-TrafficTypeDiagnostic: DM6PR12MB3626: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xsAWWzIPd+N8pZavZZAl3vp7V96LoaJZtWJsOqkXOOvVenxnXkZg9Kq3AGZgkVsmGPM/XAJffhpmK28sIgTtvMm1+Oy0AQz4F8Fyl6vx80bkEboFmndS1Z3PoO13yhq3lDHCA0w+Sl2ipQ9pFEB1B2YcQ9kOELhxA1N3uY547KS/Ht7SQcuuZlicMgGr7QrXf7YlXT0ufJcEsep5URdMjKHQDgsTMNHR7CprjFd/5kU0uE5vU1fCskLg34aQog0suCopLm8ElM8zxKnCqB8x6Iotoa8qDSdFxEFqomdBCn4wE1EZTvMOKpYAaiMlqlOInOa5ZLtXKn2+dUxXPkNpvR1gjp/rdThpe/vdec7aNMwbu9WwhFeL42KpzVrM+qKaEME2vqqSsJTTNcujRHenNSDgiyfR4nEKXI8iKV1FK0cCwQ2ZHIm3QTqJ/R9y8KGmDghtGGDiQIJYONcJcQFQVk1bZPhlfR3NXCr/yJTpt0p9ydYLjbqk0FtSsOT/rzsnQBBAEpVP28thQZp3OF3AZzrGa8mhJ7+xKC7vzVcG8WY2rClhtIPWdw6uqSDcc1sszPBQhBzMnz3558ega0j7Q8a62RSgNMpBiTdDtvLRSAn1vZ2umBHLjKC/mMPAA2OSJ0yF8Cu2FlcenSOYn/B/tnDnBUbArhGgBzw+WE1UEQZrJwjLsQLctdyTC5dGFi9O0nuGRyPpS2ffW6Dr10nJBA== X-Forefront-Antispam-Report: CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(36840700001)(46966006)(54906003)(26005)(2906002)(6916009)(5660300002)(478600001)(8676002)(6286002)(316002)(426003)(336012)(7636003)(356005)(7696005)(47076005)(70586007)(70206006)(4326008)(36860700001)(82740400003)(6666004)(107886003)(36756003)(83380400001)(16526019)(186003)(86362001)(55016002)(1076003)(8936002)(2616005)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:45:41.1892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80f3235c-80e6-44d7-fb04-08d961854dbe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3626 Subject: [dpdk-dev] [RFC 16/21] common/mlx5: add HCA attributes to context device structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add HCA attributes structure as a field of context device structure. It query in common probing, and check if the device supports the chosen classes. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c | 67 ++++++++++++++++++++++++++++++- drivers/common/mlx5/mlx5_common.h | 9 +++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c index b500e7834e..e4c1984700 100644 --- a/drivers/common/mlx5/mlx5_common.c +++ b/drivers/common/mlx5/mlx5_common.c @@ -310,6 +310,56 @@ mlx5_dev_to_pci_str(const struct rte_device *dev, char *addr, size_t size) #endif } +/** + * Validate HCA attributes. + * + * @param attr + * Attributes device values. + * @param classes + * Chosen classes come from device arguments. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +static int +mlx5_hca_attr_validate(struct mlx5_hca_attr *attr, uint32_t classes) +{ + if (classes & MLX5_CLASS_VDPA) { + if (!attr->vdpa.valid || !attr->vdpa.max_num_virtio_queues) { + DRV_LOG(ERR, + "Not enough capabilities to support vDPA, maybe old FW/OFED version?"); + rte_errno = ENOTSUP; + return -rte_errno; + } + } + if (classes & MLX5_CLASS_REGEX) { + if (!attr->regex || attr->regexp_num_of_engines == 0) { + DRV_LOG(ERR, + "Not enough capabilities to support RegEx, maybe old FW/OFED version?"); + rte_errno = ENOTSUP; + return -rte_errno; + } + } + if (classes & MLX5_CLASS_COMPRESS) { + if (attr->mmo_compress_en == 0 || + attr->mmo_decompress_en == 0 || attr->mmo_dma_en == 0) { + DRV_LOG(ERR, + "Not enough capabilities to support compress operations, maybe old FW/OFED version?"); + rte_errno = ENOTSUP; + return -ENOTSUP; + } + } + if (classes & MLX5_CLASS_CRYPTO) { + if (attr->crypto == 0 || attr->aes_xts == 0) { + DRV_LOG(ERR, + "Not enough capabilities to support crypto operations, maybe old FW/OFED version?"); + rte_errno = ENOTSUP; + return -ENOTSUP; + } + } + return 0; +} + /** * Uninitialize context device and release all its resources. * @@ -379,6 +429,13 @@ mlx5_dev_ctx_prepare(struct mlx5_dev_ctx *dev_ctx, struct rte_device *dev, ret = mlx5_os_pd_create(dev_ctx); if (ret) goto error; + /* Query HCA attributes. */ + ret = mlx5_devx_cmd_query_hca_attr(dev_ctx->ctx, &dev_ctx->hca_attr); + if (ret) { + DRV_LOG(ERR, "Unable to read HCA capabilities."); + rte_errno = ENOTSUP; + goto error; + } return ret; error: mlx5_dev_ctx_release(dev_ctx); @@ -507,13 +564,19 @@ mlx5_common_dev_probe(struct rte_device *eal_dev) new_device = true; } else { /* Validate combination here. */ - ret = is_valid_class_combination(classes | - dev->classes_loaded); + ret = is_valid_class_combination(classes | dev->classes_loaded); if (ret != 0) { DRV_LOG(ERR, "Unsupported mlx5 classes combination."); return ret; } } + if (dev->ctx.ctx) { + /* Validate HCA attributes here. */ + ret = mlx5_hca_attr_validate(&dev->ctx.hca_attr, + classes | dev->classes_loaded); + if (ret) + goto class_err; + } ret = drivers_probe(dev, classes); if (ret) goto class_err; diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h index 644dc58bc9..da03e160d2 100644 --- a/drivers/common/mlx5/mlx5_common.h +++ b/drivers/common/mlx5/mlx5_common.h @@ -329,10 +329,11 @@ void mlx5_common_init(void); * Contains HW device objects which belong to same device with multiple drivers. */ struct mlx5_dev_ctx { - void *ctx; /* Verbs/DV/DevX context. */ - void *pd; /* Protection Domain. */ - uint32_t pdn; /* Protection Domain Number. */ - int numa_node; /* Numa node of device. */ + void *ctx; /* Verbs/DV/DevX context. */ + void *pd; /* Protection Domain. */ + uint32_t pdn; /* Protection Domain Number. */ + int numa_node; /* Numa node of device. */ + struct mlx5_hca_attr hca_attr; /* HCA attributes. */ }; struct mlx5_common_device { -- 2.25.1