DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55
@ 2021-08-10 23:03 Dmitry Kozlyuk
  2021-08-17 14:35 ` Bruce Richardson
  2021-08-23 12:41 ` Nick Connolly
  0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-08-10 23:03 UTC (permalink / raw)
  To: dev
  Cc: Dmitry Kozlyuk, nick.connolly, stable, Bruce Richardson, Narcisa Vasile

Install command for meson >= 0.55.0 referenced the script by a plain
string, assuming the build directory to be directly under the source
tree root. This resulted in an error when the assumption did not hold:

    c:\python\python.exe: can't open file
    '../buildtools/symlink-drivers-solibs.py':
    [Errno 2] No such file or directory

Use files() to make a valid script path for any build directory.

Fixes: cd27047dbee1 ("build: support drivers symlink on Windows")
Cc: nick.connolly@mayadata.io
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
Note: this is not limited to Windows, it just happens that Windows
requires newer meson and the error example is from Windows build.

 config/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/meson.build b/config/meson.build
index e80421003b..3b5966ec2f 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -61,7 +61,8 @@ if not is_windows
             get_option('libdir'), pmd_subdir_opt)
 elif meson.version().version_compare('>=0.55.0')
     # 0.55.0 is required to use external program with add_install_script
-    meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py',
+    meson.add_install_script(py3,
+            files('../buildtools/symlink-drivers-solibs.py'),
             get_option('libdir'), pmd_subdir_opt, get_option('bindir'))
 endif
 
-- 
2.29.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-27 19:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 23:03 [dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55 Dmitry Kozlyuk
2021-08-17 14:35 ` Bruce Richardson
2021-08-18 20:55   ` Dmitry Kozlyuk
2021-08-27 19:44   ` Thomas Monjalon
2021-08-23 12:41 ` Nick Connolly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).