From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2A18DA0C47;
	Thu, 19 Aug 2021 21:34:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AE5744013F;
	Thu, 19 Aug 2021 21:34:52 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A43194003D
 for <dev@dpdk.org>; Thu, 19 Aug 2021 21:34:51 +0200 (CEST)
Received: from microsoft.com (linux.microsoft.com [13.77.154.182])
 by linux.microsoft.com (Postfix) with ESMTPSA id 9B53520C33B2;
 Thu, 19 Aug 2021 12:34:50 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9B53520C33B2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1629401690;
 bh=lyboX/NFIhqIp2sBbnqBwAMNOqT9H6TqpSNevuW3AlM=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=bf3UA2Dh2WvichahZ0I+4SytmkCsIGDd6oHYbiiuWdQ3BM5YtB0Sk9t4O3JadI8Xx
 P3STgq/95Q3sX2apOL2WXx6iI3aDEpEVAS/d2n3ye8Eibzlc25bO0IOJH05+/KwvG4
 HUYLPHIO/dTHKIgmj8pe9ifFBOHxYGXFGUOYsAH8=
Date: Thu, 19 Aug 2021 12:34:46 -0700
From: Sowmini Varadhan <sovaradh@linux.microsoft.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "sowmini05@gmail.com" <sowmini05@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "thomas@monjalon.net" <thomas@monjalon.net>
Message-ID: <20210819193446.GA11221@microsoft.com>
References: <cover.1629287046.git.sovaradh@linux.microsoft.com>
 <9085a3881fabec43eeeb5b3227c569cf559648a2.1629287046.git.sovaradh@linux.microsoft.com>
 <DM6PR11MB2890BDFA2396780019F32EEEEFC09@DM6PR11MB2890.namprd11.prod.outlook.com>
 <20210819152009.GA24347@microsoft.com>
 <DM6PR11MB2890C519EE9304FE612A8830EFC09@DM6PR11MB2890.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM6PR11MB2890C519EE9304FE612A8830EFC09@DM6PR11MB2890.namprd11.prod.outlook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL
 table for tcp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On (08/19/21 16:21), Iremonger, Bernard wrote:
> 
> Looking closer at this patchset, I am not sure that a second ACL table is needed.
> The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags.
> I think it just needs to be modified to process the TCP flags.
> Could you take another look to see if the above proposed solution will work for you.

I'm not sure it would. As I pointed out in the original rfc  at
https://inbox.dpdk.org/dev/cover.1578936382.git.sowmini.varadhan@microsoft.com/

we need to add a key for the 8 bit flags, but the multibit
trie lookup moves in steps of 4 bytes.

However, it has admittedly been a while since I tinkereed with this,
and I can give it a shot and get back.

Thanks
--Sowmini