* [dpdk-dev] [PATCH] net/i40e: fix mbuf leak
@ 2021-08-23 1:50 chenqiming_huawei
2021-09-13 2:29 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: chenqiming_huawei @ 2021-08-23 1:50 UTC (permalink / raw)
To: dev; +Cc: beilei.xing, Qiming Chen, stable
From: Qiming Chen <chenqiming_huawei@163.com>
A local test found that repeated port start and stop operations during
the continuous SSE vector bufflist receiving process will cause the mbuf
resource to run out. The final positioning is when the port is stopped,
the mbuf of the pkt_first_seg pointer is not released. Resources lead.
The patch scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Cc: stable@dpdk.org
Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
drivers/net/i40e/i40e_rxtx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 026cda948c..e4dfde9171 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2590,6 +2590,10 @@ i40e_reset_rx_queue(struct i40e_rx_queue *rxq)
#endif /* RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC */
rxq->rx_tail = 0;
rxq->nb_rx_hold = 0;
+
+ if (rxq->pkt_first_seg != NULL)
+ rte_pktmbuf_free(rxq->pkt_first_seg);
+
rxq->pkt_first_seg = NULL;
rxq->pkt_last_seg = NULL;
--
2.30.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix mbuf leak
2021-08-23 1:50 [dpdk-dev] [PATCH] net/i40e: fix mbuf leak chenqiming_huawei
@ 2021-09-13 2:29 ` Zhang, Qi Z
2021-09-16 16:16 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2021-09-13 2:29 UTC (permalink / raw)
To: chenqiming_huawei, dev; +Cc: Xing, Beilei, stable
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> chenqiming_huawei@163.com
> Sent: Monday, August 23, 2021 9:51 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> <chenqiming_huawei@163.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix mbuf leak
>
> From: Qiming Chen <chenqiming_huawei@163.com>
>
> A local test found that repeated port start and stop operations during the
> continuous SSE vector bufflist receiving process will cause the mbuf resource
> to run out. The final positioning is when the port is stopped, the mbuf of the
> pkt_first_seg pointer is not released. Resources lead.
> The patch scheme is to judge whether the pointer is empty when the port is
> stopped, and release the corresponding mbuf if it is not empty.
>
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix mbuf leak
2021-09-13 2:29 ` Zhang, Qi Z
@ 2021-09-16 16:16 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2021-09-16 16:16 UTC (permalink / raw)
To: Zhang, Qi Z, chenqiming_huawei, dev; +Cc: Xing, Beilei, stable
On 9/13/2021 3:29 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of
>> chenqiming_huawei@163.com
>> Sent: Monday, August 23, 2021 9:51 AM
>> To: dev@dpdk.org
>> Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
>> <chenqiming_huawei@163.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/i40e: fix mbuf leak
>>
>> From: Qiming Chen <chenqiming_huawei@163.com>
>>
>> A local test found that repeated port start and stop operations during the
>> continuous SSE vector bufflist receiving process will cause the mbuf resource
>> to run out. The final positioning is when the port is stopped, the mbuf of the
>> pkt_first_seg pointer is not released. Resources lead.
s/lead/leak/
Will update on next-net
>> The patch scheme is to judge whether the pointer is empty when the port is
>> stopped, and release the corresponding mbuf if it is not empty.
>>
>> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-16 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 1:50 [dpdk-dev] [PATCH] net/i40e: fix mbuf leak chenqiming_huawei
2021-09-13 2:29 ` Zhang, Qi Z
2021-09-16 16:16 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).