From: Xueming Li <xuemingl@nvidia.com>
Cc: <dev@dpdk.org>, <xuemingl@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Subject: [dpdk-dev] [PATCH] net/virtio: wait device ready in device reset
Date: Mon, 23 Aug 2021 09:39:06 +0300 [thread overview]
Message-ID: <20210823063906.1382544-1-xuemingl@nvidia.com> (raw)
According to virtio spec, the device MUST reset when 0 is written to
device_status, and present a 0 in device_status once that is done.
This patch adds the missing part of waiting status 0 in reset function.
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
drivers/net/virtio/virtio.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio.c b/drivers/net/virtio/virtio.c
index 7e1e77797f..f003f612d6 100644
--- a/drivers/net/virtio/virtio.c
+++ b/drivers/net/virtio/virtio.c
@@ -3,6 +3,8 @@
* Copyright(c) 2020 Red Hat, Inc.
*/
+#include <unistd.h>
+
#include "virtio.h"
uint64_t
@@ -39,8 +41,9 @@ void
virtio_reset(struct virtio_hw *hw)
{
VIRTIO_OPS(hw)->set_status(hw, VIRTIO_CONFIG_STATUS_RESET);
- /* flush status write */
- VIRTIO_OPS(hw)->get_status(hw);
+ /* Flush status write and wait device ready. */
+ while (VIRTIO_OPS(hw)->get_status(hw) != VIRTIO_CONFIG_STATUS_RESET)
+ usleep(1000L);
}
void
--
2.25.1
next reply other threads:[~2021-08-23 6:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 6:39 Xueming Li [this message]
2021-08-23 9:56 ` Andrew Rybchenko
2021-08-23 13:54 ` Xueming(Steven) Li
2021-08-24 15:40 ` Andrew Rybchenko
2021-08-26 7:15 ` Xia, Chenbo
2021-09-15 9:23 ` Xueming(Steven) Li
2021-09-15 9:21 ` [dpdk-dev] [PATCH v1] net/virtio: wait device ready during reset Xueming Li
2021-09-15 9:27 ` Andrew Rybchenko
2021-09-15 10:14 ` Xueming(Steven) Li
2021-09-15 10:12 ` [dpdk-dev] [PATCH v2] " Xueming Li
2021-09-15 10:30 ` Andrew Rybchenko
2021-09-15 11:44 ` Xia, Chenbo
2021-09-28 15:31 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823063906.1382544-1-xuemingl@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).