From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5369AA0C56; Mon, 23 Aug 2021 09:51:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7023141141; Mon, 23 Aug 2021 09:51:41 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.166.231]) by mails.dpdk.org (Postfix) with ESMTP id 8A0D341122 for ; Mon, 23 Aug 2021 09:51:40 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 47D4D2477E for ; Mon, 23 Aug 2021 00:51:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 47D4D2477E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1629705100; bh=YAodkfC0PQlBogh4N+bdlGtyoScvDD1dLS7KoKKJE4k=; h=From:To:Subject:Date:In-Reply-To:References:From; b=pn8vPsXJ+f5EfN/jINOxBYE15wIhikOR/bzXu4/uN54PilqwCFQz2WeuqNu0E+IJe WhvNHcgIGY+fj/C8W3KmObqZqHN7dAB0r35jkeps35Gs6is+18EgvHXhVN2IfnVGpH Y5tBcah97T299ILonJbuWsN2JqtzoExhhsZDubDg= From: Kalesh A P To: dev@dpdk.org Date: Mon, 23 Aug 2021 13:42:12 +0530 Message-Id: <20210823081214.9725-2-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20210823081214.9725-1-kalesh-anakkur.purayil@broadcom.com> References: <20210823081214.9725-1-kalesh-anakkur.purayil@broadcom.com> Subject: [dpdk-dev] [PATCH 1/3] net/bnxt: fix Rx mbuf VLAN in scalar Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP In the scalar Rx path, for the VLAN packet, TCI is not saved in the "mbuf->vlan_tci", however the STRIPPED offload flag is set along with PKT_RX_VLAN flag. Fixes: c1b33d40315f ("net/bnxt: use table based mbuf flags handling") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 2 ++ drivers/net/bnxt/bnxt_rxr.h | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index aea7170..5d8b738 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -962,6 +962,8 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1); + bnxt_set_vlan(rxcmp1, mbuf); + if (BNXT_TRUFLOW_EN(bp)) mark_id = bnxt_ulp_set_mark_in_mbuf(rxq->bp, rxcmp1, mbuf, &vfr_flag); diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h index dc2b1b7..59adb72 100644 --- a/drivers/net/bnxt/bnxt_rxr.h +++ b/drivers/net/bnxt/bnxt_rxr.h @@ -185,6 +185,16 @@ bnxt_check_ptype_constants(void) extern uint32_t bnxt_ptype_table[BNXT_PTYPE_TBL_DIM]; +static inline void bnxt_set_vlan(struct rx_pkt_cmpl_hi *rxcmp1, + struct rte_mbuf *mbuf) +{ + uint32_t metadata = rte_le_to_cpu_32(rxcmp1->metadata); + + mbuf->vlan_tci = metadata & (RX_PKT_CMPL_METADATA_VID_MASK | + RX_PKT_CMPL_METADATA_DE | + RX_PKT_CMPL_METADATA_PRI_MASK); +} + /* Stingray2 specific code for RX completion parsing */ #define RX_CMP_VLAN_VALID(rxcmp) \ (((struct rx_pkt_v2_cmpl *)rxcmp)->metadata1_payload_offset & \ -- 2.10.1