From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63486A0C53; Mon, 23 Aug 2021 21:14:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A3774014D; Mon, 23 Aug 2021 21:14:08 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id F1AE240142 for ; Mon, 23 Aug 2021 21:14:06 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id p38so40149671lfa.0 for ; Mon, 23 Aug 2021 12:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CxhOOoa3VgXCCeLYRGesCEPdYZ6u9o4YizRbAh+4SCY=; b=SfWpVE1uO3Y67uJdS4IXp4DEntW61/brIrk1gG2B2GJbsuh7yEkZlMSUuxNgzIMlph xQkAICXGwPZxdPiz3QJRWDpFY9W0XD/Q/zMLsgxVqpjoQmMuWnOwtTZu9FT0zCgx0Dt/ 0/xAsggr2TGW9Sa61K9RPYrZ+B+ZeZ/Uu/ldXDP6BK1PnmbYd9BuTKMqrVcubopab5Mg eZ3CgFLNFPcYbmjr2y/oQskb97sebnQRtNgh5oZ+Nqr1rSN+YVegB1B3Qmppm0cMsENH rbtOKh+wD0bLYYBtN9Zram513nAGS7gXRh2ojGuVYwJwRuxijMyUss98t2FclHyhANjy RdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CxhOOoa3VgXCCeLYRGesCEPdYZ6u9o4YizRbAh+4SCY=; b=o2UQ9D54T+sNomsirEYGgNYSob892J3LMiSg+DlSe42VnHjxzjX+WQq36grD5iy81Q W5+RoANxeNuEIGWq/rDuiZoUyTr4TeYg/V+xcywjjPie7Ui0PDtrpuAMZBEc/oDViwrx qu0Zod6dAqK4KT972S+t60b8V3j96FWefVf2HCOgryQ0V6tD7BjfZ5KAVGLoY7eI9iah bJGT1prjgwLg8FHN4/2Cak0S7BEGSVUviGof5mAZPk2v2qPdrNZrZ9b8fX5RBdNp/1y1 OoVSKpL4qwaAZqCwHWmX1xeB0Px2EP6YU30PswxCvj+N0eqcc0vpz+kE3UzHYGoz2fly 8EOA== X-Gm-Message-State: AOAM532AtCSihQOr+sa5oEoP9pyqcXh8x+lRzfpMMonKnYg6K/kLjoxR fN0CnXjuUvSjn+30pn1cWzU= X-Google-Smtp-Source: ABdhPJzDfNetqxBWc9uO+kdXJlUeXGFJkjA1oYZyv9184rmSdSEN0pAFVsGoSYOfOGUuzMnhpDLtfw== X-Received: by 2002:a05:6512:68e:: with SMTP id t14mr27049547lfe.429.1629746046541; Mon, 23 Aug 2021 12:14:06 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id t70sm1523703lff.91.2021.08.23.12.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 12:14:05 -0700 (PDT) Date: Mon, 23 Aug 2021 22:14:03 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dev@dpdk.org, Nick Connolly Message-ID: <20210823221403.10312c5b@sovereign> In-Reply-To: <20210823130343.87247-1-u9012063@gmail.com> References: <20210818232632.7068-1-u9012063@gmail.com> <20210823130343.87247-1-u9012063@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8] eal: remove sys/queue.h from public headers. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-08-23 13:03 (UTC+0000), William Tu: [...] > /* This macro permits both remove and free var within the loop safely.*/ > -#ifndef TAILQ_FOREACH_SAFE > -#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \ > - for ((var) = TAILQ_FIRST((head)); \ > - (var) && ((tvar) = TAILQ_NEXT((var), field), 1); \ > +#ifndef RTE_TAILQ_FOREACH_SAFE > +#define RTE_TAILQ_FOREACH_SAFE(var, head, field, tvar) \ > + for ((var) = RTE_TAILQ_FIRST((head)); \ > + (var) && ((tvar) = RTE_TAILQ_NEXT((var), field), 1); \ > (var) = (tvar)) > #endif 1. Unlike TAILQ_FOREACH_SAFE, new RTE_ macro doesn't need #ifdef. 2. There should be no period at the end of the subject (./devtools/check-git-log.sh would show that). Except for these nits, Acked-by: Dmitry Kozlyuk