From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C283DA0C41; Wed, 25 Aug 2021 21:45:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 882DE4013F; Wed, 25 Aug 2021 21:45:41 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id 8C6494003D for ; Wed, 25 Aug 2021 21:45:39 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id y144so694218qkb.6 for ; Wed, 25 Aug 2021 12:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MRx0FQxij38bes9sqxzN1IjLJELXaAafEuQ1g6nl+7I=; b=VIHyfkNrsh+PABsq3DUaOp6QAjWNZlq/zdsBkkN5W0a2DKODu4NoEScyjU1TO4DVoo kzeYWf/gv3QgWlJK2M6+ZQS4rNTV+7WPiULIyiX+rHnfX+s1HNp0tx8vDObmB2QM55pr bZ6FzKH1ey5YioglmI8DgMY2OORSJDGdYVX3ZtKwqwBuiIWt4dDKUbHZFboTMx22+0W3 CT8pp6zfjmVWyBk725Dq4LZQEaEGqbrMlg8mmTsOFc8YAOoikObJTbbQ6NX9VlY9X3EF JyGdQcMoEEcJPtWClHXpXDFrCvD7XZUTZGp1/nOoiswDTFCo/G4tPS2lW/6c+nUI8F6l sfzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MRx0FQxij38bes9sqxzN1IjLJELXaAafEuQ1g6nl+7I=; b=Ujx/FWHfY5HzOst/QIgZIqqa3ZgWTITU5nR4XHAArge8WYxvTve9/1qWmSRyTx+xXc C7Jq8LVJsEmEVpdKnYP+rlpo23k0VMDqYj3qpb7zgZ0zGUZGUFmDRRs9c9/RtXHZofSv 17hRnnBmWAKXrdablOGESZ/KVuOJUoTuPvoEulM0+tF5a4DrweKIZvT7J/1rNZ5Veqij N0X+OiuPcDewJvmxjHwXXOCU9Aay9HrSLW+omp3xIlPaqfxnp+4GFBa2o5eh7B2WLT31 ldtyogPBsouUSNMwIUaot5lj56HbRTu5kmqIHJacxt5Z+GWxbI9Wv0aU+vUaaMOHOeBZ 9tiA== X-Gm-Message-State: AOAM532+KZTFjZjElUh92Jf8GGVcwYzTADI1KE2mpSUzfDK2nzOhLwag PTn0EgnblKa/vBHII/rN2qx++LaEqYTz9A== X-Google-Smtp-Source: ABdhPJxvmkmFrPb1vRHH/GPihKsoVLzvBJ+MFzmmAQA8BlghrBGQbIzU+zOqMl9aJsZX22GwlX3L2A== X-Received: by 2002:a37:96c2:: with SMTP id y185mr223491qkd.6.1629920738752; Wed, 25 Aug 2021 12:45:38 -0700 (PDT) Received: from lvdi-01-iad-l.blue.trinitycyber.com ([38.142.224.194]) by smtp.gmail.com with ESMTPSA id i14sm693197qka.66.2021.08.25.12.45.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Aug 2021 12:45:38 -0700 (PDT) From: Ben Magistro To: dev@dpdk.org Cc: ben.magistro@trinitycyber.com, stefan.baranoff@trinitycyber.com, Ben Magistro Date: Wed, 25 Aug 2021 19:45:26 +0000 Message-Id: <20210825194526.14987-1-koncept1@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] driver: i40evf device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The i40evf driver is not initializing the eth_dev attribute which can result in a nullptr dereference. Changes were modeled after the iavf_dev_init() per suggestion from the mailing list[1]. [1] https://mails.dpdk.org/archives/dev/2021-August/217251.html Signed-off-by: Ben Magistro --- drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 0cfe13b7b2..ccdce9a16a 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -1564,8 +1564,9 @@ i40evf_dev_alarm_handler(void *param) static int i40evf_dev_init(struct rte_eth_dev *eth_dev) { - struct i40e_hw *hw - = I40E_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private); + struct i40e_adapter *adapter = + I40E_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private); + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(adapter); struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); PMD_INIT_FUNC_TRACE(); @@ -1596,11 +1597,14 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev) hw->device_id = pci_dev->id.device_id; hw->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id; hw->subsystem_device_id = pci_dev->id.subsystem_device_id; + hw->bus.bus_id = pci_dev->addr.bus; hw->bus.device = pci_dev->addr.devid; hw->bus.func = pci_dev->addr.function; hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; hw->adapter_stopped = 1; hw->adapter_closed = 0; + hw->back = I40E_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private); + adapter->eth_dev = eth_dev; if(i40evf_init_vf(eth_dev) != 0) { PMD_INIT_LOG(ERR, "Init vf failed"); -- 2.27.0