From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F456A0547; Thu, 26 Aug 2021 19:24:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6847F41228; Thu, 26 Aug 2021 19:24:51 +0200 (CEST) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (unknown [40.107.140.98]) by mails.dpdk.org (Postfix) with ESMTP id 1951A40140 for ; Thu, 26 Aug 2021 13:30:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvASosc66W+lSNOqs3rMyOM8KIMweMlMkq5hBkvKKhr0MlX4QK8oOAPDUw59/aHduELrNRVq7melQuonZMvfyPe/KMjSxmK+xECd5g4dLuX+gyGygtZYaPoShkiRjijLJ4mucCOwePG23ohet8Mb+UjJX0orM7oRdPlQqV6wYjgoD9VhshxNBCcnDgYGqz508PqufFon0uaHYxLf1W2R2pTeNzPAOoD5+/u4c4rSYp3UgjiN+gBBFBtOYmwx6fZGbdUeiAzSDfL2LLdMH673fSBQNS/uSgS1I73D7psvSleTMUjcGOYT2YAFjxlqSwSouAt+BmYvESiCelb0ZzqR3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hoTVQDVXkCjLmhlC3EFGrhee0HTQRFKcV+6LTZd3p9U=; b=U/kAZvUSRWaycGxB/HATf+egHsZhDY1Ludp+iMixK3nnvZQUSxru226DYiaLnnDkAhOB7VGIu3LV8knmg221OVuTxuWwkgWdbpMFSyTpaUhdoslZViQLbKgX9PkR4CeDG+tWerdaMK8BBK2ZXvklue3GyS+sC3RYsomWy3TjUJ6sMMR+wKU8tYt4JzGwVy33elTPpAf5wVnCw6wy26cjAvqjJ1fZIBOTi9kLqDMIRHd481BVfbnM/nMygfXS4K2bRgtLxmpNoA65Qwqow32y/LfI9gMgnQaDoG1eGduUPWBU/svzJoZ+4va+vu321VCxkwnLlyRcNHIrW6fQwfQ6Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hoTVQDVXkCjLmhlC3EFGrhee0HTQRFKcV+6LTZd3p9U=; b=Pie6A5nRnSHGDxC/5RSnarQeD7pcsHMuqPS7d/LOKHAc2SIizUxbReAfAYf6DEoygmJCnPKDm40QXaBIDIXIFSHJAMPHuyPN38s3YEDiGVjJNvnHZh0WqfQuY/KcYIjkk09H3e1dYBcM3xB4hf5Zm/tAwRQYt2WEWMPmWuIWJyI= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=connect.ust.hk; Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYYP286MB1440.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Thu, 26 Aug 2021 11:30:30 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 11:30:30 +0000 From: Chengfeng Ye To: asomalap@amd.com Cc: dev@dpdk.org, Chengfeng Ye Date: Thu, 26 Aug 2021 04:30:20 -0700 Message-Id: <20210826113020.88012-1-cyeaa@connect.ust.hk> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: HK2PR0401CA0014.apcprd04.prod.outlook.com (2603:1096:202:2::24) To TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (218.253.253.162) by HK2PR0401CA0014.apcprd04.prod.outlook.com (2603:1096:202:2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Thu, 26 Aug 2021 11:30:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3c23228-dced-4ac6-f93a-08d96884e8a4 X-MS-TrafficTypeDiagnostic: TYYP286MB1440: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XUuDAmKeVJBk5KiB/0mdgYPDnc92eRXxkydWPaZRc3JdSpjsn5hEtJqcVMvvRplYp4zBj9jnl0Asm/R1eRMu40azRmme7Qft17F4GfckoAHeZs9TP6/O7fsZDg89KSjIjCCmTHEYQ/2VrX7bta501rcbXrgeh5n0vnQrTgyFZjjtla4mEAHrAXbL2+CZebnpoJ9nIOpM8hwR9o+E3DEGhHBQ34rSby5I4rcOMZLe+NVIM0jrs7nKxVXe51oGjuGTtzrYD5b7AFtECLHvjANLJzTDHEA/NNlX8yeE512+jAOwlILe4UUKiY85TrSG49xcPf1t44pnb6D80ApWwFYfYC17WWrlg2x0rnRtp1OHcAjH9Ot7veoYXBXT5+O3sf2UtU+NTdiH1jR5JaJL8C/ePHXqKd+thKCq3HyhGxwybSFsdwlYqb2s7eWIMo9lsXYQ6G78CHRB9N1y/s9r1BgRwNe6PJiOW+JdpHJkahlw2G0DHqsdukQJdZANzWS7J6PBA1/vwCDi0MBCmo6cAJh4yrAK4KLT2+Gy3iNS3kPrf33Xv9mP6P7WgbDazGE5kSE4vZh7w74TQDO0cLDLb/9LTCPAV8LyzRJeScU96fdeYHanKyu8o1QUvVJBP1R7IZ5/RzccxvuOh3BmKa/+b4+1plMxc0eC1ME++q0J1YH3HLpD14NksWFoZ5i8/EzzuW6hAlTv1kcc6iI7yrgCVn8Vg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(366004)(52116002)(107886003)(66946007)(6486002)(6512007)(6666004)(786003)(316002)(508600001)(66556008)(86362001)(66476007)(38100700002)(4326008)(5660300002)(38350700002)(83380400001)(8676002)(8936002)(1076003)(26005)(186003)(956004)(2616005)(6506007)(36756003)(6916009)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6URE4P5ftNri7kPBMiOk5W7EFQ/4Wwx8O8iLUyEyLJ8X29BTeKkflqS6W6wb?= =?us-ascii?Q?mt1TL7nKuSzaz77dFWVwKiW7EuzCCApWUR7h4Xbjmc68oHKPgRAWC2RDh7Ti?= =?us-ascii?Q?0j2R3fTKJVNX5kjdBE98K8z5mJ1uCe5AltkR6eWslPvTE9MgFEkqni4IxtMm?= =?us-ascii?Q?zqpuNZPz1S0yi3UOrU2i9u4YPfK6+odr7jRQi0sXcrisgFQ8idtUsrpgv6F8?= =?us-ascii?Q?q2DYvLj7FJ8Vwz7UgAOC/EK+5n/Mu2Y8ijtBCMoHWCHWHZGQ7pSJx2TB/0Jf?= =?us-ascii?Q?7c/AalGaxPSHKN5AMRDwtfPRpLFf3WHwVFJIONkElVuQS9bQM5S4veGp3Wl/?= =?us-ascii?Q?1HFC0gOMQywPUKEtVDR0i6Erl468T8v0turLBecs2eAc/jRwSQ0OcHhOCqWU?= =?us-ascii?Q?DL9JGnewHcNZQCxWKMhI/vQJH72r99uDJ/eNpOUANCDVpREojD6nDFgFm2jE?= =?us-ascii?Q?XNo+M3pN10vJlEAKB0pFk/iLZ/m7xeiVrbr4fS4n8ZQZJlDiQ1ydmQClu7h4?= =?us-ascii?Q?W2/SGSlF47qd84FS9TfHYC/MwUzhQU64ZsUpefodBneDzAv7rag2UgygUMVM?= =?us-ascii?Q?9zALjgNtkOkwpOqX8oZhFYNjVteD2D8RZ7IbqQbkdbItgjZPJ3+x+6QwSWYp?= =?us-ascii?Q?HgmKfS1llQchscaWHar4a4ZVoHO6QjUix5uZCAvDUrQjSB/v/1+1gBQ1vDFp?= =?us-ascii?Q?QwuTtsYB1kR1mhFrmgJs6WFvoJ/erqbr3Ha1LSJk3gZ8Mjo+ZBi6UUJEDc1P?= =?us-ascii?Q?phJcmYZxUH4E3N+7AdKNAINU7yVAY8Pq3K+2laPU8l8HNPYi9tij0+xdDjEm?= =?us-ascii?Q?ymdR6dZxjV0cCtCwNtYQ7Ctq2lHrC9UDS8aKb/BrYriRRxzNzqTJE8BBaRzM?= =?us-ascii?Q?dC9k1YLyLPq71vgoH2dj8oOPZEpre1GH8qlBv+VqdhJ4p0412Lkq5F+fH65M?= =?us-ascii?Q?c0dIoYJTd0nUhK54eP8lsyVwfCgKUad2zGTgAgkOVmeY8qDRphYA7D1eQX2M?= =?us-ascii?Q?WdDpIhID/Uqr7Tb/iT/u8W9CS2RlN6QEaOBaonkL6mCEozh8bS8Yvwx/9sXO?= =?us-ascii?Q?wCaC91VqyVL4W8x0flspLdlXnWFrTMO65+HtMftGBsyijVGHHR8j4c7VsWDT?= =?us-ascii?Q?N9YuIfe1Ab6osaIkNCjbfQ+65x+iJwG+DkY5ckAqjVZ7IUd1u1JLhFxVznGJ?= =?us-ascii?Q?YCyN0wGDwOdW/bktW0DS052aAawCxzcacI3T3XqBi3gPV7YFly0Tj4luiCG0?= =?us-ascii?Q?4TddenQbULGNrtQR04a5IUZFHYSdZA1f7fVZguJd5FwiYP3D0Lakblf2oqcG?= =?us-ascii?Q?Cm0LHHEIhT4Xkta5vdsgaoqd?= X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: a3c23228-dced-4ac6-f93a-08d96884e8a4 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 11:30:30.1516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vROXp1tb2pGJetKoWoqO8pecMzdtrPYkexnOoGjD5++ofyx7lp0EsPnAEJzTwD25knsdUhnInz2OHdosXO36BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1440 X-Mailman-Approved-At: Thu, 26 Aug 2021 19:24:49 +0200 Subject: [dpdk-dev] [PATCH] net/axgbe: fix protential unreleased lock problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The lock pdata->phy_mutex may not be correctly released if the function return in these two branches, which may lead to deadlock if the lock is acuired again. The patch is to fix this problem. Cc: cyeaa@connect.ust.hk Bugzilla ID: 776 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_phy_impl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 02236ec192..cf39095ee4 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -418,8 +418,10 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) */ pthread_mutex_lock(&pdata->phy_mutex); - if (phy_data->comm_owned) + if (phy_data->comm_owned) { + pthread_mutex_unlock(&pdata->phy_mutex); return 0; + } /* Clear the mutexes */ XP_IOWRITE(pdata, XP_I2C_MUTEX, AXGBE_MUTEX_RELEASE); @@ -444,6 +446,7 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) XP_IOWRITE(pdata, XP_MDIO_MUTEX, mutex_id); phy_data->comm_owned = 1; + pthread_mutex_unlock(&pdata->phy_mutex); return 0; } -- 2.17.1