From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C40FA0C43; Thu, 26 Aug 2021 12:15:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04CE1411FB; Thu, 26 Aug 2021 12:15:11 +0200 (CEST) Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by mails.dpdk.org (Postfix) with ESMTP id 8A5ED4013F for ; Thu, 26 Aug 2021 12:15:08 +0200 (CEST) Received: from coaster.localdomain (unknown [IPv6:2001:67c:1220:80e:a9:edd0:2e93:a6c4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 6FF4F40006C; Thu, 26 Aug 2021 12:15:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1629972908; bh=vWEYCF01KoYR3AtxWNrOSp8RAOp5srYoewrmI2D4G1I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=dRIXpikuYuG8BA334PzeZtVUvj9EmB7+inbrCk10WK0tq9PTkBaDC0EcbOQZCKcFR kuBQ3Uuc9g4/xUPElbdl3EApcBSXq2W0vXHrXTK4x59+PAHvWvUnlZn99YXOfXaLVN 0cMKwMjuzKjbxZGPJjfYLu5Wr0CxkRAljOaJ1BMuD2HFaWTkwlTfJ5nHUAo9gh+NAW xZrw2JfyvZsyJUyLHPFosd/HSDQevbdsnJBmS3F4iDlzQXrV4IiYy4gnmH2ucAn00H v4QSNSOwIndHRVnocnWJ3Spr0wO0kojI/xcT+Qg0T7AzELmY5XUZbQtPTHFKTlBvL3 ag96JEf9WAcTw== Date: Thu, 26 Aug 2021 12:15:05 +0200 From: Jan Viktorin To: Ferruh Yigit Cc: Thomas Monjalon , Ori Kam , "Andrew Rybchenko" , =?UTF-8?B?SGF2bMOt?= =?UTF-8?B?aw==?= Martin , , "Min Hu (Connor)" , Matan Azrad , Chas3 , Slava Ovsiienko Message-ID: <20210826121505.55de1254@coaster.localdomain> In-Reply-To: <7e6911de-c979-52bd-bdd1-763d3d7a2e7c@intel.com> References: <20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz> <20210714170019.40bc169a@coaster.localdomain> <19363394.Odk5eMyVqo@thomas> <7e6911de-c979-52bd-bdd1-763d3d7a2e7c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 24 Aug 2021 14:18:16 +0100 Ferruh Yigit wrote: > On 7/15/2021 2:58 PM, Thomas Monjalon wrote: > > 14/07/2021 17:00, Jan Viktorin: > >>>> On Tue, 13 Jul 2021 12:26:35 +0300 > >>>> Andrew Rybchenko wrote: > >>>>>>>>>> This matters for the bonding case as well, doesn't it?. > >>>>>>>>>> It is not desirable to accidently omit a packet that was > >>>>>>>>>> received by primary ingress logic instead of being > >>>>>>>>>> redirected into the dedicated queue. > >>>>>>>>>> > >>>>>>>>>> Are there any chances that for mlx5 it would be possible > >>>>>>>>>> to insert flow rules before calling rte_eth_dev_start? > >>>>>>>>>> Anyway, the behaviour should be specified and documented > >>>>>>>>>> in DPDK more precisely to avoid such uncertainty in the > >>>>>>>>>> future. > >>>>>>>>> I agree the documentation should be fixed. > >>>>>>>> > >>>>>>>> +1 > >>>>> > >>>>> Cc Thomas and Ferruh since ethdev documentation should be > >>>>> clarified. > >>>>> > >>>>> It looks like there is no consensus if the patch is a right > >>>>> direction or wrong. For me it looks wrong taking all above > >>>>> arguments in to account (mainly necessity to be able to insert > >>>>> flows before pushing start button which enables the traffic if > >>>>> HW supports it). > >>>>> > >>>>> So, I'm applying first two patches and hold on this one. > >> > >> Andrew, I believe that it would be helpful to start some new thread > >> otherwise we would get lost here :). It seems that we will have few > >> more fixes for the bonding driver. Do you prefer an entirely new > >> patchset or v2 of this topic? Or any other advise how to proceed? > > > > This thread is about 3 things: > > - bonding issue > > - ethdev doc > > - mlx5 design > > That's too much topics to address in one thread :) > > > > You may restart the discussion with a doc update > > if the stop/start requirement is not clear. > > > > > > Is separate discussions created as follow up? > Martin is recently unavailable. But he has already started a new thread for _ethdev doc_ topic: [PATCH 0/4] doc: update RTE flow rule and bonding related info https://www.mail-archive.com/dev@dpdk.org/msg214517.html to first clarify/document what is the current status and how to proceed. Jan