From: Chengfeng Ye <cyeaa@connect.ust.hk>
To: matan@nvidia.com, viacheslavo@nvidia.com, tzahio@nvidia.com
Cc: dev@dpdk.org, Chengfeng Ye <cyeaa@connect.ust.hk>
Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem
Date: Thu, 26 Aug 2021 11:55:07 -0700 [thread overview]
Message-ID: <20210826185507.107151-1-cyeaa@connect.ust.hk> (raw)
The lock sh->txpp.mutex isn't correctly released if the function
return in these two branches, which may lead to deadlock if the
lock is acquired again.
Cc: cyeaa@connect.ust.hk
Bugzilla ID: 774
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
---
drivers/net/mlx5/mlx5_txpp.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
index 4f6da9f2d1..0ece788a84 100644
--- a/drivers/net/mlx5/mlx5_txpp.c
+++ b/drivers/net/mlx5/mlx5_txpp.c
@@ -961,8 +961,12 @@ mlx5_txpp_stop(struct rte_eth_dev *dev)
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
MLX5_ASSERT(sh->txpp.refcnt);
- if (!sh->txpp.refcnt || --sh->txpp.refcnt)
+ if (!sh->txpp.refcnt || --sh->txpp.refcnt) {
+ ret = pthread_mutex_unlock(&sh->txpp.mutex);
+ MLX5_ASSERT(!ret);
+ RTE_SET_USED(ret);
return;
+ }
/* No references any more, do actual destroy. */
mlx5_txpp_destroy(sh);
ret = pthread_mutex_unlock(&sh->txpp.mutex);
--
2.17.1
next reply other threads:[~2021-08-27 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 18:55 Chengfeng Ye [this message]
2021-08-26 18:56 Chengfeng Ye
2021-08-26 19:06 ` [dpdk-dev] 回复: " YE Chengfeng
2021-08-30 7:59 ` [dpdk-dev] " Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826185507.107151-1-cyeaa@connect.ust.hk \
--to=cyeaa@connect.ust.hk \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=tzahio@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).