From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C60DA0C57; Sun, 29 Aug 2021 00:43:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA9FC40142; Sun, 29 Aug 2021 00:43:16 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 2EE0040042 for ; Sun, 29 Aug 2021 00:43:16 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id g13so22552337lfj.12 for ; Sat, 28 Aug 2021 15:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5VE4f16LIXvQNsP5LjcDeDkUln28Om37852XDWPeDTo=; b=DpnmkmPMesEU1d7eOvsNX11SjQD2k+aD051mzBzTuUjliB/cd+Uca9aHfRUce0j+X5 c7056oz9HsbU9iMSw3Jwxqgg6V/LOAbUqb/w6j99hAsLvw10/RUy9iAN+GTsvtXZzKie VrAeaYPHHyjYHYGqHDn0UFnSL1n2tXADKG9ACiTOxL0UtEbP9Dt6OZ9MwhDL0ndrd12x UjxPUU+RzVQ9wUfeYRZ8G/sgdDEzAYx9ps8d/CePqstfP+yFmWeRJLdr2xU3L2bq1gMr IfFjP8YLEdFSWSrTDMDj74RqFmk0a0TWTgM3Pn1VedyGVbNym8cLTS6M57qBHzbLSLEg xS/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5VE4f16LIXvQNsP5LjcDeDkUln28Om37852XDWPeDTo=; b=KOx9PEJbGiUlFNb8f6h9IOil90ci7vwW1hRWWzasElfa6Bogsl8h6ifgJZ7BcieoSl dNogjcjAirv21Jmw0aCS4IEMvVchHbIYBcKb3qyirlN2s98XpXvfcmSgIio7T/XBKOXL EH9rw5KWx+75KvR7LxQHY4J5triSlkGyq5k4OCjY14El9hXcMDPTAJIK9ZHCeL2hC3JG RwPrnuevfX238FG5DpJPuQDEZPr+5cIddWYxNcBwfapxfX0kkQwVJ5wGZlp9yQn9fUuE sgAzCJs3FsOKJFtrRmHcMvDCw5tACQGWD1iqVP7qatjH0rcR1J6NwK3uIFtd2X2/0bhX ltYw== X-Gm-Message-State: AOAM533/BJ6GnvGtGgBh6LDFE49Zu30K615exuCMG6wob9pUpTl35cC6 0aS5LjRyMUd1R8JeneEGyiw= X-Google-Smtp-Source: ABdhPJydKckbo3gdV8By55azdaFl8+Q27DtXSJE5B0jYhL4bjOQDKNK40C3JIDrODrTFMl1mtaxW0w== X-Received: by 2002:a05:6512:3fa8:: with SMTP id x40mr12626223lfa.345.1630190595616; Sat, 28 Aug 2021 15:43:15 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id o22sm971558lfu.188.2021.08.28.15.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 15:43:15 -0700 (PDT) Date: Sun, 29 Aug 2021 01:43:13 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Message-ID: <20210829014313.57e35cd6@sovereign> In-Reply-To: <1629306834-6277-3-git-send-email-jizh@linux.microsoft.com> References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-3-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 02/13] driver/mempool: build mempool stack on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-08-18 10:13 (UTC-0700), Jie Zhou: > mempool_autotest failed on Windows at setting the "stack" handler > test case. Per debugging, in rte_mempool_ops_table, there are only > 6 ring ops registered, and no "stack" ops registered which caused > the failure of rte_mempool_set_ops_byname and thus the test failed. > Per code investigation, the "stack" ops are registered in > rte_mempool_stack.c: > MEMPOOL_REGISTER_OPS(ops_stack); > MEMPOOL_REGISTER_OPS(ops_lf_stack); > > The reason these two ops are not registered is because currently > driver\mempool\stack is not build on Windows. After building stack > on Windows, the mempool_autotest now completed as pass. > > Signed-off-by: Jie Zhou > --- > drivers/mempool/stack/meson.build | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build > index 371cf131b1..580dde79eb 100644 > --- a/drivers/mempool/stack/meson.build > +++ b/drivers/mempool/stack/meson.build > @@ -1,11 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > -if is_windows > - build = false > - reason = 'not supported on Windows' > -endif > - > sources = files('rte_mempool_stack.c') > > deps += ['stack'] 1. The title should be "mempool/stack: build on Windows". 2. For the description it would be sufficient to say something like "Mempool unit test requires mempool/stack to pass, enable this driver", because the ops registration mechanism is standard in DPDK. P.S. It is really the test that should skip disabled driver cases, but mempool/ring and mempool/stack are very basic to DPDK, so I believe just enabling the latter is OK.