* [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy
@ 2021-08-29 9:24 Qi Zhang
2021-09-06 1:35 ` Tu, Lijuan
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2021-08-29 9:24 UTC (permalink / raw)
To: qiming.yang; +Cc: junfeng.guo, lijuan.tu, dev, Qi Zhang, stable
Apply the same fix that for iavf to DCF
commit: ead06572bd8f ("net/iavf: fix performance with writeback policy")
Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/ice_dcf_ethdev.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index cab7c4da87..3389605949 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -172,10 +172,15 @@ ice_dcf_config_rx_queues_irqs(struct rte_eth_dev *dev,
VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) {
/* If WB_ON_ITR supports, enable it */
hw->msix_base = IAVF_RX_VEC_START;
+ /* Set the ITR for index zero, to 2us to make sure that
+ * we leave time for aggregation to occur, but don't
+ * increase latency dramatically.
+ */
IAVF_WRITE_REG(&hw->avf,
IAVF_VFINT_DYN_CTLN1(hw->msix_base - 1),
- IAVF_VFINT_DYN_CTLN1_ITR_INDX_MASK |
- IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK);
+ (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
+ IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
+ (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
} else {
/* If no WB_ON_ITR offload flags, need to set
* interrupt for descriptor write back.
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy
2021-08-29 9:24 [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy Qi Zhang
@ 2021-09-06 1:35 ` Tu, Lijuan
2021-09-06 1:54 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Tu, Lijuan @ 2021-09-06 1:35 UTC (permalink / raw)
To: Zhang, Qi Z, Yang, Qiming; +Cc: Guo, Junfeng, dev, stable
> Apply the same fix that for iavf to DCF
> commit: ead06572bd8f ("net/iavf: fix performance with writeback policy")
>
> Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Tested-by: Lijuan Tu <lijuan.tu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy
2021-09-06 1:35 ` Tu, Lijuan
@ 2021-09-06 1:54 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-09-06 1:54 UTC (permalink / raw)
To: Tu, Lijuan, Yang, Qiming; +Cc: Guo, Junfeng, dev, stable
> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, September 6, 2021 9:35 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Guo, Junfeng <junfeng.guo@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix performance with writeback policy
>
> > Apply the same fix that for iavf to DCF
> > commit: ead06572bd8f ("net/iavf: fix performance with writeback policy")
> >
> > Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Tested-by: Lijuan Tu <lijuan.tu@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-06 1:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-29 9:24 [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy Qi Zhang
2021-09-06 1:35 ` Tu, Lijuan
2021-09-06 1:54 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).