From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5F32A0C56; Tue, 31 Aug 2021 19:01:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAA084068A; Tue, 31 Aug 2021 19:01:50 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 2D1A140142 for ; Tue, 31 Aug 2021 19:01:49 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 7CC7720B9157; Tue, 31 Aug 2021 10:01:48 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7CC7720B9157 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1630429308; bh=st6tit8tcgVX6ClVnzzUr9RBr330ARTa9V5hyQszhJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nrCB3nLwgU2On0OPc9gMbG7w64m8hk9sw3hrfjIPiXUIRUy1YvoFTJ1fcjySDxuPU by1gxaOOZk67KifWT9e1YEdgwWuNmPQD2/JZyQdcb89uJ2EJzOxMh1dl0J6pOexcrq jxRJubQLV8o1wrrWS3qVB7OZ+UMidax6soGckmyA= Date: Tue, 31 Aug 2021 10:01:48 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Message-ID: <20210831170148.GB18777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-14-git-send-email-jizh@linux.microsoft.com> <20210829011812.37662dbb@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210829011812.37662dbb@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote: > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > In app/test/meson.build > > - Specify the subset of source files to compile on Windows > > - Specify the subset of tests to be enabled on Windows > > Signed-off-by: Jie Zhou > > --- > > app/test/meson.build | 859 ++++++++++++++++++++++++++----------------- > > 1 file changed, 515 insertions(+), 344 deletions(-) > > Commit messages should explain the reason for the change, > which itself is precisely described by the diff below. > For example, why these specific tests are selected? > > Please don't create two lists, it will be hard to maintain. > Since not all the libraries unit tests depend on are built on Windows yet, and not all unit tests are ported on Windows yet, what would be a proper way to have one list but only a subset of the list actually enabled on Windows? Thanks for any suggestions. > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 7240304916..1e77657510 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > [...] > > @@ -362,7 +533,7 @@ endif > > if dpdk_conf.has('RTE_EVENT_SKELETON') > > test_deps += 'event_skeleton' > > endif > > -if dpdk_conf.has('RTE_LIB_TELEMETRY') > > +if not(is_windows) and dpdk_conf.has('RTE_LIB_TELEMETRY') > > test_sources += ['test_telemetry_json.c', 'test_telemetry_data.c'] > > fast_tests += [['telemetry_json_autotest', true], ['telemetry_data_autotest', true]] > > endif > > "not" is not a function, "if not is_windows and ..." is the preferred style. Will fix in V3.