From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0443A0C56; Tue, 31 Aug 2021 19:06:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EBAF4068A; Tue, 31 Aug 2021 19:06:13 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5CFC240142 for ; Tue, 31 Aug 2021 19:06:12 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id AC78020B915A; Tue, 31 Aug 2021 10:06:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AC78020B915A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1630429571; bh=YWr3NMArUlFm1XF1kCfchyj9K942wGUhBNtuTZPfNoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kDzTFffXecqmqtjoqIsS8PuGqpqoF34XHP7vR9sRILCY5pRemCyi3NGy1OAw48yri X+/6KVmvz3e5ARSApgPHmhqPuMaNvzMmeS8xjI6in9rPnlFp/s3WfpRJ/EU1zG/Xdx JPfpEStWikOYUObzlciTM/JX8XYnry8LVRW3SSP0= Date: Tue, 31 Aug 2021 10:06:11 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Message-ID: <20210831170611.GC18777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-3-git-send-email-jizh@linux.microsoft.com> <20210829014313.57e35cd6@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210829014313.57e35cd6@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2 02/13] driver/mempool: build mempool stack on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Aug 29, 2021 at 01:43:13AM +0300, Dmitry Kozlyuk wrote: > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > mempool_autotest failed on Windows at setting the "stack" handler > > test case. Per debugging, in rte_mempool_ops_table, there are only > > 6 ring ops registered, and no "stack" ops registered which caused > > the failure of rte_mempool_set_ops_byname and thus the test failed. > > Per code investigation, the "stack" ops are registered in > > rte_mempool_stack.c: > > MEMPOOL_REGISTER_OPS(ops_stack); > > MEMPOOL_REGISTER_OPS(ops_lf_stack); > > > > The reason these two ops are not registered is because currently > > driver\mempool\stack is not build on Windows. After building stack > > on Windows, the mempool_autotest now completed as pass. > > > > Signed-off-by: Jie Zhou > > --- > > drivers/mempool/stack/meson.build | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build > > index 371cf131b1..580dde79eb 100644 > > --- a/drivers/mempool/stack/meson.build > > +++ b/drivers/mempool/stack/meson.build > > @@ -1,11 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017-2019 Intel Corporation > > > > -if is_windows > > - build = false > > - reason = 'not supported on Windows' > > -endif > > - > > sources = files('rte_mempool_stack.c') > > > > deps += ['stack'] > > 1. The title should be "mempool/stack: build on Windows". > > 2. For the description it would be sufficient to say something like > "Mempool unit test requires mempool/stack to pass, enable this driver", > because the ops registration mechanism is standard in DPDK. > > P.S. It is really the test that should skip disabled driver cases, > but mempool/ring and mempool/stack are very basic to DPDK, > so I believe just enabling the latter is OK. Will reword the title and description in V3. Thanks.