From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27C91A0C55; Tue, 31 Aug 2021 19:39:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF6514013F; Tue, 31 Aug 2021 19:39:56 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 60DA940041 for ; Tue, 31 Aug 2021 19:39:56 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id g13so370626lfj.12 for ; Tue, 31 Aug 2021 10:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=utbo9wFYUMeF+sVogvOrlZhUeTfhuZjKJ+H/gTDnId4=; b=nNeU+sAvOEY9INquDSf6uI4vlADeqxMYkA65qgxGifJHD8yCuLzhW9arReEDL8XG8y wxF9fyhRIVM0hPptqjFjUGK4kT3ZRqg6ItIfvX3w0HtyQUwZAsOdpyH8xS5FBrPMea+Z n8mpALA8LmGHrOO7rVh7deZMllBlK8hAyJmJu3fqVQ9KX/InRbs2R+8/VV4Dr0bdstWB INm0oefbN8ciptEyAnW8DAdFv1RQMmL/axQj3aMNzvq6nKY8B5SRlDsfpnuKH5k72NEy s4rqWSPUDnu8Fx0QmV+js0yQIPZmgd0SpqIVupa+8sqnCiq4LHviWODjTgA9qljgX4Hu p6tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=utbo9wFYUMeF+sVogvOrlZhUeTfhuZjKJ+H/gTDnId4=; b=kjfbJFsUDQI/kegARelBHRZkG0wSDjiK8uUS74/2d91QzEQVXTUannHfXUrn1SaupY s09WAzSzxlbFfsbUuSMoIj+24HaN2jCXkaijtPRoF3duC16+RYe/SSGxZYm8qF/jRpye uGoFTez4gUxYZG/F+KfC9FmdrQc4gnuvFqGIijh6PHUdu0JVSLFdBbTx/S7NaO8yI+bs Z3dR4Q2LU6wigsCOOeBrvro1Yx+XuvhSq5u5I1BpmQeIH6teEfTdiqRkzqf68dw2fHuz laASoKBQzau57Im28hkBFKeN2QxsrGaKkKLob7Z8nJRMUBwzIyvtMwbmk9KJfEbF9uQb S1iA== X-Gm-Message-State: AOAM530LsTNYEj/IRlAbH47gYnWXzDD/uCS73m+wwKxRooa8IXW+h+XY RS5tY1jbMsLLr4nZG9HHZWM= X-Google-Smtp-Source: ABdhPJxrfdsDauOmGUNv9k2YPn7cjOXmuLjFo7zCws/YRtulTLNANWivI0r+HrmSPIWywT5bBEDS4A== X-Received: by 2002:a05:6512:752:: with SMTP id c18mr22169687lfs.346.1630431595924; Tue, 31 Aug 2021 10:39:55 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z8sm1951994lfb.30.2021.08.31.10.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 10:39:55 -0700 (PDT) Date: Tue, 31 Aug 2021 20:39:53 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Message-ID: <20210831203953.21add8f7@sovereign> In-Reply-To: <20210831170148.GB18777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com> <1629306834-6277-14-git-send-email-jizh@linux.microsoft.com> <20210829011812.37662dbb@sovereign> <20210831170148.GB18777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-08-31 10:01 (UTC-0700), Jie Zhou: > On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote: > > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > > In app/test/meson.build > > > - Specify the subset of source files to compile on Windows > > > - Specify the subset of tests to be enabled on Windows > > > Signed-off-by: Jie Zhou > > > --- > > > app/test/meson.build | 859 ++++++++++++++++++++++++++----------------- > > > 1 file changed, 515 insertions(+), 344 deletions(-) > > > > Commit messages should explain the reason for the change, > > which itself is precisely described by the diff below. > > For example, why these specific tests are selected? > > > > Please don't create two lists, it will be hard to maintain. > > > Since not all the libraries unit tests depend on are built on Windows yet, and not all unit tests are ported on Windows yet, what would be a proper way to have one list but only a subset of the list actually enabled on Windows? Thanks for any suggestions. I would put all the common tests to the list first, then extend the list depending on the platform.