* [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
@ 2021-09-01 7:29 Mattias Rönnblom
2021-09-01 7:35 ` Mattias Rönnblom
2021-09-01 11:16 ` Kinsella, Ray
0 siblings, 2 replies; 5+ messages in thread
From: Mattias Rönnblom @ 2021-09-01 7:29 UTC (permalink / raw)
To: Ray Kinsella; +Cc: dev, Mattias Rönnblom
Remove experimental tag from rte_rand_max().
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
lib/eal/include/rte_random.h | 1 -
lib/eal/version.map | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h
index 2b30ec85c1..29f5f1325a 100644
--- a/lib/eal/include/rte_random.h
+++ b/lib/eal/include/rte_random.h
@@ -62,7 +62,6 @@ rte_rand(void);
* @return
* A pseudo-random value between 0 and (upper_bound-1).
*/
-__rte_experimental
uint64_t
rte_rand_max(uint64_t upper_bound);
diff --git a/lib/eal/version.map b/lib/eal/version.map
index beeb986adc..92caaa2bd5 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -148,6 +148,7 @@ DPDK_22 {
rte_memzone_walk;
rte_openlog_stream;
rte_rand;
+ rte_rand_max;
rte_realloc;
rte_reciprocal_value;
rte_reciprocal_value_u64;
@@ -326,7 +327,6 @@ EXPERIMENTAL {
rte_lcore_to_cpu_id;
rte_mcfg_timer_lock;
rte_mcfg_timer_unlock;
- rte_rand_max; # WINDOWS_NO_EXPORT
# added in 19.11
rte_mcfg_get_single_file_segments;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
2021-09-01 7:29 [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable Mattias Rönnblom
@ 2021-09-01 7:35 ` Mattias Rönnblom
2021-09-01 7:42 ` David Marchand
2021-09-01 11:16 ` Kinsella, Ray
1 sibling, 1 reply; 5+ messages in thread
From: Mattias Rönnblom @ 2021-09-01 7:35 UTC (permalink / raw)
To: Ray Kinsella; +Cc: dev, David Marchand
On 2021-09-01 09:29, Mattias Rönnblom wrote:
> Remove experimental tag from rte_rand_max().
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
> lib/eal/include/rte_random.h | 1 -
> lib/eal/version.map | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h
> index 2b30ec85c1..29f5f1325a 100644
> --- a/lib/eal/include/rte_random.h
> +++ b/lib/eal/include/rte_random.h
> @@ -62,7 +62,6 @@ rte_rand(void);
> * @return
> * A pseudo-random value between 0 and (upper_bound-1).
> */
> -__rte_experimental
> uint64_t
> rte_rand_max(uint64_t upper_bound);
>
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index beeb986adc..92caaa2bd5 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -148,6 +148,7 @@ DPDK_22 {
> rte_memzone_walk;
> rte_openlog_stream;
> rte_rand;
> + rte_rand_max;
> rte_realloc;
> rte_reciprocal_value;
> rte_reciprocal_value_u64;
> @@ -326,7 +327,6 @@ EXPERIMENTAL {
> rte_lcore_to_cpu_id;
> rte_mcfg_timer_lock;
> rte_mcfg_timer_unlock;
> - rte_rand_max; # WINDOWS_NO_EXPORT
Should I have kept the WINDOWS_NO_EXPORT tag?
>
> # added in 19.11
> rte_mcfg_get_single_file_segments;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
2021-09-01 7:35 ` Mattias Rönnblom
@ 2021-09-01 7:42 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-09-01 7:42 UTC (permalink / raw)
To: Mattias Rönnblom; +Cc: Ray Kinsella, dev, Dmitry Kozlyuk
On Wed, Sep 1, 2021 at 9:35 AM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> On 2021-09-01 09:29, Mattias Rönnblom wrote:
> > Remove experimental tag from rte_rand_max().
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > ---
> > lib/eal/include/rte_random.h | 1 -
> > lib/eal/version.map | 2 +-
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h
> > index 2b30ec85c1..29f5f1325a 100644
> > --- a/lib/eal/include/rte_random.h
> > +++ b/lib/eal/include/rte_random.h
> > @@ -62,7 +62,6 @@ rte_rand(void);
> > * @return
> > * A pseudo-random value between 0 and (upper_bound-1).
> > */
> > -__rte_experimental
> > uint64_t
> > rte_rand_max(uint64_t upper_bound);
> >
> > diff --git a/lib/eal/version.map b/lib/eal/version.map
> > index beeb986adc..92caaa2bd5 100644
> > --- a/lib/eal/version.map
> > +++ b/lib/eal/version.map
> > @@ -148,6 +148,7 @@ DPDK_22 {
> > rte_memzone_walk;
> > rte_openlog_stream;
> > rte_rand;
> > + rte_rand_max;
> > rte_realloc;
> > rte_reciprocal_value;
> > rte_reciprocal_value_u64;
> > @@ -326,7 +327,6 @@ EXPERIMENTAL {
> > rte_lcore_to_cpu_id;
> > rte_mcfg_timer_lock;
> > rte_mcfg_timer_unlock;
> > - rte_rand_max; # WINDOWS_NO_EXPORT
>
>
> Should I have kept the WINDOWS_NO_EXPORT tag?
Strictly speaking, you should keep it: this patch is about API promotion.
The windows exports are fixed in another patch in any case:
https://patchwork.dpdk.org/project/dpdk/patch/20210829021602.290466-3-dmitry.kozliuk@gmail.com/
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
2021-09-01 7:29 [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable Mattias Rönnblom
2021-09-01 7:35 ` Mattias Rönnblom
@ 2021-09-01 11:16 ` Kinsella, Ray
2021-10-02 8:23 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: Kinsella, Ray @ 2021-09-01 11:16 UTC (permalink / raw)
To: Mattias Rönnblom; +Cc: dev
On 01/09/2021 08:29, Mattias Rönnblom wrote:
> Remove experimental tag from rte_rand_max().
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
2021-09-01 11:16 ` Kinsella, Ray
@ 2021-10-02 8:23 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-10-02 8:23 UTC (permalink / raw)
To: Mattias Rönnblom; +Cc: dev, Kinsella, Ray
On Wed, Sep 1, 2021 at 1:17 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
> On 01/09/2021 08:29, Mattias Rönnblom wrote:
> > Remove experimental tag from rte_rand_max().
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-02 8:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 7:29 [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable Mattias Rönnblom
2021-09-01 7:35 ` Mattias Rönnblom
2021-09-01 7:42 ` David Marchand
2021-09-01 11:16 ` Kinsella, Ray
2021-10-02 8:23 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).