* [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments
@ 2021-09-01 9:38 Conor Walsh
2021-09-01 9:59 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Conor Walsh @ 2021-09-01 9:38 UTC (permalink / raw)
To: bruce.richardson, ciara.power, keith.wiles
Cc: dev, Conor Walsh, Zhihong Peng, Conor Fogarty
This patch fixes a memleak which was reported in Bugzilla within the
eal_save_args function. This was caused by the function mistakenly
adding -- to the eal args instead of breaking beforehand.
Bugzilla ID: 722
Fixes: 293c53d8b23c ("eal: add telemetry callbacks")
Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Signed-off-by: Conor Fogarty <conor.fogarty@intel.com>
---
lib/eal/common/eal_common_options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index ff5861b5f3..bee716a714 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -229,9 +229,9 @@ eal_save_args(int argc, char **argv)
return -1;
for (i = 0; i < argc; i++) {
- eal_args[i] = strdup(argv[i]);
if (strcmp(argv[i], "--") == 0)
break;
+ eal_args[i] = strdup(argv[i]);
}
eal_args[i++] = NULL; /* always finish with NULL */
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments
2021-09-01 9:38 [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments Conor Walsh
@ 2021-09-01 9:59 ` Bruce Richardson
2021-09-16 20:22 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2021-09-01 9:59 UTC (permalink / raw)
To: Conor Walsh; +Cc: ciara.power, keith.wiles, dev, Zhihong Peng, Conor Fogarty
On Wed, Sep 01, 2021 at 09:38:47AM +0000, Conor Walsh wrote:
> This patch fixes a memleak which was reported in Bugzilla within the
> eal_save_args function. This was caused by the function mistakenly
> adding -- to the eal args instead of breaking beforehand.
>
> Bugzilla ID: 722
> Fixes: 293c53d8b23c ("eal: add telemetry callbacks")
>
> Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> Signed-off-by: Conor Fogarty <conor.fogarty@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments
2021-09-01 9:59 ` Bruce Richardson
@ 2021-09-16 20:22 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-09-16 20:22 UTC (permalink / raw)
To: Conor Walsh
Cc: Bruce Richardson, Ciara Power, Wiles, Keith, dev, Zhihong Peng,
Conor Fogarty
On Wed, Sep 1, 2021 at 11:59 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Sep 01, 2021 at 09:38:47AM +0000, Conor Walsh wrote:
> > This patch fixes a memleak which was reported in Bugzilla within the
> > eal_save_args function. This was caused by the function mistakenly
> > adding -- to the eal args instead of breaking beforehand.
> >
> > Bugzilla ID: 722
> > Fixes: 293c53d8b23c ("eal: add telemetry callbacks")
> >
> > Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
> > Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> > Signed-off-by: Conor Fogarty <conor.fogarty@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-16 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 9:38 [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments Conor Walsh
2021-09-01 9:59 ` Bruce Richardson
2021-09-16 20:22 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).