* [dpdk-dev] [PATCH v1] net/iavf: fix QFI fields of GTPU UL and DL for FDIR
@ 2021-09-01 16:47 Lingyu Liu
2021-09-13 15:34 ` [dpdk-dev] [PATCH v2] " Lingyu Liu
0 siblings, 1 reply; 3+ messages in thread
From: Lingyu Liu @ 2021-09-01 16:47 UTC (permalink / raw)
To: dev, qi.z.zhang, beilei.xing, jingjing.wu; +Cc: junfeng.guo, Lingyu Liu, stable
Fix QFI fields matching of GTPU UL/DL for FDIR.
Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director")
Cc: stable@dpdk.org
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
---
drivers/net/iavf/iavf_fdir.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index 32b06044f2..134f887965 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1171,7 +1171,12 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
if (gtp_psc_spec && gtp_psc_mask) {
if (gtp_psc_mask->qfi == UINT8_MAX) {
input_set |= IAVF_INSET_GTPU_QFI;
- VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_EH, QFI);
+ if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_UPLINK)
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_UP, QFI);
+ else if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_DWLINK)
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_DWN, QFI);
+ else
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_EH, QFI);
}
rte_memcpy(hdr->buffer, gtp_psc_spec,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v2] net/iavf: fix QFI fields of GTPU UL and DL for FDIR
2021-09-01 16:47 [dpdk-dev] [PATCH v1] net/iavf: fix QFI fields of GTPU UL and DL for FDIR Lingyu Liu
@ 2021-09-13 15:34 ` Lingyu Liu
2021-09-22 7:14 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Lingyu Liu @ 2021-09-13 15:34 UTC (permalink / raw)
To: dev, qi.z.zhang, beilei.xing, jingjing.wu; +Cc: Lingyu Liu, stable, Junfeng Guo
Fix QFI fields matching of GTPU UL/DL for FDIR.
Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director")
Cc: stable@dpdk.org
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
---
V2:
* Fix coding style issue
---
drivers/net/iavf/iavf_fdir.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index 32b06044f2..560589a496 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1171,7 +1171,17 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
if (gtp_psc_spec && gtp_psc_mask) {
if (gtp_psc_mask->qfi == UINT8_MAX) {
input_set |= IAVF_INSET_GTPU_QFI;
- VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_EH, QFI);
+ if (gtp_psc_spec->pdu_type ==
+ IAVF_GTPU_EH_UPLINK)
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
+ GTPU_UP, QFI);
+ else if (gtp_psc_spec->pdu_type ==
+ IAVF_GTPU_EH_DWLINK)
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
+ GTPU_DWN, QFI);
+ else
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
+ GTPU_EH, QFI);
}
rte_memcpy(hdr->buffer, gtp_psc_spec,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/iavf: fix QFI fields of GTPU UL and DL for FDIR
2021-09-13 15:34 ` [dpdk-dev] [PATCH v2] " Lingyu Liu
@ 2021-09-22 7:14 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-09-22 7:14 UTC (permalink / raw)
To: Liu, Lingyu, dev, Xing, Beilei, Wu, Jingjing; +Cc: stable, Guo, Junfeng
> -----Original Message-----
> From: Liu, Lingyu <lingyu.liu@intel.com>
> Sent: Monday, September 13, 2021 11:34 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Liu, Lingyu <lingyu.liu@intel.com>; stable@dpdk.org; Guo, Junfeng
> <junfeng.guo@intel.com>
> Subject: [PATCH v2] net/iavf: fix QFI fields of GTPU UL and DL for FDIR
>
> Fix QFI fields matching of GTPU UL/DL for FDIR.
>
> Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director")
> Cc: stable@dpdk.org
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-22 7:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 16:47 [dpdk-dev] [PATCH v1] net/iavf: fix QFI fields of GTPU UL and DL for FDIR Lingyu Liu
2021-09-13 15:34 ` [dpdk-dev] [PATCH v2] " Lingyu Liu
2021-09-22 7:14 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).