Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 2 Sep 2021 16:50:14 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote:
> > On Thu, 2 Sep 2021 09:10:47 +0100
> > Bruce Richardson <bruce.richardson@intel.com> wrote:
> >   
> > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote:  
> > > > This fixes most of the warnings from the Flake8 style checker.
> > > > The ones remaing are long lines (we allow > 79 characters)
> > > > and a line break warning.  The line break style changed in later
> > > > versions of PEP 8 and the tool is not updated.
> > > > 
> > > > https://www.flake8rules.com/rules/W503.html
> > > > 
> > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > ---
> > > >  usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++-----------------
> > > >  1 file changed, 39 insertions(+), 31 deletions(-)
> > > >    
> > > Thanks for the cleanup.
> > > 
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>   
> > 
> > I don't use devbind (except in artifical testing), could someone with
> > hardware make sure that nothing changed here.  
> 
> I didn't go testing with all possible options and inputs, but basic
> operation for binding unbinding devices and giving error messages for
> invalid device names works fine with this patch applied.
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks