From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74299A0C54; Fri, 3 Sep 2021 16:23:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64044410D8; Fri, 3 Sep 2021 16:23:11 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by mails.dpdk.org (Postfix) with ESMTP id CCF03410D7 for ; Fri, 3 Sep 2021 16:23:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlgYR/1KA5fHJS5sgAaasH0mklH71Aual+1BIC8+UFVXmnoGh8eoTzrsX5054Biq2dnrKM+blmvVAjTYZJFJayVT6NyC+n74IdTGpQof3fkfEz/eQaP6ydkTU1HHbal7TWaKXKutGp2PvhaBrJnjVfEzRt1jRLaQi8+2fgbDQhNM7w3Nz2aZ/DQCSbsbrQB8uXIWUSlcjo3gmfJvjtDVjdEfWOTnxTgYPYkeBWEPx7F+bQocervwkijHDgZt8BF2Vig87t0WvoT3Feo0lVRRgC8e1cZbdizib/CDGIDCguuzritkUXEt9oeSLc5mNIiPBMZDLtDttBmZ18WgCYwGuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHV72ZgZS1zHkTBj5OpPxA2CdVyhuPNlRf2MzupKGGI=; b=Ui0BXZeU0z77Q8WwNa6lLd4XgZ5RgDSxTR0S803z5rU/WqIJrEhLg9UZ7MW5eQHfw6WVoKdt7GwnFkWBaWkfsEcQHYWRSWNOe8Bz9PgPU/rtJqGvT0MA+uePK5TXqbDhKuSAg1J+SMtTLKabbf3p9/rUKqjOY0veQdjeNSnAVooxSrnBPMVOOBYQrhLVy39x5KH8v3OqygvGmZ5UaRgRq1GUDjiV59Os+oknFZf15b+K9dXVMeUXy3h9gR8Eu6QbaCd57qpEyZ96ch5aZGG+sH8omxDPGjWBexz6RUcBbhCM/Iy7RVH+ALWx8/yZKTispigez8uM8zIuCodtnFQtQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHV72ZgZS1zHkTBj5OpPxA2CdVyhuPNlRf2MzupKGGI=; b=H8Ylq7Ur/qHmpKldj2KR3MO5mdkdFPpg5/lsS0kC/41Jc1W6bI0enaRHBCT7MBDCXw/wtOvFUl6VshbrHdKZoxKHu36qSY1ZuGGKKHys2FM76Vktd2H/rRL4+Id3Mpe5XUMX2/OpCuzYDCdFsCo94GleuoTGpxFEVjiFvdlRa9AfipIj1FwGiocUSeIJIymKvcHYmzUFAcGegzq2/Z/kFNEmiet8CbvF2dseQEHvuhlc4tXgGlcJIhPpZg3QZGNEu/avrHpviKRDAMFKhIYAZgKFTkn5zbiNikgfYRyeTAglvNRqIduRvQJTVvfiRhCFzW9PdWRhcBtfivLwBzTQPg== Received: from DM6PR11CA0044.namprd11.prod.outlook.com (2603:10b6:5:14c::21) by MN2PR12MB3037.namprd12.prod.outlook.com (2603:10b6:208:c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Fri, 3 Sep 2021 14:23:08 +0000 Received: from DM6NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::ff) by DM6PR11CA0044.outlook.office365.com (2603:10b6:5:14c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 14:23:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT015.mail.protection.outlook.com (10.13.172.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 14:23:07 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 3 Sep 2021 14:23:05 +0000 From: Raja Zidane To: Date: Fri, 3 Sep 2021 14:22:48 +0000 Message-ID: <20210903142248.25710-1-rzidane@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2ac539e-874f-43b2-b181-08d96ee659b4 X-MS-TrafficTypeDiagnostic: MN2PR12MB3037: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8vPTK3MpsOCFgeo5R8w4p+WkQSLqoQuYUSGQkY1dc8HgyV9BFl/43jF/2UXrxZrNoqECYEWCmeRgkQQ4p9KrsNb4gsLnuKTqpKgKoKvyVC54DnnmCPnwND68QH+JvdWkQc09Wyz3P6NAOUGuP53OXoHJtSVEW3hf8X8ti7s4usVFakTCwkXbRsV4WyWolxXJTRGbrvDFCr6bIvMye7lztIkvlqhBf/xTnbNjsXlY+a3w020dDwZeXtWG/ErLEa2EDo4sy0oq74puRVRP848rq00BI07hu3J4nBOGx2FW1g5Z8EmmltDP6TPtmQrd8ogryFaBRVevh7Dvemqy9NTIKHrwVsrST5pn9Go5aXyXnrHmFFg6N/ec/01QIZU22OOqSeodxlggldY+FckDH0bgLT+MOKKJikJooYBEuPBd0NZfna1lz9Ps5ItGa/aBWvyzbdPD8GKLR4rcUc89T96CqFI3bPZ10Rv+5vbAeTOtm7oZ01QNDpc1Cr057HYXkWnAJiIZPcwCR7l7Apa52GnH/yC366PAnWvbqLcQKrFe5EGdkNE68dtBSCWG/CuM9zMQiwgxUYmmQWQjIQYjLFK83ZDNRNu1jkJLWweUHpNAzl7ZHWtKA9s/glpVsPYMMmdZYjsICbykH9aKhPtSzM9wmh5zlR/KhKhj+4rM2B9LD67RHPdPEXD0MFSVpYS47eSq4mCfnfTzU5bks4h3Ka+Tnw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(36840700001)(46966006)(26005)(83380400001)(86362001)(8676002)(316002)(336012)(426003)(55016002)(16526019)(5660300002)(36756003)(36860700001)(1076003)(47076005)(8936002)(186003)(70586007)(478600001)(7696005)(6286002)(2616005)(2906002)(7636003)(82740400003)(6666004)(6916009)(70206006)(82310400003)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 14:23:07.4934 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e2ac539e-874f-43b2-b181-08d96ee659b4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3037 Subject: [dpdk-dev] [PATCH] compress/mlx5: allow partial transformations support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently compress, decompress and dma are allowed only when all 3 capabilities are on. A case where the user wants decompress offload, if decompress capability is on but one of compress, dma is off, is not allowed. Split compress/decompress/dma support check to allow partial transformations. Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 65 ++++++++++++++++++++------- 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index d65e1e14da..58e6a7cf8d 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -291,17 +291,46 @@ mlx5_compress_xform_create(struct rte_compressdev *dev, struct mlx5_compress_xform *xfrm; uint32_t size; - if (xform->type == RTE_COMP_COMPRESS && xform->compress.level == - RTE_COMP_LEVEL_NONE) { - DRV_LOG(ERR, "Non-compressed block is not supported."); - return -ENOTSUP; - } - if ((xform->type == RTE_COMP_COMPRESS && xform->compress.hash_algo != - RTE_COMP_HASH_ALGO_NONE) || (xform->type == RTE_COMP_DECOMPRESS && - xform->decompress.hash_algo != RTE_COMP_HASH_ALGO_NONE)) { - DRV_LOG(ERR, "SHA is not supported."); - return -ENOTSUP; + switch(xform->type) { + case RTE_COMP_COMPRESS: + if(xform->compress.algo == RTE_COMP_ALGO_NULL && + !priv->mmo_dma_qp && !priv->mmo_dma_sq) { + DRV_LOG(ERR, "Not enough capabilities to support DMA operation, maybe old FW/OFED version?"); + return -ENOTSUP; + } + else if(!priv->mmo_comp_qp && !priv->mmo_comp_sq) { + DRV_LOG(ERR, "Not enough capabilities to support compress operation, maybe old FW/OFED version?"); + return -ENOTSUP; + } + if(xform->compress.level == RTE_COMP_LEVEL_NONE) { + DRV_LOG(ERR, "Non-compressed block is not supported."); + return -ENOTSUP; + } + if(xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { + DRV_LOG(ERR, "SHA is not supported."); + return -ENOTSUP; + } + break; + case RTE_COMP_DECOMPRESS: + if(xform->decompress.algo == RTE_COMP_ALGO_NULL && + !priv->mmo_dma_qp && !priv->mmo_dma_sq) { + DRV_LOG(ERR, "Not enough capabilities to support DMA operation, maybe old FW/OFED version?"); + return -ENOTSUP; + } + else if(!priv->mmo_decomp_qp && !priv->mmo_decomp_sq) { + DRV_LOG(ERR, "Not enough capabilities to support decompress operation, maybe old FW/OFED version?"); + return -ENOTSUP; + } + if(xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { + DRV_LOG(ERR, "SHA is not supported."); + return -ENOTSUP; + } + break; + default: + DRV_LOG(ERR, "Xform type should be compress/decompress"); + return -ENOTSUP; } + xfrm = rte_zmalloc_socket(__func__, sizeof(*xfrm), 0, priv->dev_config.socket_id); if (xfrm == NULL) @@ -816,12 +845,16 @@ mlx5_compress_dev_probe(struct rte_device *dev) rte_errno = ENODEV; return -rte_errno; } - if (mlx5_devx_cmd_query_hca_attr(ctx, &att) != 0 || - ((att.mmo_compress_sq_en == 0 || att.mmo_decompress_sq_en == 0 || - att.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 || - att.mmo_decompress_qp_en == 0 || att.mmo_dma_qp_en == 0))) { - DRV_LOG(ERR, "Not enough capabilities to support compress " - "operations, maybe old FW/OFED version?"); + if (mlx5_devx_cmd_query_hca_attr(ctx, &att) != 0) { + DRV_LOG(ERR, "Failed to query device capabilities"); + claim_zero(mlx5_glue->close_device(ctx)); + rte_errno = ENOTSUP; + return -ENOTSUP; + } + if(!att.mmo_decompress_qp_en && !att.mmo_decompress_sq_en + && !att.mmo_compress_qp_en && !att.mmo_compress_sq_en + && !att.mmo_dma_qp_en && !att.mmo_dma_sq_en) { + DRV_LOG(ERR, "Not enough capabilities to support compress operations, maybe old FW/OFED version?"); claim_zero(mlx5_glue->close_device(ctx)); rte_errno = ENOTSUP; return -ENOTSUP; -- 2.17.1