* [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset
@ 2021-09-06 7:07 Qiming Chen
2021-09-06 9:37 ` [dpdk-dev] [dpdk-stable] " David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Qiming Chen @ 2021-09-06 7:07 UTC (permalink / raw)
To: dev; +Cc: beilei.xing, Qiming Chen, stable
In the embedded RTOS environment, the x722 controller Ethernet card of
the d2146nt chip, the vfio user mode driver takes over 8 vf ports in
turn, but i40evf_check_vf_reset_done will probably fail.
This issue has been discussed with intel&dpdk experts for 3 rounds
before, and the version matching is no problem, and there is no
substantial progress. The official website contacted external experts,
but there was no response afterwards. Learning from the implementation
of the i40evf kernel driver locally, after modifying the polling time
from 1 second to 5s, the repeated restart process took over the start
port test, and it was found that this probability was reduced to an
order of magnitude acceptable to the user.
The patch cannot fundamentally solve the failure problem, but it greatly
slows down the probability of the problem. The modification is based on the
i40evf kernel driver.
Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Cc: stable@dpdk.org
Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f64db72e9a..924da8dfb4 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -42,7 +42,7 @@
/* busy wait delay in msec */
#define I40EVF_BUSY_WAIT_DELAY 10
#define I40EVF_BUSY_WAIT_COUNT 50
-#define MAX_RESET_WAIT_CNT 20
+#define MAX_RESET_WAIT_CNT 100
#define I40EVF_ALARM_INTERVAL 50000 /* us */
--
2.30.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: extend the polling times of vf reset
2021-09-06 7:07 [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset Qiming Chen
@ 2021-09-06 9:37 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2021-09-06 9:37 UTC (permalink / raw)
To: Qiming Chen
Cc: dev, Beilei Xing, dpdk stable, Qiming Yang, Qi Zhang,
Jingjing Wu, Yigit, Ferruh
On Mon, Sep 6, 2021 at 9:08 AM Qiming Chen <chenqiming_huawei@163.com> wrote:
>
> In the embedded RTOS environment, the x722 controller Ethernet card of
> the d2146nt chip, the vfio user mode driver takes over 8 vf ports in
> turn, but i40evf_check_vf_reset_done will probably fail.
>
> This issue has been discussed with intel&dpdk experts for 3 rounds
> before, and the version matching is no problem, and there is no
> substantial progress. The official website contacted external experts,
> but there was no response afterwards. Learning from the implementation
> of the i40evf kernel driver locally, after modifying the polling time
> from 1 second to 5s, the repeated restart process took over the start
> port test, and it was found that this probability was reduced to an
> order of magnitude acceptable to the user.
>
> The patch cannot fundamentally solve the failure problem, but it greatly
> slows down the probability of the problem. The modification is based on the
> i40evf kernel driver.
>
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
This Fixes: is not the right one as this commit only moved code around.
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index f64db72e9a..924da8dfb4 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -42,7 +42,7 @@
> /* busy wait delay in msec */
> #define I40EVF_BUSY_WAIT_DELAY 10
> #define I40EVF_BUSY_WAIT_COUNT 50
> -#define MAX_RESET_WAIT_CNT 20
> +#define MAX_RESET_WAIT_CNT 100
Copying more Intel maintainers.
This mechanism is common to various Intel hw/drivers.
Does this issue only affect i40e hw or should we also consider the
issue with other hw/drivers?
drivers/net/i40e/i40e_ethdev_vf.c:#define MAX_RESET_WAIT_CNT 20
drivers/net/i40e/i40e_ethdev_vf.c: for (i = 0; i <
MAX_RESET_WAIT_CNT; i++) {
drivers/net/i40e/i40e_ethdev_vf.c: if (i >= MAX_RESET_WAIT_CNT)
drivers/net/iavf/iavf.h:#define IAVF_RESET_WAIT_CNT 50
drivers/net/iavf/iavf_ethdev.c: for (i = 0; i < IAVF_RESET_WAIT_CNT; i++) {
drivers/net/iavf/iavf_ethdev.c: if (i >= IAVF_RESET_WAIT_CNT)
drivers/net/ice/ice_dcf.c:#define ICE_DCF_RESET_WAIT_CNT 50
drivers/net/ice/ice_dcf.c: for (i = 0; i < ICE_DCF_RESET_WAIT_CNT; i++) {
drivers/net/ice/ice_dcf.c: if (i >= ICE_DCF_RESET_WAIT_CNT)
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset
@ 2021-08-23 3:46 Qiming Chen
2021-09-06 1:56 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Qiming Chen @ 2021-08-23 3:46 UTC (permalink / raw)
To: dev; +Cc: beilei.xing, Qiming Chen
In the embedded RTOS environment, the x722 controller Ethernet card of
the d2146nt chip, the vfio user mode driver takes over 8 vf ports in
turn, but i40evf_check_vf_reset_done will probably fail.
This issue has been discussed with intel&dpdk experts for 3 rounds
before, and the version matching is no problem, and there is no
substantial progress. The official website contacted external experts,
but there was no response afterwards. Learning from the implementation
of the i40evf kernel driver locally, after modifying the polling time
from 1 second to 5s, the repeated restart process took over the start
port test, and it was found that this probability was reduced to an
order of magnitude acceptable to the user.
The patch cannot fundamentally solve the failure problem, but it greatly
slows down the probability of the problem. The modification is based on the
i40evf kernel driver.
Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f64db72e9a..924da8dfb4 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -42,7 +42,7 @@
/* busy wait delay in msec */
#define I40EVF_BUSY_WAIT_DELAY 10
#define I40EVF_BUSY_WAIT_COUNT 50
-#define MAX_RESET_WAIT_CNT 20
+#define MAX_RESET_WAIT_CNT 100
#define I40EVF_ALARM_INTERVAL 50000 /* us */
--
2.30.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset
2021-08-23 3:46 [dpdk-dev] " Qiming Chen
@ 2021-09-06 1:56 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2021-09-06 1:56 UTC (permalink / raw)
To: Qiming Chen, dev; +Cc: Xing, Beilei
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qiming Chen
> Sent: Monday, August 23, 2021 11:46 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> <chenqiming_huawei@163.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset
>
> In the embedded RTOS environment, the x722 controller Ethernet card of the
> d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but
> i40evf_check_vf_reset_done will probably fail.
>
> This issue has been discussed with intel&dpdk experts for 3 rounds before, and
> the version matching is no problem, and there is no substantial progress. The
> official website contacted external experts, but there was no response
> afterwards. Learning from the implementation of the i40evf kernel driver locally,
> after modifying the polling time from 1 second to 5s, the repeated restart
> process took over the start port test, and it was found that this probability was
> reduced to an order of magnitude acceptable to the user.
>
> The patch cannot fundamentally solve the failure problem, but it greatly slows
> down the probability of the problem. The modification is based on the i40evf
> kernel driver.
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f64db72e9a..924da8dfb4 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -42,7 +42,7 @@
> /* busy wait delay in msec */
> #define I40EVF_BUSY_WAIT_DELAY 10
> #define I40EVF_BUSY_WAIT_COUNT 50
> -#define MAX_RESET_WAIT_CNT 20
> +#define MAX_RESET_WAIT_CNT 100
>
> #define I40EVF_ALARM_INTERVAL 50000 /* us */
>
> --
> 2.30.1.windows.1
The patch is not applied for main repo as i40evf will be removed, you can submit a fix to dpdk-stable directly.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-06 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 7:07 [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset Qiming Chen
2021-09-06 9:37 ` [dpdk-dev] [dpdk-stable] " David Marchand
-- strict thread matches above, loose matches on Subject: below --
2021-08-23 3:46 [dpdk-dev] " Qiming Chen
2021-09-06 1:56 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).