From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2476A0C47; Tue, 7 Sep 2021 21:14:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8163A410ED; Tue, 7 Sep 2021 21:14:58 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id C9FE1410EB for ; Tue, 7 Sep 2021 21:14:56 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d17so6438204plr.12 for ; Tue, 07 Sep 2021 12:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Dqxm4QaZn6MroxoDEsYN7C528JPswvcS7MN6F5NCYs=; b=I/SJZ6s5TsRDPfvraNkb86Z40hTRuHnlz2KNspdLaHd5giIU7ptFtlVjEFftZQETda gFdBKn/PeTREXFxBmrJddMpuLvKNeZ7BPhNrCohaCoRSKIZtj525PvMIFWFxmqg8VUqw AsY8XnZG5AMRqmUstvW/8UAiunq4Fsi2bbhdiJ51pUfw+lls9brDz7Rrb/H2g1m31zbm l1mYUR5zkrH8e9G5Fqje6ZPOVV1Pne+lmShI0NbF+27r69BEC2PIOehp5ASB42XXN+QU 0qKHOqCwDLvPydfauQtAeeo51ZG4BZaVpocmyFFGKiQvtkmu3WDGyndv8R0nc7ukZmGU E3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Dqxm4QaZn6MroxoDEsYN7C528JPswvcS7MN6F5NCYs=; b=Ze3KWIHOX/g0PDzMsCIvOx/fMIO3jSuf5zyMRfQg5L099hsgKdakwm/rfVS4TEHqsJ qvAmFe1AVo7QxdXLKiKTPSv4a08MCbZcOWGl+NQQszyHJcjGgkc0pf0IBqXOuqhYvc1D sSaXAmEsN6j7e7OGIN3INdP0Q0gBTVja4nRAfw1ZLcVudbyJT3+7B7jFf0YR3Qe4R4r5 y2jV+4+z2k4lGexdfia8Q5o4nwoAc+/42No58viIECkCJms7ldRsZ8umZC4n4jzWih/g zUP4rMD3+WS5xEsQYX/PT2fvQML7ah5yAaPAYGJ8MS3BTTm+M2YV84riY2wPIZHqfHSR z/fw== X-Gm-Message-State: AOAM533xaTPJlVfyuTjs1h1PL/FdiWG03w/aY3fRpOd7HbVFU8fpvZm2 TpxkcCPgUZqjHmqAEvCCkz0OAQ== X-Google-Smtp-Source: ABdhPJw4YzaConsnR+rMrNwZ2mKDhuT1TTKuRnWZsLy7dCtCvSUm9RXFJBM2ApzuJvgcThoCPhIAaQ== X-Received: by 2002:a17:902:7e4d:b0:13a:8f:42d4 with SMTP id a13-20020a1709027e4d00b0013a008f42d4mr16232545pln.62.1631042096017; Tue, 07 Sep 2021 12:14:56 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id g4sm3147479pjt.56.2021.09.07.12.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 12:14:55 -0700 (PDT) Date: Tue, 7 Sep 2021 12:14:52 -0700 From: Stephen Hemminger To: "Liguzinski, WojciechX" Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, megha.ajmera@intel.com Message-ID: <20210907121452.3788c935@hermes.local> In-Reply-To: <20210907073328.1498973-2-wojciechx.liguzinski@intel.com> References: <20210705080421.18736-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-2-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 7 Sep 2021 07:33:24 +0000 "Liguzinski, WojciechX" wrote: > +/** > + * @brief make a decision to drop or enqueue a packet based on probability > + * criteria > + * > + * @param pie_cfg [in] config pointer to a PIE configuration parameter structure > + * @param pie [in, out] data pointer to PIE runtime data > + * @param time [in] current time (measured in cpu cycles) > + */ > +static inline void > +__rte_experimental > +_calc_drop_probability(const struct rte_pie_config *pie_cfg, > + struct rte_pie *pie, uint64_t time) This code adds a lot of inline functions in the name of performance. But every inline like this means the internal ABI for the implmentation has to be exposed. You would probably get a bigger performance bump from not using floating point in the internal math, than the minor performance optimization from having so many inlines.