From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Chen <chenqiming_huawei@163.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] net/pcap: improve rx statistics
Date: Wed, 8 Sep 2021 20:29:59 -0700 [thread overview]
Message-ID: <20210908202959.2099eb1e@hermes.local> (raw)
In-Reply-To: <20210909024531.10009-1-chenqiming_huawei@163.com>
On Thu, 9 Sep 2021 10:45:31 +0800
Qiming Chen <chenqiming_huawei@163.com> wrote:
> In the receiving direction, if alloc mbuf or jumbo process failed, there
> is no err_pkts count, which makes it difficult to locate the problem.
> Because alloc mbuf failed, the rx_nombuf field is counted.
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> v2:
> Clear coding style issues.
> v3:
> 1) Send direction does not release mbuf.
> 2) Failed to alloc mbuf is counted to the rx_nombuf field.
Looks good, the field "err_pkts" is a confusing name for me.
On Tx it means packets dropped because pcap_sendpacket() returned error.
Looking inside libpcap that means send() failed. On Linux this is
a send on a PF_PACKET socket and it appears to be a blocking socket().
So these errors are not transient conditions.
On Rx it means packets dropped because out of mbufs.
Perhaps a comment or renaming the field would helped.
next prev parent reply other threads:[~2021-09-09 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 3:16 [dpdk-dev] [PATCH] net/pcap: improve rxtx statistics Qiming Chen
2021-08-26 3:23 ` [dpdk-dev] [PATCH v2] " Qiming Chen
2021-09-08 12:29 ` Ferruh Yigit
2021-09-09 2:45 ` [dpdk-dev] [PATCH v3] net/pcap: improve rx statistics Qiming Chen
2021-09-09 3:29 ` Stephen Hemminger [this message]
2021-09-09 10:20 ` Ferruh Yigit
2021-09-09 4:16 ` [dpdk-dev] [PATCH v4] " Qiming Chen
2021-09-09 8:05 ` Ferruh Yigit
2021-09-09 8:23 ` [dpdk-dev] [PATCH v5] " Qiming Chen
2021-09-09 10:20 ` Ferruh Yigit
2021-09-09 12:28 ` [dpdk-dev] [PATCH v6] " Qiming Chen
2021-09-09 14:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908202959.2099eb1e@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenqiming_huawei@163.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).