From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2666EA0548; Fri, 10 Sep 2021 04:48:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97755406B4; Fri, 10 Sep 2021 04:48:01 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 731224013F for ; Fri, 10 Sep 2021 04:48:00 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id u11-20020a17090adb4b00b00181668a56d6so450684pjx.5 for ; Thu, 09 Sep 2021 19:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YpgByDmgT0HGhKp185FzC5aCiLGi5xhgS9UiCV/tThc=; b=n4UgUiwfpVV/zNxZTHs4koPS3x2UzMBV7P+SdRFOxFaDS7P80lvhQYMrfSXnhNlrKv 05wizn35gTFAJuAg9RBICMHS0aWDrsu4mvpI4yF7tjFZyZBTC4AYygSgiQO1PZB8+6Fd Gn/x0Yq9uPe9HTRqpTgWuhAdx2mIu7DlzZLi8WX7oqn0qY4mw63PZ3eNq1LGMXG6Iqo3 UAXU2nUf4rU0nzibmML7I/H+BNXFv2bmWwqUpd2WI8TnAimCiDTMxLNJu8pYaeSvTeKa UXecNepqdlPezP9u02JPCAyio1uJIfXz5JCEaSACJfwfvgDfOOloeOavW/OxqYpCT9af IAmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YpgByDmgT0HGhKp185FzC5aCiLGi5xhgS9UiCV/tThc=; b=a3xZ0Siewth6YIYV7cmRfSHwTEwqbD4RdDzeG19FhKa/uJsaHHVZ9FFYGK0KwtKB9x /lVhtQ5lgiri6w4s1QtzL5duelTT9InN1HNMYqqNXaLZyIN6ZFhHilUQ0kJ4Pb9qF3jm wtlC8Bsf565tbObOnKrw4cwJWczNdfvvtMPIEw6PtlaHTFkEYYDdfbkltkuUOKXCaBqW WBdTtCF17lMakI6zamnCjI77/t+qd+hWQhUyTpfl+Dv8sruB+w/q1FHnpB8Ep5wQ4JAk JV0bU6VjEU+PdDLbgCdcS4hTVAtrAYgBwq62ClMrbhE7aG5Y65RLGe5tIkYalqc86Hzh aaRQ== X-Gm-Message-State: AOAM5330kwyItG2CT99/UJwwJJD7iJWo1+2P7I+ySZ/zS/0iDlEmEGrB fegPsAhDhwR0KBrTUrLiicTJ9w== X-Google-Smtp-Source: ABdhPJyXjZ6L/qc9MHqCzMa9lvx9QQ7miUCZyRTpP8z/uTJACbRlY8dFM5HzHca+fp8kVxE/oX3tLA== X-Received: by 2002:a17:903:2343:b0:13a:8c8:a2af with SMTP id c3-20020a170903234300b0013a08c8a2afmr5487981plh.86.1631242079327; Thu, 09 Sep 2021 19:47:59 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id i24sm3628183pfo.13.2021.09.09.19.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 19:47:59 -0700 (PDT) Date: Thu, 9 Sep 2021 19:47:56 -0700 From: Stephen Hemminger To: zhihongx.peng@intel.com Cc: anatoly.burakov@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, xueqin.lin@intel.com Message-ID: <20210909194756.6addfe73@hermes.local> In-Reply-To: <20210910020147.148019-1-zhihongx.peng@intel.com> References: <20210910020147.148019-1-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 10 Sep 2021 02:01:47 +0000 zhihongx.peng@intel.com wrote: > > +if get_option('b_sanitize').startswith('address') > + cflags += '-DRTE_MALLOC_ASAN' > +endif > + This looks great, but can we make it just do-the-right-thing and get rid of the nerd knobs (i.e no meson configure). The address sanitizer already has a way to detect if enabled. GCC uses: __SANITIZE_ADDRESS__ Clang uses: #if defined(__has_feature) # if __has_feature(address_sanitizer)