From: Stephen Hemminger <stephen@networkplumber.org>
To: usamanadeem321 <usama.nadeem@emumba.com>
Cc: thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: ipv4, udp and tcp checksum offload warning
Date: Mon, 13 Sep 2021 08:11:52 -0700 [thread overview]
Message-ID: <20210913081152.296cea15@hermes.local> (raw)
In-Reply-To: <20210913120951.103968-1-usama.nadeem@emumba.com>
On Mon, 13 Sep 2021 17:09:51 +0500
usamanadeem321 <usama.nadeem@emumba.com> wrote:
>
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM)
> + local_port_conf.rxmode.offloads |=
> + DEV_RX_OFFLOAD_IPV4_CKSUM;
> + else {
> + rte_exit(EXIT_FAILURE,
> + "IPV4 Checksum offload not available. (port %u) ",
> + portid);
> + }
> +
Why not just do it in software if not available. The IPv4 checksum
is so cheap many operating systems just always do it in software.
next prev parent reply other threads:[~2021-09-13 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:09 usamanadeem321
2021-09-13 15:11 ` Stephen Hemminger [this message]
2021-09-14 18:08 ` [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available Usama Nadeem
2021-09-14 18:28 ` Stephen Hemminger
2021-09-14 22:22 ` Ananyev, Konstantin
2021-09-14 23:44 ` Stephen Hemminger
2021-09-15 8:43 ` Ananyev, Konstantin
2021-10-08 15:51 ` [dpdk-dev] [PATCH v3] ipv4 and udp/tcp cksum verification through software Usama Nadeem
2021-10-14 18:43 ` [dpdk-dev] [PATCH v4] examples/l3fwd: " Usama Nadeem
2021-11-01 8:33 ` Usama Nadeem
2021-11-04 11:11 ` Walsh, Conor
2021-11-04 16:19 ` Medvedkin, Vladimir
2021-11-16 5:20 ` Usama Nadeem
2021-11-16 5:21 ` Usama Nadeem
2023-06-30 21:50 ` Stephen Hemminger
2021-11-04 13:19 ` Ananyev, Konstantin
2021-11-16 5:18 ` Usama Nadeem
2022-01-14 9:30 ` Usama Nadeem
2022-01-14 12:05 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913081152.296cea15@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=usama.nadeem@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).