From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF331A0C45; Mon, 13 Sep 2021 17:11:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2422A40151; Mon, 13 Sep 2021 17:11:58 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id F17454014F for ; Mon, 13 Sep 2021 17:11:56 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id g14so9150897pfm.1 for ; Mon, 13 Sep 2021 08:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FhvCpTv0jjin69u714EY+jSENsi5571+Q0l/j8Fhu64=; b=F89esBYZ1TbDD4tn9aDEzrXrPABtjGtjGHIMglM4YLDvWXg8W7YgiRcspePeOSUmJ5 XmMD3QYTxbPY8pNANWHf33a12tzXUSs1bZap6kbLnfzstY73WioVAd8nYTGXKGz7sc4a kNPENwOiR8Bo8cAuClophkhhDA3zsMKYqScQKRmfDlAY4XNFjOBvMCLbFXddB2vWKTeV JJh4XRzdxvz1QsGXTQR36eSrkycpBPCT+EL0iKIFL9+/kbjxOrOv46pKARx2ZQA5/E3J PXETS4z4i9zl7X5UP2Go2l9zOpwY+2asbO57ZIChhICyMobMCy9CI2zKA6XvimlvjuxH WVXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FhvCpTv0jjin69u714EY+jSENsi5571+Q0l/j8Fhu64=; b=MBmArRh2kgAMvQkmZEGkb4FFF5CeEKJnk5dXqbUjd/RgQ7XBjFikDuQVxWHleOVd4i 0TZku96aE3MrTj+5yhZdahS2/mLhmBklWtjmomDfcj1241qxWiIZ2uQh1GWsqcx+ZzeV hWryDn2HkJbgrHudhQOY5rnEGVDyfW/UdojxjcKbMGHC87N0aCQw0sKUjPI/oduHTDfR QEwXWCU8pVXxM3uelqloD+LU0XqZOb9eLgPSUIZBIQ5Oj0c6o24/K+n0yr0F9N63O6XW XCV9RI8R0nFSF7OYDAWPnxCvjRxyY+2CG7Bk3Z7NNbW52p3dfrafpjUJ7QRo+HfVCbZL ptSA== X-Gm-Message-State: AOAM532aZs0zEDlV4o1XxN2lnzGt27uCF7FZaoQLNfGIga8DpHM2sVba eujsqHvr2N7x3JRR8PdarBZJZJfmtNMmvw== X-Google-Smtp-Source: ABdhPJwrbMz8SPQPuQaz/C8ofgnRCSX5SebZg8WYqU+l2vmLp8F6R1XMAAerEBZRbb2KgzLI50paLQ== X-Received: by 2002:a05:6a00:a8a:b029:356:be61:7f18 with SMTP id b10-20020a056a000a8ab0290356be617f18mr54150pfl.29.1631545915872; Mon, 13 Sep 2021 08:11:55 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id v3sm4737091pfc.193.2021.09.13.08.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 08:11:55 -0700 (PDT) Date: Mon, 13 Sep 2021 08:11:52 -0700 From: Stephen Hemminger To: usamanadeem321 Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20210913081152.296cea15@hermes.local> In-Reply-To: <20210913120951.103968-1-usama.nadeem@emumba.com> References: <20210913120951.103968-1-usama.nadeem@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples: ipv4, udp and tcp checksum offload warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 13 Sep 2021 17:09:51 +0500 usamanadeem321 wrote: > > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_IPV4_CKSUM; > + else { > + rte_exit(EXIT_FAILURE, > + "IPV4 Checksum offload not available. (port %u) ", > + portid); > + } > + Why not just do it in software if not available. The IPv4 checksum is so cheap many operating systems just always do it in software.