From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API
Date: Mon, 13 Sep 2021 23:59:01 -0700 [thread overview]
Message-ID: <20210913235901.25eb6df3@hermes.local> (raw)
In-Reply-To: <89fa6c37-3ad0-f454-6ab3-cc47592ebba7@huawei.com>
On Tue, 14 Sep 2021 11:25:44 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> Thanks Thomas,
> I am not sure if we need to print combined slaves speed.
> How about others' opinion ? @all
>
> BTW, If yes, one possible option may be like that:
> +const char *
> +rte_eth_link_speed_to_str(uint32_t link_speed)
> +{
> + char name[16];
> +
> + if (link_speed == ETH_SPEED_NUM_NONE)
> + return "None";
> + if (link_speed == ETH_SPEED_NUM_NONE)
> + return "Unknown";
> + if (link_speed < ETH_SPEED_NUM_1G) {
> + snprintf(name, sizeof(name), "%u Mbps", link_speed);
> + } else {
> + snprintf(name, sizeof(name), "%u Mbps",
> + link_speed / ETH_SPEED_NUM_1G);
> + }
> +
> + return name;
> +}
>
> But the float value is difficult to handle, like 2.5 Gbps for show. Any
> advices?
>
> 在 2021/9/13 18:26, Thomas Monjalon 写道:
> > 13/09/2021 10:45, Min Hu (Connor):
> >> Hi all,
> >> I have questions about rte_eth_link_speed_to_str API.
> >> The API converts link speed to string for display, But it only
> >> supports the following speeds, like that:
> >> case ETH_SPEED_NUM_NONE: return "None";
> >> case ETH_SPEED_NUM_10M: return "10 Mbps";
> >> case ETH_SPEED_NUM_100M: return "100 Mbps";
> >> case ETH_SPEED_NUM_1G: return "1 Gbps";
> >> case ETH_SPEED_NUM_2_5G: return "2.5 Gbps";
> >> case ETH_SPEED_NUM_5G: return "5 Gbps";
> >> case ETH_SPEED_NUM_10G: return "10 Gbps";
> >> case ETH_SPEED_NUM_20G: return "20 Gbps";
> >> case ETH_SPEED_NUM_25G: return "25 Gbps";
> >> case ETH_SPEED_NUM_40G: return "40 Gbps";
> >> case ETH_SPEED_NUM_50G: return "50 Gbps";
> >> case ETH_SPEED_NUM_56G: return "56 Gbps";
> >> case ETH_SPEED_NUM_100G: return "100 Gbps";
> >> case ETH_SPEED_NUM_200G: return "200 Gbps";
> >> case ETH_SPEED_NUM_UNKNOWN: return "Unknown";
> >> default: return "Invalid";
> >>
> >> In some cases, like bonding, for example, three slaves which
> >> link speed are 10Gbps, so link speed of bonding port will be
> >> 30Gbps, but it shows "Invalid".
> >>
> >> Is this reasonable? any comments will be welcome.
> >
> > Is it meaningful to print combined slaves speed?
> > If yes, we can do better then this fixed switch/case logic,
> > it shouldn't be too hard given it is a standard uint32_t value.
> >
> >
> > .
> >
Since all the values are encoded numerically do some math.
This is what iproute2 has evolved to doing..
int print_color_rate(bool use_iec, enum output_type type, enum color_attr color,
const char *key, const char *fmt, unsigned long long rate)
{
unsigned long kilo = use_iec ? 1024 : 1000;
const char *str = use_iec ? "i" : "";
static char *units[5] = {"", "K", "M", "G", "T"};
char *buf;
int rc;
int i;
if (_IS_JSON_CONTEXT(type))
return print_color_lluint(type, color, key, "%llu", rate);
rate <<= 3; /* bytes/sec -> bits/sec */
for (i = 0; i < ARRAY_SIZE(units) - 1; i++) {
if (rate < kilo)
break;
if (((rate % kilo) != 0) && rate < 1000*kilo)
break;
rate /= kilo;
}
rc = asprintf(&buf, "%.0f%s%sbit", (double)rate, units[i],
i > 0 ? str : "");
if (rc < 0)
return -1;
rc = print_color_string(type, color, key, fmt, buf);
free(buf);
}
next prev parent reply other threads:[~2021-09-14 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 8:45 Min Hu (Connor)
2021-09-13 10:26 ` Thomas Monjalon
2021-09-14 3:25 ` Min Hu (Connor)
2021-09-14 6:59 ` Stephen Hemminger [this message]
2021-09-14 13:04 ` Min Hu (Connor)
2021-09-16 2:56 ` [dpdk-dev] [RFC] ethdev: improve link speed to string Min Hu (Connor)
2021-09-16 6:22 ` Andrew Rybchenko
2021-09-16 8:16 ` Min Hu (Connor)
2021-09-16 8:21 ` Andrew Rybchenko
2021-09-17 0:43 ` Min Hu (Connor)
2021-10-30 9:59 ` Morten Brørup
2021-11-01 0:23 ` Min Hu (Connor)
2023-01-19 11:41 ` Ferruh Yigit
2023-01-19 16:45 ` Stephen Hemminger
2023-02-10 14:41 ` Ferruh Yigit
2023-03-23 14:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913235901.25eb6df3@hermes.local \
--to=stephen@networkplumber.org \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=keith.wiles@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).