From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFCE2A0C41; Wed, 15 Sep 2021 18:25:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB4F841123; Wed, 15 Sep 2021 18:25:46 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id B9EC14014F for ; Wed, 15 Sep 2021 18:25:45 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id o8so1980743pll.1 for ; Wed, 15 Sep 2021 09:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cfkp64C+gpI3FDNZxqkYCY1ANHr/jdxt74IpqPPxY/I=; b=XcA0JvE7vTZUSFjc5I6kNmJ7kiD6Dh0M4BfZUe01tuUDiMeSRGiKcJAG8km2o35s/w JL8H1TxIY0RVcYmLMX/AXGpin49w3OOp9Vgw8p7NKy48a/mbkbXhd0B/dyxJ+v2s90bD emCxKVqQpkGE0e1HvscBdDoMSBCB2I73Dcfyqsv0R7Uhxsw0EiEW2JVRyXSzVes8ZOPo J6M1MdQ0FrGwYo4jQyRNTazP4xHQSWTTMHObJQ5/eNDrgdfb2qMChnXBjkKjl3faZBE6 451DvbvGrC5HB7BAdyOcjZSQNKPGQP7oE+fli2xAaF7CHMZeoHjCsJJGLps4sUe+hacf skeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cfkp64C+gpI3FDNZxqkYCY1ANHr/jdxt74IpqPPxY/I=; b=g7gEDQ9pBcpYPO9YY0Vc63ZDwcSRgkqF6wKgy5XpyU68Ah7/I8VhupovDgA/USh8XS snO8RGHPpcX5Yk7bCY4aA1ObgWn4z2lYVHCRTQVaUeObFUcJpbwjAiR+9m8xG/YAT8A7 sgH2yLn3JA+h84vBzrbX5TVEwtPliiotoRjNTGkFdBS2o4qiRp3hkfZQDo1JeQdCSlrs YSgUrURtj9zdzdio1aUTlD/kOhq/A0T3MfuHtFaLyFkSESXX23+l3Ktv/CVdpd0tEz52 xUmE9V4hWWx4ug93P5soBNdG7bOkoUzeO+Ta6WLMLSxcFs+4NQlwjHmjUeq71egyV5zj RBqQ== X-Gm-Message-State: AOAM5314a1YaT4ErqRAhmC0iaEyShSHedGLitrKMV9XgikY6xzeBZ6Rh iN7blTP2Pz2+P1sOVa604WV02A== X-Google-Smtp-Source: ABdhPJwqtOdzIfaV1cO6FU82SZZi1R0K/YO8OXcJvYlrbxUGDu6DPqQ360evpEPfM+g/46SXZBUsgQ== X-Received: by 2002:a17:902:8494:b0:13b:9365:6f12 with SMTP id c20-20020a170902849400b0013b93656f12mr433232plo.19.1631723144881; Wed, 15 Sep 2021 09:25:44 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id s192sm468843pgc.23.2021.09.15.09.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:25:44 -0700 (PDT) Date: Wed, 15 Sep 2021 09:25:41 -0700 From: Stephen Hemminger To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" Message-ID: <20210915092541.789204b8@hermes.local> In-Reply-To: References: <20210903004732.109023-1-stephen@networkplumber.org> <20210913181510.46058-1-stephen@networkplumber.org> <20210913181510.46058-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 04/12] bpf: add function to convert classic BPF to DPDK BPF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 15 Sep 2021 11:02:20 +0000 "Ananyev, Konstantin" wrote: > > +if dpdk_conf.has('RTE_PORT_PCAP') > > Do we really need that 'if' above? > Why not to always have it enabled? The converter code needs libpcap for the pcap header files that define the encoding of classic BPF (struct bpf_insn).