From: Stephen Hemminger <stephen@networkplumber.org>
To: Akhil Goyal <gakhil@marvell.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>,
<david.marchand@redhat.com>, <hemant.agrawal@nxp.com>,
<anoobj@marvell.com>, <pablo.de.lara.guarch@intel.com>,
<fiona.trahe@intel.com>, <declan.doherty@intel.com>,
<matan@nvidia.com>, <g.singh@nxp.com>, <roy.fan.zhang@intel.com>,
<jianjay.zhou@huawei.com>, <asomalap@amd.com>,
<ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields
Date: Wed, 15 Sep 2021 09:43:43 -0700 [thread overview]
Message-ID: <20210915094343.674ac28f@hermes.local> (raw)
In-Reply-To: <20210731181327.660296-5-gakhil@marvell.com>
On Sat, 31 Jul 2021 23:43:27 +0530
Akhil Goyal <gakhil@marvell.com> wrote:
> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
> index 88d31de0a6..4606425e8d 100644
> --- a/lib/security/rte_security.h
> +++ b/lib/security/rte_security.h
> @@ -181,6 +181,12 @@ struct rte_security_ipsec_sa_options {
> * * 0: Disable per session security statistics collection for this SA.
> */
> uint32_t stats : 1;
> +
> + /** Reserved bit fields for future extension
> + *
> + * Note: reduce number of bits in reserved_opts for every new option
> + */
> + uint32_t reserved_opts : 24;
> };
>
> /** IPSec security association direction */
You must add a check that these are 0 otherwise they are useless as being
reserved later. You can't assume the old application will leave these bits
as zero.
next prev parent reply other threads:[~2021-09-15 16:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 18:13 [dpdk-dev] [PATCH 0/4] cryptodev and security ABI improvements Akhil Goyal
2021-07-31 18:13 ` [dpdk-dev] [PATCH 1/4] cryptodev: remove LIST_END enumerators Akhil Goyal
2021-07-31 18:13 ` [dpdk-dev] [PATCH 2/4] cryptodev: promote asym APIs to stable Akhil Goyal
2021-08-30 15:49 ` Kusztal, ArkadiuszX
2021-09-03 15:17 ` Akhil Goyal
2021-09-07 11:42 ` Kusztal, ArkadiuszX
2021-09-07 11:45 ` Akhil Goyal
2021-09-08 12:37 ` Kinsella, Ray
2023-02-02 10:49 ` [EXT] " Akhil Goyal
2023-02-02 11:02 ` Hemant Agrawal
2023-02-14 18:05 ` Kusztal, ArkadiuszX
2021-07-31 18:13 ` [dpdk-dev] [PATCH 3/4] security: hide internal API Akhil Goyal
2021-09-15 15:54 ` Ananyev, Konstantin
2021-07-31 18:13 ` [dpdk-dev] [PATCH 4/4] security: add reserved bitfields Akhil Goyal
2021-09-15 15:55 ` Ananyev, Konstantin
2021-09-15 16:43 ` Stephen Hemminger [this message]
2021-07-31 18:17 ` [dpdk-dev] [PATCH 0/4] cryptodev and security ABI improvements Akhil Goyal
2021-10-08 20:45 ` [dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators Akhil Goyal
2021-10-08 20:45 ` [dpdk-dev] [PATCH v2 2/3] security: hide internal API Akhil Goyal
2021-10-12 8:50 ` Kinsella, Ray
2021-10-08 20:45 ` [dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields Akhil Goyal
2021-10-11 8:31 ` Thomas Monjalon
2021-10-11 16:58 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-11 22:15 ` Stephen Hemminger
2021-10-12 8:31 ` Kinsella, Ray
2021-10-12 6:59 ` Thomas Monjalon
2021-10-12 8:53 ` Kinsella, Ray
2021-10-12 8:50 ` [dpdk-dev] " Kinsella, Ray
2021-10-11 10:46 ` [dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators Zhang, Roy Fan
2021-10-12 9:55 ` Kinsella, Ray
2021-10-12 10:19 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-12 10:50 ` Anoob Joseph
2021-10-12 11:28 ` Kinsella, Ray
2021-10-12 11:34 ` Anoob Joseph
2021-10-12 11:52 ` Thomas Monjalon
2021-10-12 13:38 ` Anoob Joseph
2021-10-12 13:54 ` Thomas Monjalon
2021-10-12 14:18 ` Anoob Joseph
2021-10-12 14:47 ` Kinsella, Ray
2021-10-12 15:06 ` Thomas Monjalon
2021-10-13 5:36 ` Anoob Joseph
2021-10-13 7:02 ` Thomas Monjalon
2021-10-13 7:04 ` Anoob Joseph
2021-10-13 8:39 ` Kinsella, Ray
2021-10-18 5:22 ` [dpdk-dev] [PATCH v3 1/2] security: hide internal API Akhil Goyal
2021-10-18 5:22 ` [dpdk-dev] [PATCH v3 2/2] security: add reserved bitfields Akhil Goyal
2021-10-18 15:39 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915094343.674ac28f@hermes.local \
--to=stephen@networkplumber.org \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jianjay.zhou@huawei.com \
--cc=matan@nvidia.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).