From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A96A0C41; Wed, 15 Sep 2021 18:43:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A8FD4068F; Wed, 15 Sep 2021 18:43:48 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id CF8B84014F for ; Wed, 15 Sep 2021 18:43:47 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id f129so3313581pgc.1 for ; Wed, 15 Sep 2021 09:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E4yeI8cqJU+lUuX7qrUUvFNQLyhYYogF9FyrnoL1FeU=; b=ybGhm955ie0d3hlLhGsIkMemGwh+AQb8wPjmi+dHOegwADQ1B1gKnCTgJxx63Mykp+ Ak1UPQg26RyIyVqlT6kqjGt8qk+nXPm/z8OquoujjlXL67Z8q9o1lCq21bi8wf0NT7VN RxMF3z+QM3Luc9yEQ5NegsvUQE1wTiKOvSylcquiUZK1QOOQPjkV2JPyZiHwSac+WwI8 pmd/n1LTKSokjOZ/wycJg/2jNVqRot1C31yNlUTHMB/2xEag/YJmAoUm7a86n+MmhfWO 00IEJ88Tadr6t8p4hfPFyO5XVOjEV/bKHybEsrCyob4OCo4wbzX1T9OKvEbFzkB5y0Cn 7Gmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E4yeI8cqJU+lUuX7qrUUvFNQLyhYYogF9FyrnoL1FeU=; b=7JVvWZmDygYqVH6kV9s9zxlyKttXpNH2orOxelnuOGZwqi6GD4akFGDXJ5xskOiyu8 5QuJ1WKVEMl+qXt3134lwDKmdJSOb1YsvHNcM91Unvt9rG3uMNWnPayio2LpN6SR9NCu ln6C2b2BKzS2312Jf7DMC2IhZSaihmIDNzHS3DpIBOHcRXvOoH2kCiIXrIYQWGnIy55x FWCX+6irFoG11NVYpiG86Hcw3AGQndbBnAS0JBbp/Vp7B6Wyp/Lh2GrXAhJuxQvz6phz 2AHJDrI1bA3vt70Ewa+CWaLxOqaDFifg2ozCBB+8yVpKq+TPxOWXzOZCrNdzE6JGFiSG cc/Q== X-Gm-Message-State: AOAM530EV/7XXNdzjceu3ipKthNplmg92LBwBDLpbxkmiFauvTLnVNho nFk2KnMy3V/coWCJQLXvKGA2pw== X-Google-Smtp-Source: ABdhPJxVRHb1/NlYlJk2rh9JmXKRUfEVHf1Lwc3+ET6OyVC9wWvIEfH6Bs1U/5BZuyEcJ/W7kbgymA== X-Received: by 2002:a65:5086:: with SMTP id r6mr621421pgp.65.1631724226804; Wed, 15 Sep 2021 09:43:46 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id e16sm411350pfc.214.2021.09.15.09.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:43:46 -0700 (PDT) Date: Wed, 15 Sep 2021 09:43:43 -0700 From: Stephen Hemminger To: Akhil Goyal Cc: , , , , , , , , , , , , , Message-ID: <20210915094343.674ac28f@hermes.local> In-Reply-To: <20210731181327.660296-5-gakhil@marvell.com> References: <20210731181327.660296-1-gakhil@marvell.com> <20210731181327.660296-5-gakhil@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 31 Jul 2021 23:43:27 +0530 Akhil Goyal wrote: > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 88d31de0a6..4606425e8d 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -181,6 +181,12 @@ struct rte_security_ipsec_sa_options { > * * 0: Disable per session security statistics collection for this SA. > */ > uint32_t stats : 1; > + > + /** Reserved bit fields for future extension > + * > + * Note: reduce number of bits in reserved_opts for every new option > + */ > + uint32_t reserved_opts : 24; > }; > > /** IPSec security association direction */ You must add a check that these are 0 otherwise they are useless as being reserved later. You can't assume the old application will leave these bits as zero.