From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F8A2A0C41; Wed, 15 Sep 2021 20:08:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E79BE4013F; Wed, 15 Sep 2021 20:08:11 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 5B3B84003F for ; Wed, 15 Sep 2021 20:08:11 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id n18so2132696plp.7 for ; Wed, 15 Sep 2021 11:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PxAl6bmrWLKrN+4nGxD9AqFtIQ4v3wY3vV6mPP5zSO0=; b=c1Y8EkRHLwvV4oGIQW64pSlSkNzLFtMEt4V8MQqglOlthcw6HYYbNYcnkyO3P8+TgS TkehiqOebuXfAYY+b39Lp1Mkb9O5uZB7m6RwCiSW8BggGJ+LfzWDdr4r9UMd7p1kez4I OpRyDQkePY7JB0Vs7cAtbV8xC/lQaW3qC+PJBqasaQTT6zmBANatmRfJSVc5uGEQsMV6 DDxVS08nTVHFq+iA43U7LyDt5X1/dcOKZWcbD7/31YReLbH1QfXgUzO4+P4bfgx2A/u5 GC1xSj52yaZfj+Lwdp3E4U35O7PKMhvcWrZ59PlYicBYFKcH3ZimJW5TqOzfQDK684iw 43+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PxAl6bmrWLKrN+4nGxD9AqFtIQ4v3wY3vV6mPP5zSO0=; b=buLHJjPOhtcV11/6mhWSbTWJSxi9kZFzONuR4gstbFfUDnpEIi6Ga6SmipBuq20FFa 8/REIGYZQe4h/+po0cv65S/9PLLYVzpGpdc16osRdyhAQaYYUE3CkejBhkvJOp1cHF6i B4lextuDpdkEDFz5+VCMGHtX1pUn6AsIZq2rwP9QIvC55/4HnG1PakFCIWHRclBQ/2ZQ oAHncJMuBXFObQ5QrLZ9ME9SbjnC19cRl5hBoKTycT2FEAYULgCn5QhKow8hUxwi4/vd MH7esXpICubJd8RItcGzvAlCHiHrIPYlvresghVGFheTlA4a/6RJIWAswfgx2SEpONqr A8cw== X-Gm-Message-State: AOAM531SXN9BUdVNW86uJthnUaqmIXDuGid6dOEyEnXrgYzP3A47JpG6 q3BCwu12iMjmCCsMouxzjchGgw== X-Google-Smtp-Source: ABdhPJwrDHU7zYJ0de79E06Ro6qelqXqJ+SjX4+N0Kld49yG1LYO8JB8zy8Vhw7hStYyQNDBy2rgjw== X-Received: by 2002:a17:902:6f01:b0:13b:7b8b:84a3 with SMTP id w1-20020a1709026f0100b0013b7b8b84a3mr847643plk.40.1631729290500; Wed, 15 Sep 2021 11:08:10 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id t14sm566764pga.62.2021.09.15.11.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 11:08:10 -0700 (PDT) Date: Wed, 15 Sep 2021 11:08:07 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, Konstantin Ananyev , Akhil Goyal , Declan Doherty , David Hunt , Anatoly Burakov , Ferruh Yigit , Andrew Rybchenko , Jerin Jacob , Vladimir Medvedkin , Nithin Dabilpuram , Pavan Nikhilesh , Honnappa Nagarahalli , Olivier Matz Message-ID: <20210915110807.6cf0fd26@hermes.local> In-Reply-To: <20210915164636.3015197-1-thomas@monjalon.net> References: <20210915164636.3015197-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] lib: remove C++ include guard from private headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 15 Sep 2021 18:46:35 +0200 Thomas Monjalon wrote: > The private headers are compiled internally with a C compiler. > Thus extern "C" declaration is useless in such files. > > Signed-off-by: Thomas Monjalon > --- Makes sense, make sure it doesn't break Windows builds. There is not a C++ application regression test in CI.