From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8E06A0C41; Wed, 15 Sep 2021 21:05:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3F7E4003F; Wed, 15 Sep 2021 21:05:26 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 069104003C for ; Wed, 15 Sep 2021 21:05:25 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id h16so8356406lfk.10 for ; Wed, 15 Sep 2021 12:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2GjcW5c1P/3L5BLL/pq8qc6uAfZJ++82W/X/c33hLLs=; b=h9t4kbw9qeL3uZy695SaqFaa8veo9A78aIEN+AdDDlL7xumfNeA8JV510kxYH07Zm1 vZlSLSPSIRJIl6SKigAyzKQe5w6qsCsQYS9EXGKC5YCxyduk3DoeyqbRvsaDrrVGlEPi J2bGSPepvgNvMgl/KCD4t4A8uzlWiE17Aq++c0tUJPKrB69YWYBCMoblk6Z2DBeMzxFt jMExWKy+jeVqRJUEuWycUgD0oPjPZZonFsHZxSX2QYaRxgw+X6/btvgT3Rh9jwv1LM04 16E3wMtfXOryPhfURqud1hVm/4gbZTOUcHKi+u2IXu32QRNshQBDmSmacR7mAtfovpxn mjIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2GjcW5c1P/3L5BLL/pq8qc6uAfZJ++82W/X/c33hLLs=; b=G1M1TUAZYxRsOGxO0aLXl0xjT/gusOKfyp9BQ978mo0TuJSboxckBfwT9sjmz68eEd 5Nlew5N8EK/UOvvcOcDe3EZMencNYLO8HvQL1JqFKzGJzgAO4425sr1qSlXRRRVvyg+8 sdMPWq4cURuF7cllbDq2CARue1pmru1P97o3+yhnsScIYPBr6MsucohJhYClxs5iHq0T sJYysJ0n0q5Cy+XS7EEkccrpukmp9HhDkRPrpQHQA6eksRXpnDE2fJQDMrWVtzsyQ4Nu jJ6mKgL84fdY8zeR3lCA5mb+ddFy+kKiGuoG84iQmeU/2vORLBWlAAeex4/09iQXryaY w2qQ== X-Gm-Message-State: AOAM533bZtjdxl04Kq00Z1ZlVDLBPnZdrOtqlAVbRh/xWbTUEL4lFMtS 8Qi9QYehdXWOlNTdTnZ67rg= X-Google-Smtp-Source: ABdhPJxtJBq4CIGueHLCiaXkHOzV7g1J0qd5O6EqCcDRHZ7G2Vug5sN7PkSy+vxlplEqRJ5B0Za6mA== X-Received: by 2002:a05:6512:128f:: with SMTP id u15mr1137161lfs.528.1631732725453; Wed, 15 Sep 2021 12:05:25 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id br38sm53131lfb.305.2021.09.15.12.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 12:05:21 -0700 (PDT) Date: Wed, 15 Sep 2021 22:05:17 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com Message-ID: <20210915220517.656c8167@sovereign> In-Reply-To: <20210915184448.92751-1-u9012063@gmail.com> References: <20210915184448.92751-1-u9012063@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-09-15 18:44 (UTC+0000), William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. Tal Shnaiderman posted patches for cryptodev and security today, so I won't comment on that part. IMO your patch should depend on them (https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies). [...] > diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h > index cacf724198..fe28029ef7 100644 > --- a/drivers/net/ixgbe/base/ixgbe_osdep.h > +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h > @@ -17,6 +17,12 @@ > #include > #include > > +#ifndef RTE_EXEC_ENV_WINDOWS > +#include > +#else > +#include > +#endif > + #include instead.