* [dpdk-dev] [PATCH] vhost: Normalize return type and function name
@ 2021-09-16 3:25 Xuan Ding
2021-09-16 4:34 ` [dpdk-dev] [PATCH v2] vhost: normalize " Xuan Ding
0 siblings, 1 reply; 4+ messages in thread
From: Xuan Ding @ 2021-09-16 3:25 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia
Cc: jiayu.hu, cheng1.jiang, bruce.richardson, sunil.pai.g,
YvonneX.Yang, Xuan Ding
In function definitions, adjust some return types and function names on a
separate line to be consistent with DPDK coding style.
---
lib/vhost/vhost.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 24ae1025ea..69e9d229af 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1500,7 +1500,8 @@ rte_vhost_get_vdpa_device(int vid)
return dev->vdpa_dev;
}
-int rte_vhost_get_log_base(int vid, uint64_t *log_base,
+int
+rte_vhost_get_log_base(int vid, uint64_t *log_base,
uint64_t *log_size)
{
struct virtio_net *dev = get_device(vid);
@@ -1514,7 +1515,8 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base,
return 0;
}
-int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_get_vring_base(int vid, uint16_t queue_id,
uint16_t *last_avail_idx, uint16_t *last_used_idx)
{
struct vhost_virtqueue *vq;
@@ -1543,7 +1545,8 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
return 0;
}
-int rte_vhost_set_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_set_vring_base(int vid, uint16_t queue_id,
uint16_t last_avail_idx, uint16_t last_used_idx)
{
struct vhost_virtqueue *vq;
@@ -1606,7 +1609,8 @@ rte_vhost_get_vring_base_from_inflight(int vid,
return 0;
}
-int rte_vhost_extern_callback_register(int vid,
+int
+rte_vhost_extern_callback_register(int vid,
struct rte_vhost_user_extern_ops const * const ops, void *ctx)
{
struct virtio_net *dev = get_device(vid);
@@ -1854,7 +1858,8 @@ rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t queue_id)
return 0;
}
-int rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
+int
+rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
{
struct vhost_virtqueue *vq;
struct virtio_net *dev = get_device(vid);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] vhost: normalize return type and function name
2021-09-16 3:25 [dpdk-dev] [PATCH] vhost: Normalize return type and function name Xuan Ding
@ 2021-09-16 4:34 ` Xuan Ding
2021-09-16 7:20 ` Xia, Chenbo
2021-09-28 15:34 ` Maxime Coquelin
0 siblings, 2 replies; 4+ messages in thread
From: Xuan Ding @ 2021-09-16 4:34 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia
Cc: jiayu.hu, cheng1.jiang, bruce.richardson, sunil.pai.g,
YvonneX.Yang, Xuan Ding
In some function definitions, adjust return type and function name on
a separate line to be consistent with DPDK coding style.
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v2:
* Fixed one format issue.
---
lib/vhost/vhost.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 24ae1025ea..69e9d229af 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1500,7 +1500,8 @@ rte_vhost_get_vdpa_device(int vid)
return dev->vdpa_dev;
}
-int rte_vhost_get_log_base(int vid, uint64_t *log_base,
+int
+rte_vhost_get_log_base(int vid, uint64_t *log_base,
uint64_t *log_size)
{
struct virtio_net *dev = get_device(vid);
@@ -1514,7 +1515,8 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base,
return 0;
}
-int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_get_vring_base(int vid, uint16_t queue_id,
uint16_t *last_avail_idx, uint16_t *last_used_idx)
{
struct vhost_virtqueue *vq;
@@ -1543,7 +1545,8 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
return 0;
}
-int rte_vhost_set_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_set_vring_base(int vid, uint16_t queue_id,
uint16_t last_avail_idx, uint16_t last_used_idx)
{
struct vhost_virtqueue *vq;
@@ -1606,7 +1609,8 @@ rte_vhost_get_vring_base_from_inflight(int vid,
return 0;
}
-int rte_vhost_extern_callback_register(int vid,
+int
+rte_vhost_extern_callback_register(int vid,
struct rte_vhost_user_extern_ops const * const ops, void *ctx)
{
struct virtio_net *dev = get_device(vid);
@@ -1854,7 +1858,8 @@ rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t queue_id)
return 0;
}
-int rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
+int
+rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
{
struct vhost_virtqueue *vq;
struct virtio_net *dev = get_device(vid);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] vhost: normalize return type and function name
2021-09-16 4:34 ` [dpdk-dev] [PATCH v2] vhost: normalize " Xuan Ding
@ 2021-09-16 7:20 ` Xia, Chenbo
2021-09-28 15:34 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Xia, Chenbo @ 2021-09-16 7:20 UTC (permalink / raw)
To: Ding, Xuan, dev, maxime.coquelin
Cc: Hu, Jiayu, Jiang, Cheng1, Richardson, Bruce, Pai G, Sunil, Yang, YvonneX
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Thursday, September 16, 2021 12:34 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: Hu, Jiayu <jiayu.hu@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Pai G, Sunil
> <sunil.pai.g@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>
> Subject: [PATCH v2] vhost: normalize return type and function name
>
> In some function definitions, adjust return type and function name on
> a separate line to be consistent with DPDK coding style.
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v2:
> * Fixed one format issue.
> ---
> lib/vhost/vhost.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
> --
> 2.17.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Thanks for the clean-up!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: normalize return type and function name
2021-09-16 4:34 ` [dpdk-dev] [PATCH v2] vhost: normalize " Xuan Ding
2021-09-16 7:20 ` Xia, Chenbo
@ 2021-09-28 15:34 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2021-09-28 15:34 UTC (permalink / raw)
To: Xuan Ding, dev, chenbo.xia
Cc: jiayu.hu, cheng1.jiang, bruce.richardson, sunil.pai.g, YvonneX.Yang
On 9/16/21 06:34, Xuan Ding wrote:
> In some function definitions, adjust return type and function name on
> a separate line to be consistent with DPDK coding style.
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v2:
> * Fixed one format issue.
> ---
> lib/vhost/vhost.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-28 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 3:25 [dpdk-dev] [PATCH] vhost: Normalize return type and function name Xuan Ding
2021-09-16 4:34 ` [dpdk-dev] [PATCH v2] vhost: normalize " Xuan Ding
2021-09-16 7:20 ` Xia, Chenbo
2021-09-28 15:34 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).