DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] devtools: add acronyms in dictionary for commit checks
@ 2021-09-17 10:03 Ashwin Sekhar T K
  2021-09-17 10:06 ` [dpdk-dev] [PATCH v2] " Ashwin Sekhar T K
  2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
  0 siblings, 2 replies; 18+ messages in thread
From: Ashwin Sekhar T K @ 2021-09-17 10:03 UTC (permalink / raw)
  To: dev
  Cc: jerinj, skori, skoteshwar, pbhagavatula, kirankumark, psatheesh,
	asekhar, anoobj, gakhil, ferruh.yigit

Update word list with Marvell specific acronyms.

CPT  -> Cryptographic Accelerator Unit
LBK  -> Loopback Interface Unit
LMT  -> Large Atomic Store Unit
MCAM -> Match Content Addressable Memory
NIX  -> Network Interface Controller Unit
NPA  -> Network Pool Allocator
NPC  -> Network Parser and CAM Unit
ROC  -> Rest Of Chip
RVU  -> Resource Virtualization Unit
SSO  -> Schedule Syncronize Order Unit
TIM  -> Timer Unit

Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
 devtools/words-case.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index 0bbad48626..713d47c081 100644
--- a/devtools/words-case.txt
+++ b/devtools/words-case.txt
@@ -6,6 +6,7 @@ Arm
 armv7
 armv8
 BAR
+CPT
 CRC
 DCB
 DevX
@@ -33,10 +34,12 @@ L2
 L3
 L4
 LACP
+LBK
 Linux
 LRO
 LSC
 MAC
+MCAM
 MPLS
 MSI
 MSI-X
@@ -44,6 +47,9 @@ MSS
 MTU
 NEON
 NIC
+NIX
+NPA
+NPC
 null
 NUMA
 NVGRE
@@ -57,11 +63,13 @@ PVID
 QinQ
 RDMA
 RETA
+ROC
 RSS
 Rx
 SCTP
 SMP
 SoC
+SSO
 SW
 TC
 TCAM
-- 
2.32.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [dpdk-dev] [PATCH v2] devtools: add acronyms in dictionary for commit checks
  2021-09-17 10:03 [dpdk-dev] [PATCH v1] devtools: add acronyms in dictionary for commit checks Ashwin Sekhar T K
@ 2021-09-17 10:06 ` Ashwin Sekhar T K
  2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
  1 sibling, 0 replies; 18+ messages in thread
From: Ashwin Sekhar T K @ 2021-09-17 10:06 UTC (permalink / raw)
  To: dev
  Cc: jerinj, skori, skoteshwar, pbhagavatula, kirankumark, psatheesh,
	asekhar, anoobj, gakhil, ferruh.yigit

Update word list with Marvell specific acronyms.

CPT  -> Cryptographic Accelerator Unit
LBK  -> Loopback Interface Unit
LMT  -> Large Atomic Store Unit
MCAM -> Match Content Addressable Memory
NIX  -> Network Interface Controller Unit
NPA  -> Network Pool Allocator
NPC  -> Network Parser and CAM Unit
ROC  -> Rest Of Chip
RVU  -> Resource Virtualization Unit
SSO  -> Schedule Synchronize Order Unit
TIM  -> Timer Unit

Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
 devtools/words-case.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index 0bbad48626..50aded9ce8 100644
--- a/devtools/words-case.txt
+++ b/devtools/words-case.txt
@@ -6,6 +6,7 @@ Arm
 armv7
 armv8
 BAR
+CPT
 CRC
 DCB
 DevX
@@ -33,10 +34,13 @@ L2
 L3
 L4
 LACP
+LBK
 Linux
+LMT
 LRO
 LSC
 MAC
+MCAM
 MPLS
 MSI
 MSI-X
@@ -44,6 +48,9 @@ MSS
 MTU
 NEON
 NIC
+NIX
+NPA
+NPC
 null
 NUMA
 NVGRE
@@ -57,15 +64,19 @@ PVID
 QinQ
 RDMA
 RETA
+ROC
 RSS
+RVU
 Rx
 SCTP
 SMP
 SoC
+SSO
 SW
 TC
 TCAM
 Thor
+TIM
 TOS
 TPID
 TSO
-- 
2.32.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 10:03 [dpdk-dev] [PATCH v1] devtools: add acronyms in dictionary for commit checks Ashwin Sekhar T K
  2021-09-17 10:06 ` [dpdk-dev] [PATCH v2] " Ashwin Sekhar T K
@ 2021-09-17 10:58 ` Ashwin Sekhar T K
  2021-09-17 11:03   ` Jerin Jacob
                     ` (2 more replies)
  1 sibling, 3 replies; 18+ messages in thread
From: Ashwin Sekhar T K @ 2021-09-17 10:58 UTC (permalink / raw)
  To: dev
  Cc: jerinj, skori, skoteshwar, pbhagavatula, kirankumark, psatheesh,
	asekhar, anoobj, gakhil, ferruh.yigit, david.marchand, thomas

Update word list with Marvell specific acronyms.

CPT  -> Cryptographic Accelerator Unit
CQ   -> Completion Queue
LBK  -> Loopback Interface Unit
LMT  -> Large Atomic Store Unit
MCAM -> Match Content Addressable Memory
NIX  -> Network Interface Controller Unit
NPA  -> Network Pool Allocator
NPC  -> Network Parser and CAM Unit
ROC  -> Rest Of Chip
RQ   -> Receive Queue
RVU  -> Resource Virtualization Unit
SQ   -> Send Queue
SSO  -> Schedule Synchronize Order Unit
TIM  -> Timer Unit

Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
 devtools/words-case.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index 0bbad48626..0ea23689f0 100644
--- a/devtools/words-case.txt
+++ b/devtools/words-case.txt
@@ -6,6 +6,8 @@ Arm
 armv7
 armv8
 BAR
+CPT
+CQ
 CRC
 DCB
 DevX
@@ -33,10 +35,13 @@ L2
 L3
 L4
 LACP
+LBK
 Linux
+LMT
 LRO
 LSC
 MAC
+MCAM
 MPLS
 MSI
 MSI-X
@@ -44,6 +49,9 @@ MSS
 MTU
 NEON
 NIC
+NIX
+NPA
+NPC
 null
 NUMA
 NVGRE
@@ -57,15 +65,21 @@ PVID
 QinQ
 RDMA
 RETA
+ROC
+RQ
 RSS
+RVU
 Rx
 SCTP
 SMP
 SoC
+SQ
+SSO
 SW
 TC
 TCAM
 Thor
+TIM
 TOS
 TPID
 TSO
-- 
2.32.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
@ 2021-09-17 11:03   ` Jerin Jacob
  2021-11-25 11:30     ` Thomas Monjalon
  2021-09-17 12:55   ` Thomas Monjalon
  2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
  2 siblings, 1 reply; 18+ messages in thread
From: Jerin Jacob @ 2021-09-17 11:03 UTC (permalink / raw)
  To: Ashwin Sekhar T K
  Cc: dpdk-dev, Jerin Jacob, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh, Kiran Kumar K,
	Satheesh Paul, Anoob Joseph, Akhil Goyal, Ferruh Yigit,
	David Marchand, Thomas Monjalon

On Fri, Sep 17, 2021 at 4:32 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> Update word list with Marvell specific acronyms.
>
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit
> MCAM -> Match Content Addressable Memory
> NIX  -> Network Interface Controller Unit
> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip
> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>

Reviewed-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  devtools/words-case.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/devtools/words-case.txt b/devtools/words-case.txt
> index 0bbad48626..0ea23689f0 100644
> --- a/devtools/words-case.txt
> +++ b/devtools/words-case.txt
> @@ -6,6 +6,8 @@ Arm
>  armv7
>  armv8
>  BAR
> +CPT
> +CQ
>  CRC
>  DCB
>  DevX
> @@ -33,10 +35,13 @@ L2
>  L3
>  L4
>  LACP
> +LBK
>  Linux
> +LMT
>  LRO
>  LSC
>  MAC
> +MCAM
>  MPLS
>  MSI
>  MSI-X
> @@ -44,6 +49,9 @@ MSS
>  MTU
>  NEON
>  NIC
> +NIX
> +NPA
> +NPC
>  null
>  NUMA
>  NVGRE
> @@ -57,15 +65,21 @@ PVID
>  QinQ
>  RDMA
>  RETA
> +ROC
> +RQ
>  RSS
> +RVU
>  Rx
>  SCTP
>  SMP
>  SoC
> +SQ
> +SSO
>  SW
>  TC
>  TCAM
>  Thor
> +TIM
>  TOS
>  TPID
>  TSO
> --
> 2.32.0
>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
  2021-09-17 11:03   ` Jerin Jacob
@ 2021-09-17 12:55   ` Thomas Monjalon
  2021-09-17 13:54     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
  2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
  2 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-09-17 12:55 UTC (permalink / raw)
  To: Ashwin Sekhar T K
  Cc: dev, jerinj, skori, skoteshwar, pbhagavatula, kirankumark,
	psatheesh, asekhar, anoobj, gakhil, ferruh.yigit, david.marchand

17/09/2021 12:58, Ashwin Sekhar T K:
> Update word list with Marvell specific acronyms.
> 
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit

How LMT means that?

> MCAM -> Match Content Addressable Memory

Is it specific to a device?

> NIX  -> Network Interface Controller Unit

Where is it used? Is it different of NIC?

> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip

All these stuff look device-specific. Please add details.

> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit






^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 12:55   ` Thomas Monjalon
@ 2021-09-17 13:54     ` Ashwin Sekhar Thalakalath Kottilveetil
  2021-09-17 14:05       ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Ashwin Sekhar Thalakalath Kottilveetil @ 2021-09-17 13:54 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, ferruh.yigit, david.marchand

Please see other comments inline.

Ashwin Sekhar T K 

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, September 17, 2021 6:26 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil
> Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Satheesh Paul <psatheesh@marvell.com>;
> Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> ferruh.yigit@intel.com; david.marchand@redhat.com
> Subject: [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for
> commit checks
> 
> External Email
> 
> ----------------------------------------------------------------------
> 17/09/2021 12:58, Ashwin Sekhar T K:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> 
> How LMT means that?
LMT is how the Large Atomic Store Unit in the CNXK devices is referred to as.
It will be difficult to put a 1:1 mapping between the letters and actual
names.
> 
> > MCAM -> Match Content Addressable Memory
> 
> Is it specific to a device?
This is specific to Marvell CNXK devices.
> 
> > NIX  -> Network Interface Controller Unit
> 
> Where is it used? Is it different of NIC?
It is used throughout the CNXK driver code (drivers/net/cnxk). This is not same as
NIC.
> 
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
> 
> All these stuff look device-specific. Please add details.
Please suggest where to add details. 
> 
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 13:54     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
@ 2021-09-17 14:05       ` Thomas Monjalon
  2021-09-17 14:53         ` Ashwin Sekhar Thalakalath Kottilveetil
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-09-17 14:05 UTC (permalink / raw)
  To: Ashwin Sekhar Thalakalath Kottilveetil
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, ferruh.yigit, david.marchand

17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > Update word list with Marvell specific acronyms.
> > >
> > > CPT  -> Cryptographic Accelerator Unit
> > > CQ   -> Completion Queue
> > > LBK  -> Loopback Interface Unit
> > > LMT  -> Large Atomic Store Unit
> > 
> > How LMT means that?
> LMT is how the Large Atomic Store Unit in the CNXK devices is referred to as.
> It will be difficult to put a 1:1 mapping between the letters and actual
> names.
> > 
> > > MCAM -> Match Content Addressable Memory
> > 
> > Is it specific to a device?
> This is specific to Marvell CNXK devices.
> > 
> > > NIX  -> Network Interface Controller Unit
> > 
> > Where is it used? Is it different of NIC?
> It is used throughout the CNXK driver code (drivers/net/cnxk). This is not same as
> NIC.
> > 
> > > NPA  -> Network Pool Allocator
> > > NPC  -> Network Parser and CAM Unit
> > > ROC  -> Rest Of Chip
> > 
> > All these stuff look device-specific. Please add details.
> Please suggest where to add details. 
> > 
> > > RQ   -> Receive Queue
> > > RVU  -> Resource Virtualization Unit
> > > SQ   -> Send Queue
> > > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit

Please add details in the commit log so we understand they are Marvell acronyms.

One more question: why is useful to add? Some people forget uppercases?





^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 14:05       ` Thomas Monjalon
@ 2021-09-17 14:53         ` Ashwin Sekhar Thalakalath Kottilveetil
  2021-09-17 16:15           ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Ashwin Sekhar Thalakalath Kottilveetil @ 2021-09-17 14:53 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, ferruh.yigit, david.marchand


> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, September 17, 2021 7:35 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil
> Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Satheesh Paul <psatheesh@marvell.com>;
> Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> ferruh.yigit@intel.com; david.marchand@redhat.com
> Subject: Re: [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for
> commit checks
> 
> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > > Update word list with Marvell specific acronyms.
> > > >
> > > > CPT  -> Cryptographic Accelerator Unit
> > > > CQ   -> Completion Queue
> > > > LBK  -> Loopback Interface Unit
> > > > LMT  -> Large Atomic Store Unit
> > >
> > > How LMT means that?
> > LMT is how the Large Atomic Store Unit in the CNXK devices is referred to
> as.
> > It will be difficult to put a 1:1 mapping between the letters and
> > actual names.
> > >
> > > > MCAM -> Match Content Addressable Memory
> > >
> > > Is it specific to a device?
> > This is specific to Marvell CNXK devices.
> > >
> > > > NIX  -> Network Interface Controller Unit
> > >
> > > Where is it used? Is it different of NIC?
> > It is used throughout the CNXK driver code (drivers/net/cnxk). This is
> > not same as NIC.
> > >
> > > > NPA  -> Network Pool Allocator
> > > > NPC  -> Network Parser and CAM Unit ROC  -> Rest Of Chip
> > >
> > > All these stuff look device-specific. Please add details.
> > Please suggest where to add details.
> > >
> > > > RQ   -> Receive Queue
> > > > RVU  -> Resource Virtualization Unit
> > > > SQ   -> Send Queue
> > > > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> 
> Please add details in the commit log so we understand they are Marvell
> acronyms.
Commit log already mentions these are Marvell specific acronyms. I did not
add explanation for each of them as this would make the message too long.
> 
> One more question: why is useful to add? Some people forget uppercases?
Upper case is desired but not really mandatory. This was a suggestion put
forth to me In one of the reviews.
https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/

I can abandon this change if you feel it is not appropriate to put many
device specific acronyms in the top level word list.
> 
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 14:53         ` Ashwin Sekhar Thalakalath Kottilveetil
@ 2021-09-17 16:15           ` Thomas Monjalon
  2021-09-20  9:05             ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-09-17 16:15 UTC (permalink / raw)
  To: Ashwin Sekhar Thalakalath Kottilveetil
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, ferruh.yigit, david.marchand

17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > > > Update word list with Marvell specific acronyms.
[...]
> > Please add details in the commit log so we understand they are Marvell
> > acronyms.
> Commit log already mentions these are Marvell specific acronyms. I did not
> add explanation for each of them as this would make the message too long.

Oh yes, I missed it, sorry.

> > One more question: why is useful to add? Some people forget uppercases?
> 
> Upper case is desired but not really mandatory. This was a suggestion put
> forth to me In one of the reviews.
> https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/
> 
> I can abandon this change if you feel it is not appropriate to put many
> device specific acronyms in the top level word list.

No strong opinion, but I think the patch is OK.
David, Ferruh, opinions?



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 16:15           ` Thomas Monjalon
@ 2021-09-20  9:05             ` Ferruh Yigit
  2021-09-20  9:19               ` Ashwin Sekhar Thalakalath Kottilveetil
  0 siblings, 1 reply; 18+ messages in thread
From: Ferruh Yigit @ 2021-09-20  9:05 UTC (permalink / raw)
  To: Thomas Monjalon, Ashwin Sekhar Thalakalath Kottilveetil
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, david.marchand

On 9/17/2021 5:15 PM, Thomas Monjalon wrote:
> 17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
>> From: Thomas Monjalon <thomas@monjalon.net>
>>> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
>>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>>> 17/09/2021 12:58, Ashwin Sekhar T K:
>>>>>> Update word list with Marvell specific acronyms.
> [...]
>>> Please add details in the commit log so we understand they are Marvell
>>> acronyms.
>> Commit log already mentions these are Marvell specific acronyms. I did not
>> add explanation for each of them as this would make the message too long.
> 
> Oh yes, I missed it, sorry.
> 
>>> One more question: why is useful to add? Some people forget uppercases?
>>
>> Upper case is desired but not really mandatory. This was a suggestion put
>> forth to me In one of the reviews.
>> https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/
>>
>> I can abandon this change if you feel it is not appropriate to put many
>> device specific acronyms in the top level word list.
> 
> No strong opinion, but I think the patch is OK.
> David, Ferruh, opinions?
> 

Yes this is suggested to be sure acronyms are uppercase in the patch title.

But if an issue can be described in generic concepts, I am for using them to
instead of using device specific acronyms, to make commit logs less cryptic.
Like 'NIC' should be used instead of 'NIX'.

Similarly we can try to use long version of CQ/SQ/RQ, although we may need to
use them because of limited title length time to time.

Rest seems device specific abbreviations we may not escape to use them, so they
are OK to me.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
  2021-09-17 11:03   ` Jerin Jacob
  2021-09-17 12:55   ` Thomas Monjalon
@ 2021-09-20  9:07   ` Ferruh Yigit
  2021-09-20  9:10     ` Jerin Jacob
  2021-09-20  9:21     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
  2 siblings, 2 replies; 18+ messages in thread
From: Ferruh Yigit @ 2021-09-20  9:07 UTC (permalink / raw)
  To: Ashwin Sekhar T K, dev
  Cc: jerinj, skori, skoteshwar, pbhagavatula, kirankumark, psatheesh,
	anoobj, gakhil, david.marchand, thomas

On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> Update word list with Marvell specific acronyms.
> 
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit
> MCAM -> Match Content Addressable Memory
> NIX  -> Network Interface Controller Unit
> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip

Out of curiosity, what is "rest of chip"?

> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit
> 
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
@ 2021-09-20  9:10     ` Jerin Jacob
  2021-09-20 10:32       ` Ferruh Yigit
  2021-09-20  9:21     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
  1 sibling, 1 reply; 18+ messages in thread
From: Jerin Jacob @ 2021-09-20  9:10 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: Ashwin Sekhar T K, dpdk-dev, Jerin Jacob, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh, Kiran Kumar K,
	Satheesh Paul, Anoob Joseph, Akhil Goyal, David Marchand,
	Thomas Monjalon

On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory
> > NIX  -> Network Interface Controller Unit
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
>
> Out of curiosity, what is "rest of chip"?

All the HW accelerators excluding the CPU cores.

>
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit
> > TIM  -> Timer Unit
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20  9:05             ` Ferruh Yigit
@ 2021-09-20  9:19               ` Ashwin Sekhar Thalakalath Kottilveetil
  2021-09-20 10:31                 ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Ashwin Sekhar Thalakalath Kottilveetil @ 2021-09-20  9:19 UTC (permalink / raw)
  To: Ferruh Yigit, Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, david.marchand

> > Oh yes, I missed it, sorry.
> >
> >>> One more question: why is useful to add? Some people forget
> uppercases?
> >>
> >> Upper case is desired but not really mandatory. This was a suggestion
> >> put forth to me In one of the reviews.
> >> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org
> >> _project_dpdk_patch_20210830135231.2610152-2D1-2Dasekhar-
> 40marvell.co
> >> m_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=pYk-QOhvnkU-
> _75y0NKSn535ZotEGI
> >> _E69Py3Ppondk&m=tCLT4AyWr6-
> VYmqkdbD879kj0uDFhCqF6jjOWfe8Dn4&s=EWthslG
> >> Cy_OWH4bqcOEKKkweFTe4yHZ-2O5yqiKp39w&e=
> >>
> >> I can abandon this change if you feel it is not appropriate to put
> >> many device specific acronyms in the top level word list.
> >
> > No strong opinion, but I think the patch is OK.
> > David, Ferruh, opinions?
> >
> 
> Yes this is suggested to be sure acronyms are uppercase in the patch title.
> 
> But if an issue can be described in generic concepts, I am for using them to
> instead of using device specific acronyms, to make commit logs less cryptic.
Agree that certain commit logs could be re-worded and put in more
generic terms.

> Like 'NIC' should be used instead of 'NIX'.
But NIX and NIC are not exactly interchangeable. NIX refers to a co-processor.
NIX in conjunction with other co-processors (NPA, LMT etc.) delivers the
functionality of a NIC.

> 
> Similarly we can try to use long version of CQ/SQ/RQ, although we may need
> to use them because of limited title length time to time.
> 
> Rest seems device specific abbreviations we may not escape to use them, so
> they are OK to me.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
  2021-09-20  9:10     ` Jerin Jacob
@ 2021-09-20  9:21     ` Ashwin Sekhar Thalakalath Kottilveetil
  1 sibling, 0 replies; 18+ messages in thread
From: Ashwin Sekhar Thalakalath Kottilveetil @ 2021-09-20  9:21 UTC (permalink / raw)
  To: Ferruh Yigit, dev
  Cc: Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, david.marchand, thomas

> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory NIX  -> Network Interface
> > Controller Unit NPA  -> Network Pool Allocator NPC  -> Network Parser
> > and CAM Unit ROC  -> Rest Of Chip
> 
> Out of curiosity, what is "rest of chip"?
Anything which is non-CPU. Co-processors like NPA, NIX, etc. are collectively
referred to as ROC.
> 
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20  9:19               ` Ashwin Sekhar Thalakalath Kottilveetil
@ 2021-09-20 10:31                 ` Ferruh Yigit
  0 siblings, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2021-09-20 10:31 UTC (permalink / raw)
  To: Ashwin Sekhar Thalakalath Kottilveetil, Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh Bhagavatula,
	Kiran Kumar Kokkilagadda, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, david.marchand

On 9/20/2021 10:19 AM, Ashwin Sekhar Thalakalath Kottilveetil wrote:
>>> Oh yes, I missed it, sorry.
>>>
>>>>> One more question: why is useful to add? Some people forget
>> uppercases?
>>>>
>>>> Upper case is desired but not really mandatory. This was a suggestion
>>>> put forth to me In one of the reviews.
>>>> https://urldefense.proofpoint.com/v2/url?u=https-
>> 3A__patches.dpdk.org
>>>> _project_dpdk_patch_20210830135231.2610152-2D1-2Dasekhar-
>> 40marvell.co
>>>> m_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=pYk-QOhvnkU-
>> _75y0NKSn535ZotEGI
>>>> _E69Py3Ppondk&m=tCLT4AyWr6-
>> VYmqkdbD879kj0uDFhCqF6jjOWfe8Dn4&s=EWthslG
>>>> Cy_OWH4bqcOEKKkweFTe4yHZ-2O5yqiKp39w&e=
>>>>
>>>> I can abandon this change if you feel it is not appropriate to put
>>>> many device specific acronyms in the top level word list.
>>>
>>> No strong opinion, but I think the patch is OK.
>>> David, Ferruh, opinions?
>>>
>>
>> Yes this is suggested to be sure acronyms are uppercase in the patch title.
>>
>> But if an issue can be described in generic concepts, I am for using them to
>> instead of using device specific acronyms, to make commit logs less cryptic.
> Agree that certain commit logs could be re-worded and put in more
> generic terms.
> 
>> Like 'NIC' should be used instead of 'NIX'.
> But NIX and NIC are not exactly interchangeable. NIX refers to a co-processor.
> NIX in conjunction with other co-processors (NPA, LMT etc.) delivers the
> functionality of a NIC.
> 

Got it, my bad, I understood they are same. OK to keep it.

>>
>> Similarly we can try to use long version of CQ/SQ/RQ, although we may need
>> to use them because of limited title length time to time.
>>
>> Rest seems device specific abbreviations we may not escape to use them, so
>> they are OK to me.
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20  9:10     ` Jerin Jacob
@ 2021-09-20 10:32       ` Ferruh Yigit
  2021-11-03 16:44         ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Ferruh Yigit @ 2021-09-20 10:32 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Ashwin Sekhar T K, dpdk-dev, Jerin Jacob, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh, Kiran Kumar K,
	Satheesh Paul, Anoob Joseph, Akhil Goyal, David Marchand,
	Thomas Monjalon

On 9/20/2021 10:10 AM, Jerin Jacob wrote:
> On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
>>> Update word list with Marvell specific acronyms.
>>>
>>> CPT  -> Cryptographic Accelerator Unit
>>> CQ   -> Completion Queue
>>> LBK  -> Loopback Interface Unit
>>> LMT  -> Large Atomic Store Unit
>>> MCAM -> Match Content Addressable Memory
>>> NIX  -> Network Interface Controller Unit
>>> NPA  -> Network Pool Allocator
>>> NPC  -> Network Parser and CAM Unit
>>> ROC  -> Rest Of Chip
>>
>> Out of curiosity, what is "rest of chip"?
> 
> All the HW accelerators excluding the CPU cores.
> 

Thanks.

>>
>>> RQ   -> Receive Queue
>>> RVU  -> Resource Virtualization Unit
>>> SQ   -> Send Queue
>>> SSO  -> Schedule Synchronize Order Unit
>>> TIM  -> Timer Unit
>>>
>>> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-20 10:32       ` Ferruh Yigit
@ 2021-11-03 16:44         ` Ferruh Yigit
  0 siblings, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2021-11-03 16:44 UTC (permalink / raw)
  To: David Marchand, Thomas Monjalon
  Cc: Ashwin Sekhar T K, dpdk-dev, Jerin Jacob, Sunil Kumar Kori,
	Satha Koteswara Rao Kottidi, Pavan Nikhilesh, Kiran Kumar K,
	Satheesh Paul, Anoob Joseph, Akhil Goyal, Jerin Jacob

On 9/20/2021 11:32 AM, Ferruh Yigit wrote:
> On 9/20/2021 10:10 AM, Jerin Jacob wrote:
>> On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
>>>> Update word list with Marvell specific acronyms.
>>>>
>>>> CPT  -> Cryptographic Accelerator Unit
>>>> CQ   -> Completion Queue
>>>> LBK  -> Loopback Interface Unit
>>>> LMT  -> Large Atomic Store Unit
>>>> MCAM -> Match Content Addressable Memory
>>>> NIX  -> Network Interface Controller Unit
>>>> NPA  -> Network Pool Allocator
>>>> NPC  -> Network Parser and CAM Unit
>>>> ROC  -> Rest Of Chip
>>>
>>> Out of curiosity, what is "rest of chip"?
>>
>> All the HW accelerators excluding the CPU cores.
>>
> 
> Thanks.
> 
>>>
>>>> RQ   -> Receive Queue
>>>> RVU  -> Resource Virtualization Unit
>>>> SQ   -> Send Queue
>>>> SSO  -> Schedule Synchronize Order Unit
>>>> TIM  -> Timer Unit
>>>>
>>>> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>>>
> 

Hi David, Thomas,

Can we proceed with this patch if there is no more objection?

There are multiple 'cnxk' patches are using these acronyms,
it would be good the have them checked.
(Although I suspect Jerin already have the patch locally,
since there is no missuses in sent patches.)

patchwork:
https://patches.dpdk.org/project/dpdk/patch/20210917105839.270289-1-asekhar@marvell.com/

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks
  2021-09-17 11:03   ` Jerin Jacob
@ 2021-11-25 11:30     ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-11-25 11:30 UTC (permalink / raw)
  To: Ashwin Sekhar T K
  Cc: dev, Jerin Jacob, Sunil Kumar Kori, Satha Koteswara Rao Kottidi,
	Pavan Nikhilesh, Kiran Kumar K, Satheesh Paul, Anoob Joseph,
	Akhil Goyal, Ferruh Yigit, David Marchand, Jerin Jacob

17/09/2021 13:03, Jerin Jacob:
> On Fri, Sep 17, 2021 at 4:32 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
> >
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory
> > NIX  -> Network Interface Controller Unit
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit
> > TIM  -> Timer Unit
> 
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
> 
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-11-25 11:30 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 10:03 [dpdk-dev] [PATCH v1] devtools: add acronyms in dictionary for commit checks Ashwin Sekhar T K
2021-09-17 10:06 ` [dpdk-dev] [PATCH v2] " Ashwin Sekhar T K
2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
2021-09-17 11:03   ` Jerin Jacob
2021-11-25 11:30     ` Thomas Monjalon
2021-09-17 12:55   ` Thomas Monjalon
2021-09-17 13:54     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
2021-09-17 14:05       ` Thomas Monjalon
2021-09-17 14:53         ` Ashwin Sekhar Thalakalath Kottilveetil
2021-09-17 16:15           ` Thomas Monjalon
2021-09-20  9:05             ` Ferruh Yigit
2021-09-20  9:19               ` Ashwin Sekhar Thalakalath Kottilveetil
2021-09-20 10:31                 ` Ferruh Yigit
2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
2021-09-20  9:10     ` Jerin Jacob
2021-09-20 10:32       ` Ferruh Yigit
2021-11-03 16:44         ` Ferruh Yigit
2021-09-20  9:21     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git