From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: William Tu <u9012063@gmail.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows
Date: Sat, 25 Sep 2021 19:22:05 +0300 [thread overview]
Message-ID: <20210925192205.2419fdce@sovereign> (raw)
In-Reply-To: <20210924180816.150-1-u9012063@gmail.com>
2021-09-24 18:08 (UTC+0000), William Tu:
> Windows does not support linker option '/-no-whole-archive'
> or '/whole-archive'. The patch removes them under Windows build.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
> buildtools/pkg-config/meson.build | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Hi William,
We need to tell the linker to use whole archive somehow;
you write [1] that /WHOLEARCHIVE was required in the end.
There's no "Windows linker", there are clang and GCC linkers,
the latter supports --whole-archive, but the former needs it translated.
Argument translation between compilers is handled by meson.
I've filed a bug: https://github.com/mesonbuild/meson/issues/9296
[1]:
http://inbox.dpdk.org/dev/CALDO+SZ-FLPYNQbUJ-Ctwtph+M4_X_=zYAOKgkp5_un4QFq_eg@mail.gmail.com/
next prev parent reply other threads:[~2021-09-25 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 18:08 William Tu
2021-09-25 16:22 ` Dmitry Kozlyuk [this message]
2021-09-26 3:22 ` William Tu
2021-10-07 11:58 ` Thomas Monjalon
2021-10-07 12:04 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925192205.2419fdce@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).