From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC8D5A0C41; Tue, 28 Sep 2021 17:58:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5AC0410DB; Tue, 28 Sep 2021 17:58:13 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 772D140E3C for ; Tue, 28 Sep 2021 17:58:12 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id q23so19261280pfs.9 for ; Tue, 28 Sep 2021 08:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xu18FxZefdJbWornfTGReagoCDLlNrgFjX5a2snyAWI=; b=do4E/R45qwM8E0xUD4SvmdYkicygSxaoW3iZeJ1tfWc8tGv52DmXHvL8aWMhOajGj1 yL/IRW1tzkmLG3NLFdkr/AVT7VvvE56YQQl6QEa4s1JsHSrU8lTRtoc1VicB83EpQYJ7 mT9OwVoWuOcpY2OwQHoUvd35+cjLjiEW8nRwsB1wfQJ79Kriphtf9nV/8+LPbmZlajAK gXDbf9PpPrnkMjdxB+hEBoGndEcmdqcew+Fe6lP2r7ZEAlSwq4bH9ru+n9wyI7O2dDi6 UXn0sf1EWlXAmVv5RmoRGdH0dVsMVakvX9m7iflP8ByL2+tjLXavzo8L3bubhkMvS6wh FZyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xu18FxZefdJbWornfTGReagoCDLlNrgFjX5a2snyAWI=; b=7dGxEYzhqW5LM6dphhw8hNUW+b7p+cuGLWFiP/Qu6i8AmPtwkm+/Jchrs3Uz1+JpPr zcEBoHbQDEcZjcz+8tyY8kEUGk6dZXPG/2OtfQj4XOaj2zKch7e+FdWS6bqVyap+s7IK c99Q7QmwFdUBHMG98Rj+SPVajNU7gwUgrO9VBfgdBzo3IcfStWQRSqP5+Lgxe9E0HXYJ wpgh1b6gKgCuobYvLA+IXF47qoh7zhpF45mm3cNB31c2Nz9xqWJPYFSEAWkBpSnONpjc Y4DpdetSZ7GzcE56KMo6raEdXZFuLEiHjTrCSXl2x5ZBiFZ+uhYd9JR20EQDwf2Xismn +eFg== X-Gm-Message-State: AOAM532MFtjOLI6T7knAknRIQH3c5R8TrEfsiSHAO++BnF9mB30/OoGA kjjn0vWQmKymUJ+Zu1bHOWAjGw== X-Google-Smtp-Source: ABdhPJzciinm08eVUtP88/9ucRdSwQZCATMXEM5hoLmGf3j3j3YZcc1+v5cghNF3oUbmfx3WfIhWww== X-Received: by 2002:a63:af4a:: with SMTP id s10mr5244696pgo.469.1632844691046; Tue, 28 Sep 2021 08:58:11 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id 130sm8012088pfz.77.2021.09.28.08.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 08:58:10 -0700 (PDT) Date: Tue, 28 Sep 2021 08:58:07 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Ori Kam , Xiaoyun Li , Ray Kinsella , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Qiming Yang , Qi Zhang , Matan Azrad , Viacheslav Ovsiienko , Jerin Jacob , Jasvinder Singh , Cristian Dumitrescu , Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20210928085807.7bbb50c9@hermes.local> In-Reply-To: <20210928152300.989961-1-andrew.rybchenko@oktetlabs.ru> References: <20210928152300.989961-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 28 Sep 2021 18:23:00 +0300 Andrew Rybchenko wrote: > @@ -2498,24 +2498,11 @@ struct rte_flow_query_age { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > - * @deprecated Shared attribute is deprecated, use generic > - * RTE_FLOW_ACTION_TYPE_INDIRECT action. > - * > - * The shared flag indicates whether the counter is unique to the flow rule the > - * action is specified with, or whether it is a shared counter. > - * > - * For a count action with the shared flag set, then then a global device > - * namespace is assumed for the counter id, so that any matched flow rules using > - * a count action with the same counter id on the same port will contribute to > - * that counter. > - * > * For ports within the same switch domain then the counter id namespace extends > * to all ports within that switch domain. > */ > struct rte_flow_action_count { > - /** @deprecated Share counter ID with other flow rules. */ > - uint32_t shared:1; > - uint32_t reserved:31; /**< Reserved, must be zero. */ > + uint32_t reserved; /**< Reserved, must be zero. */ > uint32_t id; /**< Counter ID. */ Reserved fields are often source of future problems. You should change each driver to check that reserved field return -ENOTSUP if non-zero. That way if reserved field is ever used in future it won't break API/ABI. The other option is to just remove the reserved field and take the API/ABI hit now.