From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDBAA0C43; Tue, 28 Sep 2021 19:11:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F06DC410D7; Tue, 28 Sep 2021 19:10:59 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 2B8FC40E3C for ; Tue, 28 Sep 2021 19:10:59 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id w14so19488345pfu.2 for ; Tue, 28 Sep 2021 10:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9O373X067mDqVxQNaPSFdVas4BPfFAyy0OkvKzQyEUA=; b=U5Em3bPcSsGpb5utLg0x7ydS4kE5M/1+DN9+FMANgJ4/Tli7B3k4u+xmwLfqu9LT29 tD/vzALUN98EKttXsSdExtwol2rnyrVn3OMBfGtqiwuPvkd02APTgnu1NjCfmdphSNpx sQsgi51emDLlupeAk0/QY/8l5QFAUpaUddy/ud5GSuXAPmds0LDw/RvCpS43vy26bIzt ahESq+bPm3tCB8yMh9sGcQ7IuX56JPABOFyPCzQvjjXf5WMlKwohnKB8t0qYcUcOc+lj vBUfOlUmEXwZYCzvHMXvec2PMrBgT9q4lAkMchucqfV53++704RzFI3VlLx+MQyjyC44 LJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9O373X067mDqVxQNaPSFdVas4BPfFAyy0OkvKzQyEUA=; b=Po3lS839Bhhzsw8m/K6mZRX5CRNvpOUUY6ziJmy0w1AflugJBHP9oJi5/+oKsvlT2W nHY6SxhpWvQO9drMLwrASb8FF1OOuhN/IunqjXZGWTK9oJkDh7Jtu1Q/1WedS65Y46X6 N6PBCYtnh+F5wVKXUZeFlhn3hGpMff2ZFTgj2bViWwCK+5myCzkr18pOVoPRJkDGY07q hjlp2OR+HySESVJdEl4CFh0DK6mzsOxABQuKrLNS4wYDMvRwZQUKaHZsBX4RWiTxQqv9 RWpacsoFrrFzdqSYbkKRtATAiTQjU4FD5KD1GCP1Y2k0tapxoknOG/JupaLSk+RHzYvk mxgg== X-Gm-Message-State: AOAM532JD6bdFX/9aIBzr5HoOjtrktHOz+yu0XW6bhihWZfifNyQmDTo JvtNfZ5mMp5LuABkkxn2ogxs8A== X-Google-Smtp-Source: ABdhPJzhz9/eRM3K+Ft8hfmEiJxSRCJARMqUInnoUFz5TQCKmtWw+1dmySI46rtJeEZUmxcbKVjUMw== X-Received: by 2002:a63:b505:: with SMTP id y5mr5576087pge.91.1632849058277; Tue, 28 Sep 2021 10:10:58 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id k14sm22616739pga.65.2021.09.28.10.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 10:10:57 -0700 (PDT) Date: Tue, 28 Sep 2021 10:10:54 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Rasesh Mody , Shahed Shaikh , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Gagandeep Singh , John Daley , Hyong Youb Kim , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Harman Kalra , Ferruh Yigit , Xiao Wang , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org Message-ID: <20210928101054.0f6ad088@hermes.local> In-Reply-To: <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru> References: <20210928141627.904787-1-andrew.rybchenko@oktetlabs.ru> <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 28 Sep 2021 19:48:54 +0300 Andrew Rybchenko wrote: > Some drivers do not provide per-queue statistics. So, there is no point > to have these misleading zeros in xstats. > > Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") > Cc: stable@dpdk.org > > Signed-off-by: Andrew Rybchenko Really? It is useful to have zeros rather than random data there.