From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E840A0032;
	Fri,  1 Oct 2021 09:10:06 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A47864067A;
	Fri,  1 Oct 2021 09:10:05 +0200 (CEST)
Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com
 [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 7846A40040
 for <dev@dpdk.org>; Fri,  1 Oct 2021 09:10:04 +0200 (CEST)
Received: by mail-lf1-f44.google.com with SMTP id u18so35420759lfd.12
 for <dev@dpdk.org>; Fri, 01 Oct 2021 00:10:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=9+xYyDweVMOgS02yBnnHKZoQEx+X/G3hDDqQrnqsgcI=;
 b=jDegj0kxpV9PD+TmjAPsm7+ChpxpmDCayaBHOLHo+RHhmAVhZLOHUxLoohFwIy572o
 YEwEu0r7GvYqXSc7gKb+/I9+mK2HTOZbl+RuB4WZolpnAMe1qW7tM97w7hi9NpK4XFfY
 X5jJ2oCafG/oinI2tVhMglCPiATb0NL/fBEa97nWEztSQZU58MNAmzLERS6c6difCxbe
 NQq/5rB48yEU493tlhWwiSlVHkHqjIzn8A1IiZDB49ktzQUhtfUAxY4pl/rLKVe7mncx
 VHNPdeyJ6fxVtWjRXxiQglj14UGU5HYdBmYEgJ/1NhSrK4CxDZGQusnpfOjtF/zOcQWk
 776w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=9+xYyDweVMOgS02yBnnHKZoQEx+X/G3hDDqQrnqsgcI=;
 b=FciAeUckgmi/gNuBm5flhh9/Yir6R9C6bFunrBqxVdhW4lXVj+3FTLmB5djXPspkuE
 hcv5SLFMQZXVu2GHJflaXM05QNbLowT2GVibM1qQhk0t7V4UnRS4YAlErwFIoSzefdNf
 2ITprO4UzjwLBqUbMdNpgB/omQGDdKk68A9ChlaV1eo5lb0oFv+4cTodvQyE015T9qp8
 3EfUU5l0KeL8hbWfBUXjX0hrAUyWw23UmLI16ifywvLhGfhDEfdcF5Bd3S37T+1ysKkA
 4Lrq45WcoWuCAQ0gSTrwOBwXiNiuxXPY0FxKzT5m7rnqty719Vk4RuhPrQ1dmRgIjz+T
 O2TQ==
X-Gm-Message-State: AOAM530rSVcR07WmLqDGkCx+SY8ijIz+Uu50BNxLaqp/lkWyWWS1Oc/F
 /IzVqieTHaYy9EXdiyZ8EYs=
X-Google-Smtp-Source: ABdhPJw/45GCZFZUaHmeshrlh64PN1reW2yrWq3ujPj3yBGzP6MlioYJx8Fn0Q0iaQXPCwPDhlkDxg==
X-Received: by 2002:a2e:88c2:: with SMTP id a2mr10281809ljk.428.1633072204020; 
 Fri, 01 Oct 2021 00:10:04 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id b22sm635445lfs.27.2021.10.01.00.10.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 01 Oct 2021 00:10:03 -0700 (PDT)
Date: Fri, 1 Oct 2021 10:10:02 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Menon, Ranjit" <ranjit.menon@intel.com>
Cc: <dev@dpdk.org>, Dmitry Malloy <dmitrym@microsoft.com>, Narcisa Ana Maria
 Vasile <navasile@linux.microsoft.com>, Pallavi Kadam
 <pallavi.kadam@intel.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Nick Connolly <nick.connolly@mayadata.io>
Message-ID: <20211001101002.6741f032@sovereign>
In-Reply-To: <017c2682-4fd6-5fa3-08c3-3ad85d020560@intel.com>
References: <20210501171837.13282-1-dmitry.kozliuk@gmail.com>
 <20210526210147.1287-1-dmitry.kozliuk@gmail.com>
 <20210526210147.1287-5-dmitry.kozliuk@gmail.com>
 <017c2682-4fd6-5fa3-08c3-3ad85d020560@intel.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-09-30 15:07 (UTC-0700), Menon, Ranjit:
> [...]
> >     <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
> >       <ClCompile>
> > -      <WppEnabled>false</WppEnabled>
> > +      <WppEnabled>true</WppEnabled>
> >         <WppRecorderEnabled>true</WppRecorderEnabled>
> > -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> > +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">virt2phys_trace.h</WppScanConfigurationData>  
> 
> This change is also required for the 'Release|x64' configuration, 
> otherwise 'Release' builds fail.

Thanks Ranjit, will fix in v3.

> <snip!>
> 
> Also, it appears the newer version of the compiler (combined with the 
> new version of WDK/SDK), requires that the driver signing process 
> mandate a File Digest Algorithm (using the /fd option). It is a warning 
> today, but they claim it could become a requirement in the future.

Yes, it started with WDK 22000.1. On my system it's an error, not a warning.
I think I'll create a separate series with trivial fixes like this, so that
it can be merged quickly and fix the build with newer WDK.