From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD25A0032; Fri, 1 Oct 2021 11:36:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA4324067A; Fri, 1 Oct 2021 11:36:09 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id AE61240040 for ; Fri, 1 Oct 2021 11:36:07 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id m3so35985543lfu.2 for ; Fri, 01 Oct 2021 02:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g7gO0Zd9Eh07NiEAsXrfeV44FLk0l2YStfLRmmJcMEc=; b=ceweCGnGICTeJIyhLmXlrKiy5JO+x3b1yVhXXGSwyBUPWKM7Ek8lLpC0+S42WhcbnX N/b8KswIylNnPcigGOlbYZflzW7OOUhDXLPqEQ+l/dAvNBKOUjl+jhEsgHnJoq7O6T90 AOcTi1+Jfp9Ji5OPuqyu6J2DabiUX51UWzDl0jG4ts0QCqz4cbyZ6skTWZP+5+BUIxyk B5iS5z7JT8dgPElG8HihCd4Qv4I8bQAoNl53vZO30JbeTQHMS6BjEuYIAKfev2C7d1UV HignXH/uRB2ww5lulwisjCf/jf308hkXyGQ4+lTR0O2FxqtbpTgbC3Bmengd2aZjNCFP gqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g7gO0Zd9Eh07NiEAsXrfeV44FLk0l2YStfLRmmJcMEc=; b=OeHWGk/3P3dBZWtdI/vTT+5N3srAGXM2byvytq8Cvy9sxW54J+HhRl5mX3vEsQ51pX JKITtgo31XDLIfzvYXYtx7qmMNazwX2di1w7qz04uxO7jtm27el2wGu4RuWx34UjCx5X nxDEKPUtitK+Hf0S5GgfpCPjc44tzBlBUSOsaRTvP0Ttm0zfmKpm4hmed2wfNAB6Xzfv 5Zxwfamp7j4LpkLUuFI/M+ZFhIqn03D+fKNWRaEfJmopJuvyvbfDCgLu8MyF5UOBisBI H8jw8vNc3hkxqw4a9Xre7kYU4XNHdvqf5bIG86BnYfGQkNADyxKnYwm3zKDRHKUB+I4b 0Rjg== X-Gm-Message-State: AOAM533dXaWVAnqb2InD/KaCrp8FXjlxXYlPxvdw4PNcoN7i4KnBh6Jb KmYLxC8qwThRrNQ4feSUNMM= X-Google-Smtp-Source: ABdhPJzupXmpMYnVQ7TxZpt6/mrdhnt4aTflADW3xxsGjQkUyQ3ONsSqNXjX7QvvBqkaNeKdAHRg7Q== X-Received: by 2002:a05:6512:3147:: with SMTP id s7mr4402367lfi.472.1633080966897; Fri, 01 Oct 2021 02:36:06 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id s18sm675379lfo.177.2021.10.01.02.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 02:36:06 -0700 (PDT) Date: Fri, 1 Oct 2021 12:36:05 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: William Tu , Narcisa Ana Maria Vasile , Thomas Monjalon , dpdk-dev , Nick Connolly , Omar Cardona , Pallavi Kadam Message-ID: <20211001123605.00fa6402@sovereign> In-Reply-To: References: <20210823130343.87247-1-u9012063@gmail.com> <20210824162103.32783-1-u9012063@gmail.com> <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-01 09:27 (UTC+0200), David Marchand: > [...] > I just have a concern that headers get broken again if we have no check. > Could buildtools/chkincs do the job (if we make this check work on Windows)? It's a valid caoncern and yes, chkincs would be a solution. I discovered that the real issue with chkincs was a space after shebang in gen_c_file_for_header.py. If it is removed, find_program() is able to parse the line and call the script with Python interpreter. However, spaces *are* allowed after shebangs. Would you like me to submit a patch with a fix just chkincs or shall I *instead* work with meson developers (I'll do that anyway)? I'm asking because we have other files with extra spaces, so there's a question if we should fix them, add a rule for the space, etc.